Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove physical models #125720

Closed
dkwingsmt opened this issue Apr 28, 2023 · 1 comment · Fixed by flutter/engine#41593
Closed

Remove physical models #125720

dkwingsmt opened this issue Apr 28, 2023 · 1 comment · Fixed by flutter/engine#41593
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version

Comments

@dkwingsmt
Copy link
Contributor

Physical models have been deprecated a long time ago. There are still some logic that are specifically for them. We should remove them

Framework

  • PhysicalModelLayer

Engine

  • PhysicalShapeEngineLayer
  • SceneBuilder.pushPhysicalShape
  • PhysicalShapeLayer
  • {Preroll,Paint}Context.frame_device_pixel_ratio
@dkwingsmt dkwingsmt mentioned this issue Apr 28, 2023
Merged
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. c: tech-debt Technical debt, code quality, testing, etc. and removed in triage Presently being triaged by the triage team labels May 2, 2023
@goderbauer goderbauer added the P2 Important issues not at the top of the work list label May 2, 2023
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 3, 2023
@jonahwilliams
Remove physical model layer (#41593)
1057b40 
Removes the physical model layer and associated engine code. This was already deprecated and removed in the framework. By removing it in the engine, we can also remove the need for layer tree diff/paint/preroll to have the device pixel ratio. This will simplify some of the multi-view work

Fixes flutter/flutter#125720
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 4, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove physical model layer jonahwilliams/engine
3 participants
@goderbauer @dkwingsmt @danagbemava-nc