New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute macOS engine as an xcframework #126016
Comments
Some iOS work that would need to be done to work with macOS:
Related #70413 |
As long as we are reworking this script, changing artifacts, etc. it would be great if we could combine it with #70413, creating the structure described here |
Instead of using rsync, which has caused errors in the past (#99785), delete the file/directory/link prior to moving it. Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files Part of #126016.
Instead of using rsync, which has caused errors in the past (flutter#99785), delete the file/directory/link prior to moving it. Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files Part of flutter#126016.
Also before the old FlutterMacOS.framework can be removed, we'll need to let the Flutter release team know so they can update their roll scripts, and coordinate with the Fl@G team to make sure build rules are updated, if needed. |
Creates and adds FlutterMacOS.xcframework to out/mac or out/host. Creates and archives FlutterMacOS.xcframework when building mac_host_engine. Archives the xcframework in a new zipped folder at `darwin-x64/framework.zip`, `darwin-x64-profile/framework.zip`, `darwin-x64-release/framework.zip`. The FlutterMacOS.framework is also still archived currently - I thought it'd be better to keep it archived so we don't have to worry about the tool breaking until we're ready to remove it. Part of flutter/flutter#126016. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of #126016.
Reverts #143244 Initiated by: vashworth Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see #144251 Original PR Author: vashworth Reviewed By: {jmagman} This change reverts the following previous change: Original Description: Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`. Part of #126016.
For Swift Package Manager to work with macOS, the macOS engine artifact needs to be an xcframework.
flutter build macos-framework
and instead use the one in the artifact cache: Add FlutterMacOS.xcframework artifact #143244Example of when it was done for iOS: #60109
The text was updated successfully, but these errors were encountered: