Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rsync when unzipping artifacts on a Mac #126703

Merged
merged 3 commits into from May 16, 2023
Merged

Replace rsync when unzipping artifacts on a Mac #126703

merged 3 commits into from May 16, 2023

Conversation

vashworth
Copy link
Contributor

@vashworth vashworth commented May 12, 2023 •
edited

Instead of using rsync, which has caused errors in the past (#99785), delete the file/directory/link prior to moving it.

Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files

Part of #126016.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 12, 2023
@christopherfujino
Copy link
Member

Sorry I didn't finish reviewing, will get back to this this afternoon.

christopherfujino
christopherfujino approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter_tools/lib/src/base/os.dart Outdated
Comment on lines 427 to 429
/// Unzip into a temporary directory. For every file/directory/link in the
/// unzipped file, delete the corresponding entity in the [targetDirectory]
/// before moving from the temporary directory to the [targetDirectory].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Unzip into a temporary directory. For every file/directory/link in the
/// unzipped file, delete the corresponding entity in the [targetDirectory]
/// before moving from the temporary directory to the [targetDirectory].
/// Unzip into a temporary directory.
///
/// For every file/directory/link in the
/// unzipped file, delete the corresponding entity in the [targetDirectory]
/// before moving from the temporary directory to the [targetDirectory].

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit 2b3cd7f into flutter:master May 16, 2023
123 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
e2ef5c0 
…utter#126703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
084e6af 
…utter#126703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
374a7ab 
…utter#126703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
1dd7044 
…utter#126703)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
560862f 
…utter#126703)
This was referenced May 23, 2023
Closed
Closed
vashworth added a commit to vashworth/flutter that referenced this pull request May 23, 2023
@vashworth
Revert "Replace rsync when unzipping artifacts on a Mac (flutter#126703…
8501b4f 
…)"

This reverts commit 2b3cd7f.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@vashworth
Replace rsync when unzipping artifacts on a Mac (flutter#126703)
ce841df 
Instead of using rsync, which has caused errors in the past (flutter#99785), delete the file/directory/link prior to moving it.

Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files

Part of flutter#126016.
auto-submit bot pushed a commit that referenced this pull request May 24, 2023
@vashworth
Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" (#…
555326b 
…127430)

This reverts commit 2b3cd7f.

Fixes #127281.
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
cd897e9 
…utter#126703)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
9d56823 
…utter#126703)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
58accb4 
…utter#126703)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2b3cd7f4d Replace rsync when unzipping artifacts on a Mac (flutter/fl…
30f72ac 
…utter#126703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vashworth @christopherfujino