Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ErrorHint to RestorationScope.of #126443

Closed
Piinks opened this issue May 10, 2023 · 1 comment · Fixed by #126444
Closed

Add ErrorHint to RestorationScope.of #126443

Piinks opened this issue May 10, 2023 · 1 comment · Fixed by #126444
Assignees
@Piinks
Labels
a: error message Error messages from the Flutter framework a: state restoration RestorationManager and related APIs framework flutter/packages/flutter repository. See also f: labels.

Comments

@Piinks
Copy link
Contributor

Piinks commented May 10, 2023

Writing some tests recently, I realized the error message of RestorationScope.of(context) does not mention that maybe you need to enable state restoration for the app/subtree. We should add that to the message.
@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. a: error message Error messages from the Flutter framework a: state restoration RestorationManager and related APIs labels May 10, 2023
@Piinks Piinks self-assigned this May 10, 2023
@Piinks Piinks mentioned this issue May 10, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue May 15, 2023
@Piinks
Add more to error message of RestorationScope.of (#126444)
76a9f68 
Fixes #126443
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this issue May 24, 2023
@Piinks
Add more to error message of RestorationScope.of (flutter#126444)
ae89a79 
Fixes flutter#126443
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
a: error message Error messages from the Flutter framework a: state restoration RestorationManager and related APIs framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more to error message of RestorationScope.of Piinks/flutter
1 participant
@Piinks