Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more to error message of RestorationScope.of #126444

Merged
merged 3 commits into from May 15, 2023
Merged

Add more to error message of RestorationScope.of #126444

merged 3 commits into from May 15, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented May 10, 2023

Fixes #126443

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: error message Error messages from the Flutter framework a: state restoration RestorationManager and related APIs labels May 10, 2023
@Piinks Piinks requested a review from goderbauer May 10, 2023 16:49
goderbauer
goderbauer approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/widgets/restoration.dart Outdated Show resolved Hide resolved
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 12, 2023

auto label is removed for flutter/flutter, pr: 126444, due to - The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 12, 2023

auto label is removed for flutter/flutter, pr: 126444, due to - The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 12, 2023

auto label is removed for flutter/flutter, pr: 126444, due to - The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 15, 2023

auto label is removed for flutter/flutter, pr: 126444, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit 76a9f68 into flutter:master May 15, 2023
71 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
0f70fde 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
1ee8a0b 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
d09231d 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
603eff5 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
e6ef811 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
19d468f 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
a98039e 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
51f402a 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
4da8aef 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
ea50395 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
af469d0 
…lutter#126444)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
6870d67 
…lutter#126444)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@Piinks
Add more to error message of RestorationScope.of (flutter#126444)
ae89a79 
Fixes flutter#126443
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
676f114 
…lutter#126444)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
bee68f5 
…lutter#126444)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
ac64a69 
…lutter#126444)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
76a9f6832 Add more to error message of RestorationScope.of (flutter/f…
3ac86dd 
…lutter#126444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: error message Error messages from the Flutter framework a: state restoration RestorationManager and related APIs a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ErrorHint to RestorationScope.of
2 participants
@Piinks @goderbauer