[CP] Fix for CupertinoPicker and ListWheelViewport crash #126782
Comments
|
@Piinks can you review this CP request? If it looks good to you, add the "cp: approved" label. |
CaseyHillers
added
the
cp: merge-to-stable
|
@nt4f04uNd for the PR link section, can you open a new PR that CP's this to the current stable branch? The current stable is on flutter-3.10-candidate.1 |
Ahh, got you, done.
|
|
CP LGTM |
…26804) Fixes #126782 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
|
landed on stable |
|
@XilaiZhang is there something left to do here? |
|
we are currently working on packaging and publishing the stable. once it is published then we can close this issue. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
issue_link
#126491
Commit Hash
ae82f3c
Target
stable
pr_link
#126804
Impacted Users
Flutter devs who use CupertinoPicker or ListWheelViewport with certain configurations
Impact Description
It impacts only development builds, will not cause any problems in release builds.
Workaround
N/A
Risk
low
Test Coverage
yes
Validation Steps
No response
The text was updated successfully, but these errors were encountered: