Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash from invalid ListWheelViewport assertion #126539

Merged
merged 1 commit into from May 13, 2023
Merged

Fix crash from invalid ListWheelViewport assertion #126539

merged 1 commit into from May 13, 2023

Conversation

nt4f04uNd
Copy link
Member

@nt4f04uNd nt4f04uNd commented May 11, 2023 •
edited

Fixes #126491

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@nt4f04uNd nt4f04uNd added c: regression It was better in the past than it is now c: crash Stack traces logged to the console framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. labels May 11, 2023
@nt4f04uNd nt4f04uNd requested a review from Piinks May 11, 2023 13:19
@nt4f04uNd nt4f04uNd force-pushed the fix/126491/list-wheel-crash branch from 670aaa9 to fb293b9 Compare May 11, 2023 13:22
@nt4f04uNd nt4f04uNd force-pushed the fix/126491/list-wheel-crash branch from fb293b9 to 2568dbd Compare May 11, 2023 14:12
Piinks
Piinks approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thanks for the fix!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@Piinks
Copy link
Contributor

Piinks commented May 12, 2023

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

@nt4f04uNd
Copy link
Member Author

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

Yeah, I wrote this in the issue. Should I make the CP request issue?

@auto-submit auto-submit bot merged commit ae82f3c into flutter:master May 13, 2023
71 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
bcd082e 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
b6a054b 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
4b61e4b 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
228c58c 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
a466154 
…/flutter#126539)
@nt4f04uNd nt4f04uNd mentioned this pull request May 14, 2023
Closed
@nt4f04uNd
Copy link
Member Author

@nt4f04uNd did you say somewhere you would like this to be cherrypicked?

Yeah, I wrote this in the issue. Should I make the CP request issue?

Filed #126782

@nt4f04uNd nt4f04uNd deleted the fix/126491/list-wheel-crash branch May 14, 2023 18:43
nt4f04uNd added a commit to nt4f04uNd/flutter that referenced this pull request May 15, 2023
@nt4f04uNd
Fix crash from invalid ListWheelViewport assertion (flutter#126539)
4cc6064 
Fixes flutter#126491
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
ed10c66 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
c60b8cf 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
67c812b 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
830ca00 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
16ec44d 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
21f536b 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
f78628e 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
7462f57 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
0e892a5 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
34f954d 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
8df4f96 
…/flutter#126539)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
e9531a4 
…/flutter#126539)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@nt4f04uNd
Fix crash from invalid ListWheelViewport assertion (flutter#126539)
bf12d2b 
Fixes flutter#126491
@reidbaker reidbaker mentioned this pull request May 31, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
a927f61 
…/flutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
06c0807 
…/flutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
c6ae89b 
…/flutter#126539)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ae82f3cbc Fix crash from invalid ListWheelViewport assertion (flutter…
6cf9466 
…/flutter#126539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: crash Stack traces logged to the console c: regression It was better in the past than it is now f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CupertinoPicker] Child paint transform happened to be null.
2 participants
@nt4f04uNd @Piinks