-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update androidx window dependency to 1.1 #129307
Comments
Specifically there is a fix to a memory leak and a bugfix related to folding events after onPause. |
I've got steps 1-6 working, I can take care of this if I can get CIPD access for step 7 Requesting now |
@gmackall can add more detail but we found after updating this dependency flutter apps started failing to build because of a duplicate class issue caused by a kotlin lib dependency conflict. We think this will impact a non trivial number of customers so this bug is blocked until we can build a migrator for those customers. |
The error:
This stack overflow post has a lot of discussion and more detail about the issue. It doesn't occur with kotlin gradle plugin |
Instructions for updating engine dependencies. |
Re-opening for tracking purposes as the PR was reverted |
…0, and Fix test failures blocking androidx upgrade (#149204) PR to pave the way for flutter/engine#53001 to re-land Summary: - Enforces use of Kotlin >= `1.7.0` (please see below note) - Fixes ci failures that prevented the above PR from landing. Details: Because it landed initially, we are able to fake the roll in this PR to fix all the tests ([see my comment](#149204 (comment))). Fixes all the tests that failed: 1. `module_test` failing on multiple platforms (3/9 of the failures). Failure is ``` > Android resource linking failed ERROR:/b/s/w/ir/x/t/flutter_module_test.KECMXW/hello/.android/plugins_build_output/device_info/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/lStar not found. ``` This is a rather unhelpful error message but some [folks online suggest](https://stackoverflow.com/a/69050529) that upgrading your `compileSdk` version fixes this. These resolve when I remove the dependency on the long discontinued [package_info](https://pub.dev/packages/package_info) and [device_info](https://pub.dev/packages/device_info) packages, perhaps because they are transitively pulling in low `compileSdk` versions? This is unclear to me. 2. `module_custom_host_app_name_test` was failing for the same reason (another 3/9, or cumulative 6/9). 3. `tool_integration_tests_3_4` was a flake ð��� (7/9) 4. `framework_tests_slow` needed a newer version of the Kotlin Gradle plugin (the flutter tool tells us this, so I just upgraded as suggested) and it resolved (8/9) 5.`android_preview_tool_integration_tests` needed newer AGP and KGP versions. I also refactored the tests, and bumped our error versions, fixing #142653. **Note that the bump to KGP is not in line with our policy** - we didn't warn for `1.5.0-1.6.x` for a release (or at all) before dropping support. But I think it might still be justified: - The bump to our androidx libraries unblocks ongoing Scribe work, and also includes a fix for a [memory leak](#129307 (comment)) and a [crash on folding phones](#114868 (comment)), among many other bug fixes. - Gradle [doesn't test on half of that range](https://docs.gradle.org/current/userguide/compatibility.html#kotlin), and so we implicitly can't claim to support it either. More generally, our Java and Kotlin support ranges should probably strictly fall within what Gradle tests.
Re-closing as the re-land has landed |
Opening again, reverting the reland. |
Ok, landed again and this time the roll succeeded (roll: #150733, engine pr: flutter/engine#53532). So I'm going to close again |
Latest is that the upgrade to androidx dependencies breaks apps using plugins that use compileSdk < 31. That in itself is a problem, but we could announce it in breaking changes and have plugin developers upgrade. But unfortunately we currently use a plugin with compileSdk < 31 in our ci in the At this, to my knowledge this upgrade:
|
At this point #150952 is a couple of commits deep in the framework tree and everything is still green. So I'm going to close (hopefully for the last time, but I'll be keeping my eye out for any reverts). |
This is a request from the androidx team. There are bug fixes in 1.1 that should help customers.
tools/androidx/files.json looks like where it is defined
There are tests that depend on that verison number appearing in gradle check logs that will need to be updated (I think)
https://cs.opensource.google/search?q=androidx.window%20-language:java%20-filepath:lockfile&ss=flutter
The text was updated successfully, but these errors were encountered: