Reland "Upgrade all[most] androidx dependencies to latest" #53462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 18, 2024 11:21
gmackall
added
the
autosubmit
|
Thanks so much for the work here and in flutter/flutter#149204 to upgrade this! I really appreciate it for the scribe project 🙏. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2024
9 tasks
|
Reason for revert: blocking roll (see flutter/flutter#150465 (comment)). |
gmackall
added
the
revert
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jun 19, 2024
…53462)" (#53468) Reverts: #53462 Initiated by: gmackall Reason for reverting: blocking roll (see flutter/flutter#150465 (comment)). Original PR Author: gmackall Reviewed By: {reidbaker} This change reverts the following previous change: Relands #53001. Also pulls in @matanlurey's dependency on `androidx.lifecycle:lifecycle-process`, and upgrades it to `2.7.0`. It is unblocked by the changes in flutter/flutter#149204. Tested by building the engine, and then also by building the `flutter/packages` `all_packages` app on this branch, so that hopefully it will also roll smoothly into the packages repo. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 19, 2024
…150473) flutter/engine@0ad18fe...a312793 2024-06-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "Upgrade all[most] androidx dependencies to latest" (#53462)" (flutter/engine#53468) 2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f1642cd8bed to 1f97ab20d078 (1 revision) (flutter/engine#53465) 2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from f0bab26f6818 to 24a4123fc949 (2 revisions) (flutter/engine#53464) 2024-06-18 34871572+gmackall@users.noreply.github.com Reland "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53462) 2024-06-18 skia-flutter-autoroll@skia.org Roll Skia from 1675eeabb289 to f0bab26f6818 (2 revisions) (flutter/engine#53459) 2024-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TwoeJy5Tn0ARHF5O4... to u8WOst9tlXsVQ02eJ... (flutter/engine#53461) 2024-06-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7245875f5191 to 7f1642cd8bed (1 revision) (flutter/engine#53460) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from TwoeJy5Tn0AR to u8WOst9tlXsV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
|
Planning to re-land this once flutter/flutter#150585 lands |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2024
…utter_gallery`, roll pub packages (#150585) Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery` [`device_info`](https://pub.dev/packages/device_info): Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README. [`connectivity`](https://pub.dev/packages/connectivity): This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin. Unblocks the re-land of flutter/engine#53462 (itself a reland ð���), because of #150465 (comment).
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Re-re-land #53001 (Reland attempt was at #53462) Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles. Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
that referenced
this pull request
Jun 25, 2024
…t" (#53532)" (#53546) Reverts: #53532 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {reidbaker, matanlurey} This change reverts the following previous change: Re-re-land #53001 (Reland attempt was at #53462) Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles. Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This was referenced Jun 25, 2024
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
…utter_gallery`, roll pub packages (flutter#150585) Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery` [`device_info`](https://pub.dev/packages/device_info): Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README. [`connectivity`](https://pub.dev/packages/connectivity): This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin. Unblocks the re-land of flutter/engine#53462 (itself a reland ð���), because of flutter#150465 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #53001.
Also pulls in @matanlurey's dependency on
androidx.lifecycle:lifecycle-process, and upgrades it to2.7.0.It is unblocked by the changes in flutter/flutter#149204.
Tested by building the engine, and then also by building the
flutter/packagesall_packagesapp on this branch, so that hopefully it will also roll smoothly into the packages repo.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.