Regression in 99p raster times in tiles_scroll_perf on iOS #130594
Labels
c: performance
Relates to speed or footprint issues (see "perf:" labels)
e: impeller
Impeller rendering backend issues and features requests
perf: speed
Performance issues related to (mostly rendering) speed
platform-ios
iOS applications specifically
team-engine
Owned by Engine team
Comments
zanderso
added
platform-ios
|
My commit in there was a revert - I don't recall the original landing of it getting flagged for an improvement though |
|
It was my commit - which was a revert which is going to get relanded. |
|
I'll close this - it should imrpove again when we reland a safer patch. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Jul 14, 2023
…when a save layer is involved (#43695) Alternative to #43662 Records the basis vector of the current CTM into text contents and reuses that rather than trying to get it again at render time. That method breaks if perspective is involved in the CTM and a subpass gets translated, which can modify the scale (and rotation) of the matrix. We're definitely not doing things quite right with perspective here, but the real fix to that is to either record the fully transformed glyph into the atlas or to use SDF/path based rendering. Fixes flutter/flutter#130476 I still have some concerns about how `EntityPass::Render` is a mix of mutations and constness but we can try to address that independently. I expect this to re-improve the regression noted in flutter/flutter#130594
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this issue
Jul 20, 2023
…when a save layer is involved (flutter#43695) Alternative to flutter#43662 Records the basis vector of the current CTM into text contents and reuses that rather than trying to get it again at render time. That method breaks if perspective is involved in the CTM and a subpass gets translated, which can modify the scale (and rotation) of the matrix. We're definitely not doing things quite right with perspective here, but the real fix to that is to either record the fully transformed glyph into the atlas or to use SDF/path based rendering. Fixes flutter/flutter#130476 I still have some concerns about how `EntityPass::Render` is a mix of mutations and constness but we can try to address that independently. I expect this to re-improve the regression noted in flutter/flutter#130594
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
a7a353c
https://flutter-flutter-perf.skia.org/e/?begin=1689285778&end=1689317881&keys=X5d2af11e8f531e542f5cf0ab209f99bf&num_commits=50&request_type=1&xbaroffset=35735
cc @jonahwilliams @dnfield
The text was updated successfully, but these errors were encountered: