Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devicelab/infra] update cocoapods on devicelab machines to 1.13.0 #133096

Closed
jonahwilliams opened this issue Aug 22, 2023 · 12 comments
Closed

[devicelab/infra] update cocoapods on devicelab machines to 1.13.0 #133096

jonahwilliams opened this issue Aug 22, 2023 · 12 comments
Assignees
@godofredoc
Labels
infra: device lab Infrastructure device lab problems P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team

Comments

@jonahwilliams
Copy link
Member

See 5e9e959

flutter/gallery (and potentially other repos?) are now using cocoapods 1.12. Running with outdated cocoapods is causing errors as 1.11 does not seem forward compatible with them. Updating to 1.12 should be safe?
@darshankawar darshankawar added in triage Presently being triaged by the triage team team-infra Owned by Infrastructure team infra: device lab Infrastructure device lab problems and removed in triage Presently being triaged by the triage team labels Aug 23, 2023
@drewroengoogle
Copy link
Contributor

@yusuf-goog Are you the right person to assign this to? What exactly is needed to update cocoapods on devicelab machines?

@yusuf-goog
Copy link
Contributor

Yes, I would likely make the change. It would be valuable to get some confirmation from @vashworth on any impact it might have on other mac/ios issues.

@yusuf-goog
Copy link
Contributor

@jonahwilliams does this update need to be made only on the devicelab macs, or our "VM" fleet as well?

@jonahwilliams
Copy link
Member Author

To unblock this particular test, only the devicelab macs need to be updated.

@vashworth
Copy link
Contributor

vashworth commented Aug 23, 2023 •
edited
Loading

Yes, so there was this issue: #122057

It sounded like the fix was going to be a some changes to ruby/gems CIPD package

@yusuf-goog
Copy link
Contributor

referencing go/flutter-ruby

@XilaiZhang do you have instructions for : go/flutter-ruby#step-eight-codesigning

@XilaiZhang
Copy link
Contributor

referencing go/flutter-ruby

@XilaiZhang do you have instructions for : go/flutter-ruby#step-eight-codesigning

umm good point, after integrating codesigning tool to dart internal, i don't think we have a tool to sign a customized bundle anymore.

@godofredoc
Copy link
Contributor

We don't need a tool, just a couple of commands and the proper certificates. @XilaiZhang can you please share the command the tool executes?

Please also note that if updating cocoapods and the ruby bundles you'll need to create packages for x64 and arm64 and validate with all the tests before updating the references to the cipd packages in .ci.yaml

@drewroengoogle
Copy link
Contributor

Removing from ticket queue as this is not actively causing a breakage, but marking P1

@drewroengoogle drewroengoogle added the P1 High-priority issues at the top of the work list label Aug 28, 2023
@vashworth vashworth mentioned this issue Sep 25, 2023
Merged
8 tasks
@vashworth vashworth changed the title [devicelab/infra] update cocoapods on devicelab machines to 1.12.1 [devicelab/infra] update cocoapods on devicelab machines to 1.13.0 Sep 29, 2023
@vashworth vashworth mentioned this issue Sep 29, 2023
Closed
48 tasks
@godofredoc godofredoc assigned godofredoc and unassigned yusuf-goog Oct 6, 2023
godofredoc added a commit to godofredoc/cocoon that referenced this issue Oct 6, 2023
@godofredoc
Add scripts to generate ruby packages.
70811b3 
This is required to automatically create ruby packages for flutter
testing.

Bug: flutter/flutter#122057
Bug: flutter/flutter#125812
Bug: flutter/flutter#133096
@godofredoc godofredoc mentioned this issue Oct 6, 2023
Merged
8 tasks
godofredoc added a commit to godofredoc/cocoon that referenced this issue Oct 11, 2023
@godofredoc
Add scripts to generate ruby packages.
a2c7698 
This is required to automatically create ruby packages for flutter
testing.

Bug: flutter/flutter#122057
Bug: flutter/flutter#125812
Bug: flutter/flutter#133096
@vashworth
Copy link
Contributor

Umbrella bug for updating the ruby self contained package: #136377

auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Oct 12, 2023
@godofredoc
Add scripts to generate ruby packages. (#3125)
da89a97 
This is required to automatically create ruby packages for flutter testing.

Bug: flutter/flutter#122057
Bug: flutter/flutter#125812
Bug: flutter/flutter#133096
Bug: flutter/flutter#136377
@godofredoc
Copy link
Contributor

This is complete now.

@jonahwilliams jonahwilliams mentioned this issue Oct 25, 2023
Merged
fluttermirroringbot pushed a commit that referenced this issue Oct 25, 2023
@jonahwilliams
[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d5853d83d8…
aaf7184 
…9bda (#137199)

Reverts #133095

Dependencies have been fixed, hopefully : #133096 (comment)
@auto-submit auto-submit bot mentioned this issue Oct 25, 2023
Merged
auto-submit bot added a commit that referenced this issue Oct 25, 2023
@auto-submit
Reverts "[gallery] Reland roll gallery to ecfb9e5352bd12032301b12b30d…
bfc4c50 
…5853d83d89bda" (#137264)

Reverts #137199
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Reverts #133095

Dependencies have been fixed, hopefully : #133096 (comment)
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
infra: device lab Infrastructure device lab problems P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jonahwilliams @vashworth @XilaiZhang @godofredoc @darshankawar @yusuf-goog @drewroengoogle