Move //third_party/glfw from buildroot to //flutter/third_party/glfw #136284

cbracken · 2023-10-10T19:58:42Z

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.

Steps:

Buildroot: Migrate BUILD.gn to build/secondary/flutter/third_party/BUILD.gn Move //third_party/glfw to //flutter/third_party/glfw buildroot#777
Engine: Update DEPS and references to use new location/targets Move //third_party/glfw to //flutter/third_party/glfw engine#46733

This is an abridged form of a longer, stepwise migration that we may use for more complex future migrations:

Buildroot: Copy BUILD.gn to build/secondary/flutter/third_party/BUILD.gn
Engine: Update DEPS and references to use new location
Buildroot: Eliminate old BUILD.gn from build/secondary/third_party/BUILD.gn
Engine: Eliminate DEPS references to old location

Part of #67373

The text was updated successfully, but these errors were encountered:

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This will be followed by an engine PR that updates the deps pull GLFW to //flutter/third_party/glfw and update all targets to point to the new location. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This will be followed by an engine PR that updates the deps pull GLFW to //flutter/third_party/glfw and update all targets to point to the new location. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284

The GLFW BUILD.gn file refers to several headers that don't exist in the repo. Issue: flutter/flutter#136284

The GLFW BUILD.gn file refers to several headers that don't exist in the repo. Issue: flutter/flutter#136284 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

These have been moved to flutter/engine. Issue: flutter/flutter#136284

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.

As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

github-actions · 2023-10-25T17:00:39Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

cbracken added the c: tech-debt Technical debt, code quality, testing, etc. label Oct 10, 2023

cbracken self-assigned this Oct 10, 2023

cbracken added engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list labels Oct 10, 2023

cbracken mentioned this issue Oct 10, 2023

Move //third_party/glfw to //flutter/third_party/glfw flutter/buildroot#777

Merged

8 tasks

cbracken mentioned this issue Oct 10, 2023

Move //third_party/glfw to //flutter/third_party/glfw flutter/engine#46733

Merged

8 tasks

cbracken added a commit to cbracken/buildroot that referenced this issue Oct 10, 2023

Eliminate non-existent headers from GLFW build

f346622

The GLFW BUILD.gn file refers to several headers that don't exist in the repo. Issue: flutter/flutter#136284

cbracken added a commit to cbracken/buildroot that referenced this issue Oct 10, 2023

Eliminate non-existent headers from GLFW build

886cd6e

The GLFW BUILD.gn file refers to several headers that don't exist in the repo. Issue: flutter/flutter#136284

cbracken mentioned this issue Oct 10, 2023

Eliminate non-existent headers from GLFW build flutter/buildroot#778

Merged

8 tasks

matanlurey mentioned this issue Oct 10, 2023

☂️Merge flutter/buildroot into flutter/engine and retire the repository. #67373

Open

cbracken closed this as completed Oct 11, 2023

cbracken mentioned this issue Oct 17, 2023

Move imgui from buildroot to flutter third_party flutter/engine#47031

Merged

8 tasks

cbracken added a commit to cbracken/buildroot that referenced this issue Oct 18, 2023

Delete build_overrides

1bb55bc

These have been moved to flutter/engine. Issue: flutter/flutter#136284

cbracken added a commit to cbracken/buildroot that referenced this issue Oct 18, 2023

Delete build_overrides

4ef2c5b

These have been moved to flutter/engine. Issue: flutter/flutter#136284

github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move //third_party/glfw from buildroot to //flutter/third_party/glfw #136284

Move //third_party/glfw from buildroot to //flutter/third_party/glfw #136284

cbracken commented Oct 10, 2023 •

edited

Loading

github-actions bot commented Oct 25, 2023

Move //third_party/glfw from buildroot to //flutter/third_party/glfw #136284

Move //third_party/glfw from buildroot to //flutter/third_party/glfw #136284

Comments

cbracken commented Oct 10, 2023 • edited Loading

github-actions bot commented Oct 25, 2023

cbracken commented Oct 10, 2023 •

edited

Loading