Move //third_party/glfw to //flutter/third_party/glfw #46733
Conversation
|
The initial commit will fail the licence script; once we get the failures from CI, I'll amend the patch. |
cbracken
force-pushed
the
move-glfw
branch
2 times, most recently
from
ad193e5
to
2bac18d
Compare
cbracken
force-pushed
the
move-glfw
branch
3 times, most recently
from
60e3313
to
e24b80d
Compare
|
Latest build error:
@cbracken see https://raw.githubusercontent.com/flutter/engine/main/ci/licenses_golden/licenses_third_party, but I think we'll need to move these licenses to https://github.com/flutter/engine/blob/main/ci/licenses_golden/licenses_flutter (the names are a bit of a misnomer). |
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284
|
It might not fix everything the license script is sad about, but I would suggest starting out by updating the paths here: https://github.com/flutter/engine/blob/main/tools/licenses/lib/paths.dart#L101 and seeing what the remaining issues are. |
What we want is *likely* to break apart licence checking for third-party deps that are checked into the repo and those that are pulled via DEPS since they have significantly different characteristics: * Checked-in third-party code is unlikely to change much in terms of license-related content * Code from deps is outside of our (direct) control and may change more frequently, and should likely be treated like the src/third_party deps are. We should probably consider an update to the licence script that treats these two separately (e.g. via an allowlist).
…136307) flutter/engine@ea275c3...8086814 2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745) 2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748) 2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.
This is the engine-side follow-up to flutter/buildroot#777, flutter/buildroot#778.
Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether.
Issue: flutter/flutter#136284
No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.