Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "postsubmit_overrides" to build config json spec #136570

Closed
zanderso opened this issue Oct 14, 2023 · 6 comments
Closed

Add "postsubmit_overrides" to build config json spec #136570

zanderso opened this issue Oct 14, 2023 · 6 comments
Assignees
@godofredoc
Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@zanderso
Copy link
Member

The purpose of this feature would be to support configurations that need e.g. different gn flags between pre- and post-submit.

@godofredoc I will wait on making changes to the goma setup for the builds we discussed until we can write these in the build configs.
@zanderso zanderso added the team-infra Owned by Infrastructure team label Oct 14, 2023
@ricardoamador ricardoamador added triaged-infra Triaged by Infrastructure team P2 Important issues not at the top of the work list P3 Issues that are less important to the Flutter project and removed P2 Important issues not at the top of the work list labels Oct 19, 2023
@zanderso
Copy link
Member Author

zanderso commented Oct 21, 2023 •
edited
Loading

The migration to reclient is blocked on this issue, which (AFAIK) must be completed in Q4, so I will bump this up to P1.

@zanderso zanderso added P1 High-priority issues at the top of the work list and removed P3 Issues that are less important to the Flutter project labels Oct 21, 2023
@keyonghan keyonghan mentioned this issue Nov 29, 2023
Closed
4 tasks
@flutter-triage-bot flutter-triage-bot bot added the ⏳ Bot is counting down the days until it unassigns the issue label Feb 25, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @godofredoc but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@zanderso
Copy link
Member Author

This will still be needed to keep presubmit cycle times low. Completing the migration to reclient is still blocked on this.

@flutter-triage-bot flutter-triage-bot bot removed the ⏳ Bot is counting down the days until it unassigns the issue label Feb 25, 2024
godofredoc added a commit to godofredoc/engine that referenced this issue Mar 13, 2024
@godofredoc
Add postsubmit overrides for mac builders.
6696f18 
Mac builds on postsubmit will be built without goma/rbe. This is landing
the configurations required to build without RBE once the migration to
RBE is complete.

Bug: flutter/flutter#136570
@godofredoc godofredoc mentioned this issue Mar 13, 2024
Merged
8 tasks
@godofredoc
Copy link
Contributor

Recipes change: https://flutter-review.googlesource.com/c/recipes/+/57022

godofredoc added a commit to godofredoc/engine that referenced this issue Apr 10, 2024
@godofredoc
Add postsubmit overrides for mac builders.
6401c99 
Mac builds on postsubmit will be built without goma/rbe. This is landing
the configurations required to build without RBE once the migration to
RBE is complete.

Bug: flutter/flutter#136570
auto-submit bot pushed a commit to flutter/engine that referenced this issue Apr 10, 2024
@godofredoc
Add postsubmit overrides for mac builders. (#51385)
3cbc65d 
Mac builds on postsubmit will be built without goma/rbe. This is landing the configurations required to build without RBE once the migration to RBE is complete.

Bug: flutter/flutter#136570

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc
Copy link
Contributor

Closing as completed!!!

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zanderso @ricardoamador @godofredoc