Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] new blur doesn't support decal tile mode on devices without decal sampler address mode #139773

Closed
gaaclarke opened this issue Dec 7, 2023 · 1 comment · Fixed by flutter/engine#48899
Closed

[Impeller] new blur doesn't support decal tile mode on devices without decal sampler address mode #139773

gaaclarke opened this issue Dec 7, 2023 · 1 comment · Fixed by flutter/engine#48899
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@gaaclarke
Copy link
Member

flutter/engine#48805 relies on kDecal to work. That isn't available on all hardware. We need to fall back to GaussianBlurDecalPipeline on those devices.

See also: flutter/engine#48805 (comment)
@gaaclarke gaaclarke added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Dec 7, 2023
@gaaclarke gaaclarke mentioned this issue Dec 7, 2023
Merged
8 tasks
@jonahwilliams jonahwilliams added P2 Important issues not at the top of the work list triaged-engine Triaged by Engine team labels Dec 11, 2023
@gaaclarke gaaclarke mentioned this issue Dec 11, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue Dec 13, 2023
@gaaclarke
[Impeller] Made the new blur work on devices without the decal addres…
9f7004e 
…s mode (#48899)

This also adds a new mechanism of override the device capabilities.

fixes flutter/flutter#139773

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Impeller] Made the new blur work on devices without the decal address mode gaaclarke/engine
2 participants
@jonahwilliams @gaaclarke