Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for run_android_tests.sh #144045

Closed
3 tasks done
matanlurey opened this issue Feb 23, 2024 · 1 comment · Fixed by flutter/engine#50922
Closed
3 tasks done

Remove the need for run_android_tests.sh #144045

matanlurey opened this issue Feb 23, 2024 · 1 comment · Fixed by flutter/engine#50922
Assignees
@matanlurey
Labels
c: tech-debt Technical debt, code quality, testing, etc. e: scenario-app The `testing/scenario_app` fixture in the engine fyi-android For the attention of Android platform team P1 High-priority issues at the top of the work list platform-android Android applications specifically team-engine Owned by Engine team

Comments

@matanlurey
Copy link
Contributor

matanlurey commented Feb 23, 2024 •
edited

Similar to the iOS side of #143953.

Things to move from the shell script to the Dart binary:

  • Use of ndk-stack to symbolize stack traces
  • Default location for logs output
  • Default location for the contents golden text file
@matanlurey matanlurey added platform-android Android applications specifically P1 High-priority issues at the top of the work list c: tech-debt Technical debt, code quality, testing, etc. fyi-android For the attention of Android platform team team-engine Owned by Engine team e: scenario-app The `testing/scenario_app` fixture in the engine labels Feb 23, 2024
@matanlurey matanlurey self-assigned this Feb 23, 2024
@matanlurey matanlurey mentioned this issue Feb 23, 2024
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Feb 23, 2024
@matanlurey
Refactor Android scenario_app to remove shell entrypoint, simplify. (…
b6ffb98 
…#50922)

Closes flutter/flutter#144045.

There is still more work I want to do, like pulling args parsing into it's own class, and potentially cleanup the [golden file collection](flutter/flutter#144047), but those seem reasonable for future (lower priority) PRs.
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
c: tech-debt Technical debt, code quality, testing, etc. e: scenario-app The `testing/scenario_app` fixture in the engine fyi-android For the attention of Android platform team P1 High-priority issues at the top of the work list platform-android Android applications specifically team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Android scenario_app to remove shell entrypoint, simplify. matanlurey/engine
1 participant
@matanlurey