Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting engine scenario run scripts to python or dart #143953

Open
vashworth opened this issue Feb 22, 2024 · 1 comment
Open

Converting engine scenario run scripts to python or dart #143953

vashworth opened this issue Feb 22, 2024 · 1 comment
Assignees
@matanlurey
Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter e: scenario-app The `testing/scenario_app` fixture in the engine engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@vashworth
Copy link
Contributor

Use case

Currently, engine scenario tests are run through a bash script. I had to add some logic to fix a bug.

@zanderso commented:

My sense is that the logic in this script is outgrowing what we'd normally like to maintain in a bash script. We should consider porting this to Python, or ideally Dart if possible.
flutter/engine#50835 (review)

Proposal

Instead of using a bash script to run the tests, use a python or dart script.
@vashworth vashworth mentioned this issue Feb 22, 2024
Merged
8 tasks
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. c: proposal A detailed proposal for a change to Flutter team-engine Owned by Engine team and removed in triage Presently being triaged by the triage team labels Feb 23, 2024
@matanlurey
Copy link
Contributor

I am planning to do something similar for the Android scenario_app, happy to chat.

@matanlurey matanlurey added platform-ios iOS applications specifically e: scenario-app The `testing/scenario_app` fixture in the engine labels Feb 23, 2024
@matanlurey matanlurey mentioned this issue Feb 23, 2024
Closed
3 tasks
@jonahwilliams jonahwilliams added the P2 Important issues not at the top of the work list label Feb 26, 2024
@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label Mar 4, 2024
@vashworth vashworth mentioned this issue Mar 18, 2024
Open
2 tasks
@jmagman jmagman mentioned this issue Apr 19, 2024
Open
@matanlurey matanlurey self-assigned this Jun 26, 2024
@matanlurey matanlurey mentioned this issue Jun 28, 2024
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jul 3, 2024
@matanlurey
Convert run_ios_tests.sh to run_ios_tests.dart. (#53645)
84769c8 
Part of flutter/flutter#143953.

Because there are so many boundary cases, i.e. tests failed uploading artifacts to LUCI, I  was _not_ planning on atomically deleting and replacing `run_ios_tests.sh`, and want to give a chance for the iOS team to try the converted code and verify it works the way they expect.

I'm also happy to just slam it on, but defer to y'all. _It works on my machine_.

---

```sh
dart run testing/scenario_app/bin/run_ios_tests.dart
```
@matanlurey matanlurey mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter e: scenario-app The `testing/scenario_app` fixture in the engine engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matanlurey @jonahwilliams @vashworth @danagbemava-nc