Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] unexpected change in average_frame_rasterizer_time_millis #144406

Closed
gaaclarke opened this issue Feb 29, 2024 · 3 comments · Fixed by #144410
Closed

[Impeller] unexpected change in average_frame_rasterizer_time_millis #144406

gaaclarke opened this issue Feb 29, 2024 · 3 comments · Fixed by #144410
Assignees
@jonahwilliams
Labels
e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team

Comments

@gaaclarke
Copy link
Member

gaaclarke commented Feb 29, 2024 •
edited
Loading

flutter/engine#51071 has changed the average_frame_rasterizer_time_millis. I think that is unexpected. We shouldn't be changing out opengles benchmarks.

cc @jonahwilliams
@gaaclarke gaaclarke added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Feb 29, 2024
@gaaclarke
Copy link
Member Author

also there is a change here skia perf

@jonahwilliams
Copy link
Member

The fallback broke these tests since they're not manually opted into GLES. I'm going to be fixing them today.

@jonahwilliams jonahwilliams self-assigned this Feb 29, 2024
@jonahwilliams jonahwilliams mentioned this issue Feb 29, 2024
Merged
auto-submit bot pushed a commit that referenced this issue Feb 29, 2024
@jonahwilliams
[devicelab] fix motog4 tests and update comment. (#144410)
ec8fcbc 
Fixes #144406

The A02 have also been running Vulkan for quite a while.
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonahwilliams jonahwilliams

Labels
e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[devicelab] fix motog4 tests and update comment. jonahwilliams/flutter
2 participants
@jonahwilliams @gaaclarke