Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tool minimum version to Xcode 15 #144582

Open
jmagman opened this issue Mar 5, 2024 · 6 comments
Open

Update tool minimum version to Xcode 15 #144582

jmagman opened this issue Mar 5, 2024 · 6 comments
Labels
P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team

Comments

@jmagman
Copy link
Member

jmagman commented Mar 5, 2024 •
edited by loic-sharma

Flutter's Swift Package Manager feature requires Xcode 15. CocoaPods will be used on older versions of Xcode.

We should update the Flutter tool's Xcode requirement to ensure Swift Package Manager is usable.

Previous bump at #93094
@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Mar 5, 2024
@jmagman jmagman mentioned this issue Mar 5, 2024
Open
53 tasks
@christopherfujino
Copy link
Member

Are there time constraints here? That is, could we do it today, or should we wait until it's been out N months or there have been M newer releases?

@stuartmorgan
Copy link
Contributor

should we wait until it's been out N months or there have been M newer releases?

There's no real value in waiting longer than April 29th, which is the point at which the app store will require Xcode 15 builds. At that point, nobody actually shipping apps can stay on Xcode 14 anyway.

@christopherfujino
Copy link
Member

should we wait until it's been out N months or there have been M newer releases?

There's no real value in waiting longer than April 29th, which is the point at which the app store will require Xcode 15 builds. At that point, nobody actually shipping apps can stay on Xcode 14 anyway.

Cool, thanks.

@jmagman
Copy link
Member Author

jmagman commented Apr 5, 2024

@vashworth #146256 needs Xcode 15.0, right?

@vashworth
Copy link
Contributor

@vashworth #146256 needs Xcode 15.0, right?

It's not a blocker (I wrote in checks that disable Swift Package Manager if not Xcode 15+), but yes it does need Xcode 15.0 to use the Swift Package Manager integration

@jmagman jmagman mentioned this issue Apr 5, 2024
Merged
9 tasks
@jmagman
Copy link
Member Author

jmagman commented Apr 5, 2024

I bumped the "recommended" version to 15 in #146367, which emits a doctor warning but doesn't stop from building on lower versions. Let's cp that for the next stable so people can start upgrading now.

auto-submit bot pushed a commit that referenced this issue Apr 8, 2024
@jmagman
Increase the recommended Xcode version to Xcode 15 (#146367)
a5fea8c 
Xcode 15 will be required for iOS App Store submission 
> Please note that as of April 2024 all iOS and iPadOS apps submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 17 SDK.

https://developer.apple.com/ios/submit/

And will also be required for Swift Package Manager support #146256.

We could swap to "required" but macOS developers don't technically need to upgrade.  We can let the Store itself enforce its policies.  And we can swap to Xcode 15 "required" when SPM adoption is further along.

Part of #144582
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this issue Apr 8, 2024
@jmagman
Increase the recommended Xcode version to Xcode 15 (flutter#146367)
f2ec559 
Xcode 15 will be required for iOS App Store submission 
> Please note that as of April 2024 all iOS and iPadOS apps submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 17 SDK.

https://developer.apple.com/ios/submit/

And will also be required for Swift Package Manager support flutter#146256.

We could swap to "required" but macOS developers don't technically need to upgrade.  We can let the Store itself enforce its policies.  And we can swap to Xcode 15 "required" when SPM adoption is further along.

Part of flutter#144582
This was referenced Apr 8, 2024
Closed
Merged
auto-submit bot pushed a commit that referenced this issue Apr 8, 2024
@flutteractionsbot
[CP-beta] Increase the recommended Xcode version to Xcode 15 (#146440)
bc38ac0 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

Part of #144582 (comment)

### Changelog Description:
Increase the `flutter doctor` recommended Xcode version to Xcode 15.

### Impact Description:

Update the `flutter doctor` validator to suggest Xcode 15 if installed version is lower.

This is to encourage upgrades, as Apple will soon be enforcing this during iOS App Store submissions.
> Please note that as of April 2024 all iOS and iPadOS apps submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 17 SDK.

https://developer.apple.com/ios/submit/

It's also to encourage updates before Swift Package Manager requires this version in #146256.

### Workaround:
N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
Install and `xcode-select` Xcode 14.x or lower.  Run `flutter doctor`.  See 
```
[!] Xcode - develop for iOS and macOS (Xcode 15.3)
    � Flutter requires Xcode 14 or higher.
      Download the latest version or update via the Mac App Store.
```
gilnobrega pushed a commit to gilnobrega/flutter that referenced this issue Apr 22, 2024
@jmagman @gilnobrega
Increase the recommended Xcode version to Xcode 15 (flutter#146367)
443b982 
Xcode 15 will be required for iOS App Store submission 
> Please note that as of April 2024 all iOS and iPadOS apps submitted to the App Store must be built with a minimum of Xcode 15 and the iOS 17 SDK.

https://developer.apple.com/ios/submit/

And will also be required for Swift Package Manager support flutter#146256.

We could swap to "required" but macOS developers don't technically need to upgrade.  We can let the Store itself enforce its policies.  And we can swap to Xcode 15 "required" when SPM adoption is further along.

Part of flutter#144582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels. triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stuartmorgan @jmagman @christopherfujino @vashworth