Migrate src/third_party/angle to src/flutter/third_party/angle #144786
Assignees
Labels
c: tech-debt
Technical debt, code quality, testing, etc.
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
Comments
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Mar 7, 2024
This moves Flutter out of the buildroot's third_party directory and into //flutter/third_party and updates all BUILD and gni files. Issue: flutter/flutter#144786 Part of: flutter/flutter#67373
10 tasks
cbracken
added a commit
to flutter/engine
that referenced
this issue
Mar 8, 2024
This moves Flutter out of the buildroot's third_party directory and into //flutter/third_party and updates all BUILD and gni files. Issue: flutter/flutter#144786 Part of: flutter/flutter#67373 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] The odds of this passing on its first CI run is 0%, because there's no way the licence script isn't going to have a fit over it, at which point I promise on my honour that I will dutifully fix all the things it complains about and re-run, probably more than once. - [X] This PR fulfils the minimum [Canadian Content](https://www.youtube.com/watch?v=h9NMnPm5kXc&list=PLJ7QPuvv91JuoPWrLhqX0zDFUoLdynMEk&index=3) regulations mandated by the CRTC. - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
|
Completed in flutter/engine#51270. |
cbracken
added
engine
|
The autoroller config will need to be updated as well. |
|
Looks like this was fixed by @erock2112 in https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/824416. Thanks Eric, and apologies for missing this step! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
build_overrides/angle.gniandbuild_overrides/build.gniare the only two remaining references to Abseil in the buildroot (see: #144201) and the latter only in a comment.Part of #67373.
The text was updated successfully, but these errors were encountered: