Migrate src/third_party/abseil-cpp to src/flutter/third_party.
#144201
Assignees
Labels
c: tech-debt
Technical debt, code quality, testing, etc.
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
matanlurey
added
engine
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Feb 28, 2024
Our abseil dependency is a clone of Chromium's, located at: https://chromium.googlesource.com/chromium/src/third_party/ which is a downstream copy of the source of truth, located at: https://github.com/abseil/abseil-cpp This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706, then reapplies jsimmons@google.com's commits, in chronological order: * 9ec8f453a42aad2f11a1760fe4ce6014a124edc2 * f92f9effc89af7692436c3b9fbb3a67f2239d893 * 61833f2c057a2b1993d871e8c51156aed1dd4354 Preparation for: flutter/flutter#144201 Part of: flutter/flutter#67373
9 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Feb 28, 2024
Our abseil dependency is a clone of Chromium's, located at: https://chromium.googlesource.com/chromium/src/third_party/ which is a downstream copy of the source of truth, located at: https://github.com/abseil/abseil-cpp This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706, then reapplies jsimmons@google.com's commits, in chronological order: * 9ec8f453a42aad2f11a1760fe4ce6014a124edc2 * f92f9effc89af7692436c3b9fbb3a67f2239d893 * 61833f2c057a2b1993d871e8c51156aed1dd4354 Preparation for: flutter/flutter#144201 Part of: flutter/flutter#67373
cbracken
added a commit
to flutter/engine
that referenced
this issue
Feb 28, 2024
Our abseil dependency is a clone of Chromium's, located at: https://chromium.googlesource.com/chromium/src/third_party/ which is a downstream copy of the source of truth, located at: https://github.com/abseil/abseil-cpp This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706, then reapplies jsimmons@google.com's commits, in chronological order: * 9ec8f453a42aad2f11a1760fe4ce6014a124edc2 * f92f9effc89af7692436c3b9fbb3a67f2239d893 * 61833f2c057a2b1993d871e8c51156aed1dd4354 Preparation for: flutter/flutter#144201 Part of: flutter/flutter#67373 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] This patch complies with USDA policy on the use of bovine growth hormone. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
|
Landed:
|
cbracken
added a commit
to cbracken/buildroot
that referenced
this issue
Mar 6, 2024
In combination with https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848, this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373
9 tasks
cbracken
added a commit
to flutter/buildroot
that referenced
this issue
Mar 6, 2024
In combination with https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848, this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Will be followed by a DEPS roll in flutter/engine and patches to our own BUILD.gn files and #includes. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] A purchase does not increase your chances of winning. Void in Quebec. Void where prohibited or restricted by law. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Mar 7, 2024
In combination with: * https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848 * flutter/buildroot#831 this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373
9 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Mar 7, 2024
In combination with: * https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848 * flutter/buildroot#831 this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
Done! |
This was referenced Mar 7, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Part of #67373.
If you think this will take longer than our check-in on March 11th, just LMK!
The text was updated successfully, but these errors were encountered: