Gallery App is built and tested for iOS and Android

[sethladd]

• On dashboard
• Android phone
• iOS phone (Make Flutter Gallery integration tests work on iPhone #4359)

Testing and verification can include:

• Testing app on Nexus 5
• Testing app on iPhone 6
• Performance
  • Startup
  • Animations (TODO, don't have the infra for this quite yet)
  • Scrolling (grid, table, lists, calendar)
• Correctness
  • smoke test for automated bots
  • Manual testing plan

[eseidelGoogle]

At time of writing, none of Flutter's framework supports anything other than phones in portrait orientation. Various widgets/layouts will need updating for tablet. @Hixie @krisgiesing

[eseidelGoogle]

We build for both iOS and Android on the bots, we briefly ran flutter drive in the iOS simulator, but we definitely have more we could do here.

FYI @chinmaygarde @yjbanov

[yjbanov]

We now run the benchmarks for the gallery app regularly. The startup benchmark is already on the dashboard. @HansMuller wrote a benchmark for screen transitions. I'm adding it to the dashboard now.

Can we reduce the scope of the issue to Android phones only for now? Otherwise, to fix it one would find themselves shaving a herd of yaks in no time. Instead, I propose that as we expand our test device matrix to iOS and then tablets we just take all existing tests and benchmarks with us.

With a reduced scope I'd be willing to take this issue.

[eseidelGoogle]

Sold. Lets dump the tablet bits for now.

[yjbanov]

We now have the screen transition tests running and on the dashboard. The remaining parts are to make this all run on iOS. This is currently blocked by a number of other issues, so I'll put this on hold until we're unblocked.

Blockers:

• flutter install fails for iOS #3947 - closed

[sethladd]

Thanks for the links to the blockers! I've updated their milestones to indicate they are part of the Gallery milestone.

[chinmaygarde]

I believe this is resolved once #4575 lands.

[yjbanov]

@chinmaygarde not quite. I still need to get the tests running on the dashboard box. But #4575 gets us very close.

[sethladd]

Any updates on testing on real iOS hardware?

[yjbanov]

We now build and test on both Android and iOS. I even had iOS briefly passing until we regressed again. Not sure if we should mark it as fixed and open a separate issue to fix the iOS build, or wait until our iOS tests are green and mark this issue as fixed.

[sethladd]

Don't think we should close this yet. We aren't able to verify gallery builds via our tests on iOS hardware yet, which is the intent of this issue.

[yjbanov]

Closing this. Android is all done, and we are running some of iOS. I created multiple bite-sized issues in the Critical Metrics project to have iOS catch up:

#7074 - gallery perf/smoke test
#7075 - gallery start-up test
#7076 - scroll test

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.