Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop bug causes crash in release mode. #23879

Closed
luigi-rosso opened this issue Nov 2, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@luigi-rosso
Copy link

commented Nov 2, 2018

Steps to Reproduce

I think I've stumbled across an AOT compiler bug. I'm seeing this in beta, dev, and master channels.

BlockReader nodeBlock;
int componentIndex = 1;
print("START LOOP $componentIndex");
while((nodeBlock=block.readNextBlock(BlockTypesMap)) != null)
{
	print("READ BLOCK ${nodeBlock.blockType} $componentIndex");
	// ...
	componentIndex++;
}

The log in debug:

flutter: START LOOP 1
flutter: READ BLOCK 100 1

The log in profile/release:

flutter: START LOOP 1
flutter: READ BLOCK 100 2

This causes a RangeError exception to be thrown as the index is always ahead by one in release mode. We can mitigate this by changing our loop logic, but I think this reproducible case may help fix an AOT logic error.

You can try this in any of the Nima examples in our repository. You can grab the v1.0.0 release here (note that we are mitigating it in later versions, so please use v1.0.0 if you are trying to repro this issue).
https://github.com/2d-inc/Nima-Flutter/releases/tag/v1.0.0

Once you've extracted that:

cd example/hop
flutter run --release

Code in the repository where the error manifests:
https://github.com/2d-inc/Nima-Flutter/blob/517e00128880d0fcf1d648850fdc6ed6021ed5aa/lib/nima/actor.dart#L487

The doctor says,

[✓] Flutter (Channel master, v0.10.3-pre.81, on Mac OS X 10.14.1 18B73a, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.0)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Ultimate Edition (version 2018.2.3)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] VS Code (version 1.20.1)
[✓] Connected device (1 available)
@jason-simmons

This comment has been minimized.

Copy link
Contributor

commented Nov 3, 2018

This only appears to affect ARM64 AOT targets.

Looks like it started with this Dart roll: flutter/engine@5903a08

@a-siva

@a-siva

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

/cc @aartbik

@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

Reproducible:

Installing build/app/outputs/apk/app.apk...                  2.2s

To quit, press "q".
E/flutter ( 4512): [ERROR:flutter/shell/common/shell.cc(182)] Dart Error: Unhandled exception:
E/flutter ( 4512): RangeError (length): Invalid value: Not in range 0..56, inclusive: 57
E/flutter ( 4512): #0      Actor.readComponentsBlock (package:nima/nima/actor.dart:0)
E/flutter ( 4512): #1      Actor.load (package:nima/nima/actor.dart:464)
E/flutter ( 4512): #2      FlutterActor.loadFromBundle (package:nima/nima.dart:195)

@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

Note, to reproduce this with local engine, explicitly specifying arm64 is essential (builds host_release_arm64 and android_release_arm64 and using "--target-platform=android-arm64" in the flutter run). With this the phi handling CL seems the culprit. Investigating....

@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

With bisection search on the optimization, we find that the 3284th occurrence of the phi handling breaks, not surprisingly in the method:
package:nima/nima/actor.dart_Actor_readComponentsBlock

Around a phi:

B64[join]:560 pred(B1, B62) {
     v23 <- phi(v7, v645) alive [1, 4611686018427387903] T{_Smi}
     ....

The transformation looks correct in itself, so perhaps it triggers something downstream.

For now we are going to revert the culprit CL and reland it when we get to the bottom of this.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 7, 2018

Revert "[vm/compiler] Fine tune operator and phi handling."
This reverts commit 4d5b5bb.

Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see flutter/flutter#23879)

Original change's description:
> [vm/compiler] Fine tune operator and phi handling.
> 
> Rationale:
> Running an extra call specialization pass a bit later
> in the compiler passes stream (after types are propagated)
> recognizes more operators, which execute more efficiently.
> In addition, unboxing phis seems useful on all archs, not
> just 32-bit. These minor tweeks combined improve the prime
> number benchmark 3 fold.
> 
> flutter/flutter#19677
> 
> Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> Reviewed-on: https://dart-review.googlesource.com/69240
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Aart Bik <ajcbik@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
Reviewed-on: https://dart-review.googlesource.com/c/83229
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 7, 2018

Revert "[vm/compiler] Fine tune operator and phi handling."
This reverts commit 4d5b5bb.

Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see flutter/flutter#23879)

Original change's description:
> [vm/compiler] Fine tune operator and phi handling.
> 
> Rationale:
> Running an extra call specialization pass a bit later
> in the compiler passes stream (after types are propagated)
> recognizes more operators, which execute more efficiently.
> In addition, unboxing phis seems useful on all archs, not
> just 32-bit. These minor tweeks combined improve the prime
> number benchmark 3 fold.
> 
> flutter/flutter#19677
> 
> Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> Reviewed-on: https://dart-review.googlesource.com/69240
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Aart Bik <ajcbik@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
Reviewed-on: https://dart-review.googlesource.com/c/83229
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

Note that the revert introduced the following failure (windows only, but arm64 sim):

Unhandled exception:
Expect.equals(expected: <-30064771072>, actual: <0>) fails.
#0 Expect._fail (package:expect/expect.dart:651)
#1 Expect.equals (package:expect/expect.dart:124)
#2 doVars (file:///C:/b/s/w/ir/tests/language_2/vm/mult_int_test.dart:83)
#3 main (file:///C:/b/s/w/ir/tests/language_2/vm/mult_int_test.dart:97)
#4 _startIsolate. (dart:isolate/runtime/libisolate_patch.dart:289)
#5 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171)

--- Re-run this test:
python tools/test.py -m release -a simarm64 -n dartkp-win-release-simarm64 language_2/vm/mult_int_test

@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

Spilling occurs for the induction variable and the parallel move resolver does not honor the boxed/unboxed property for the initial constant. Even though v23 is unboxed, the initial value stored is assumed to be tagged, causing it to be shifted by 1. Once the induction variable which is restored from stack during the while-loop, it remains seemingly off-by-one after that.

  ;; v691 <- UnboxedConstant(#1) [1, 1]
  ;; ParallelMove S-4 <- C, r14 <- C, r13 <- C, r12 <- C, r11 <- C, r10 <- C, r9 <- C, r8 <- C, r7 <- C, r6 <- C, r5 <- C, r3 <- C, r2 <- C, r1 <- C goto:566 B64
0x7f69203ac148    d2800041               movz r1, 0x2 
0x7f69203ac14c    f81e03a1               strx r1, [fp, #-32]

a-siva added a commit to a-siva/engine that referenced this issue Nov 7, 2018

Roll Dart version to 9c07fb64c48adb3d6fde50bab6b8b641c5b67683
This hash corresponds to 2.10-dev.9.2

Changes in this roll include:
- Fix for flutter/flutter#23879 (Revert
"[vm/compiler] Fine tune operator and phi handling.)
- Fix for Dart issue dart-lang/sdk#35009
- Recover from default values in function types
- [vm, reload] On the path for no shape changes, defer freeing the old
- [vm] Fix misc printf format bugs.
- [VM] Added cleanup for Dart IO API
@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

Fix:

  ;; v661 <- UnboxedConstant(#1) [1, 1]
  ;; ParallelMove S-4 <- C, r14 <- C, r13 <- C, r12 <- C, r11 <- C, r10 <- C, r9 <- C, r8 <- C, r7 <- C, r6 <- C, r5 <- C, r3 <- C, r2 <- C, r1 <- C goto:556 B64
0x7f835c0ec148    d2800021               movz r1, 0x1 
0x7f835c0ec14c    f81e03a1               strx r1, [fp, #-32]

a-siva added a commit to flutter/engine that referenced this issue Nov 8, 2018

Roll Dart version to 9c07fb64c48adb3d6fde50bab6b8b641c5b67683 (#6788)
This hash corresponds to 2.10-dev.9.2

Changes in this roll include:
- Fix for flutter/flutter#23879 (Revert
"[vm/compiler] Fine tune operator and phi handling.)
- Fix for Dart issue dart-lang/sdk#35009
- Recover from default values in function types
- [vm, reload] On the path for no shape changes, defer freeing the old
- [vm] Fix misc printf format bugs.
- [VM] Added cleanup for Dart IO API

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 8, 2018

[vm/compiler] Fix bug in unboxed constant spilling
Rationale:
Subtle but disastrous, spilling unboxed integers
in arm64 and x64 would store the value as smi,
detected as a nasty off by one error in flutter code.

flutter/flutter#23879
#35091

Change-Id: I07d71727de8574ebd7d3ec3610d517d7903972f0
Reviewed-on: https://dart-review.googlesource.com/c/83565
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 8, 2018

Reland "[vm/compiler] Fine tune operator and phi handling."
This reverts commit cde4793.

Reason for revert: the real underlying bug has been fixed

Original change's description:
> Revert "[vm/compiler] Fine tune operator and phi handling."
> 
> This reverts commit 4d5b5bb.
> 
> Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see flutter/flutter#23879)
> 
> Original change's description:
> > [vm/compiler] Fine tune operator and phi handling.
> > 
> > Rationale:
> > Running an extra call specialization pass a bit later
> > in the compiler passes stream (after types are propagated)
> > recognizes more operators, which execute more efficiently.
> > In addition, unboxing phis seems useful on all archs, not
> > just 32-bit. These minor tweeks combined improve the prime
> > number benchmark 3 fold.
> > 
> > flutter/flutter#19677
> > 
> > Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> > Reviewed-on: https://dart-review.googlesource.com/69240
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> > Commit-Queue: Aart Bik <ajcbik@google.com>
> 
> TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
> Reviewed-on: https://dart-review.googlesource.com/c/83229
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7f9d892a6225c42810e7be52b6845bfee9cc017d
Reviewed-on: https://dart-review.googlesource.com/c/83800
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 8, 2018

[vm/compiler] Fix bug in unboxed constant spilling
Rationale:
Subtle but disastrous, spilling unboxed integers
in arm64 and x64 would store the value as smi,
detected as a nasty off by one error in flutter code.

flutter/flutter#23879
#35091

Change-Id: I07d71727de8574ebd7d3ec3610d517d7903972f0
Reviewed-on: https://dart-review.googlesource.com/c/83565
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Nov 8, 2018

Reland "[vm/compiler] Fine tune operator and phi handling."
This reverts commit cde4793.

Reason for revert: the real underlying bug has been fixed

Original change's description:
> Revert "[vm/compiler] Fine tune operator and phi handling."
> 
> This reverts commit 4d5b5bb.
> 
> Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see flutter/flutter#23879)
> 
> Original change's description:
> > [vm/compiler] Fine tune operator and phi handling.
> > 
> > Rationale:
> > Running an extra call specialization pass a bit later
> > in the compiler passes stream (after types are propagated)
> > recognizes more operators, which execute more efficiently.
> > In addition, unboxing phis seems useful on all archs, not
> > just 32-bit. These minor tweeks combined improve the prime
> > number benchmark 3 fold.
> > 
> > flutter/flutter#19677
> > 
> > Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> > Reviewed-on: https://dart-review.googlesource.com/69240
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> > Commit-Queue: Aart Bik <ajcbik@google.com>
> 
> TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
> Reviewed-on: https://dart-review.googlesource.com/c/83229
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7f9d892a6225c42810e7be52b6845bfee9cc017d
Reviewed-on: https://dart-review.googlesource.com/c/83800
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

a-siva added a commit to a-siva/engine that referenced this issue Nov 9, 2018

Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc
This roll includes the following fixes:
- Fix obfuscation (issue
flutter/flutter#22322)
- Fix for issue 34839 Service isolate hangs during shutdown if
- Fix bug in unboxed constant spilling
(flutter/flutter#23879)
- Reland Fine tune operator and phi handling which was reverted due to
the above bug.
@aartbik

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

\O/

@aartbik aartbik closed this Nov 9, 2018

a-siva added a commit to flutter/engine that referenced this issue Nov 9, 2018

Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc (#6812)
* Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc

This roll includes the following fixes:
- Fix obfuscation (issue
flutter/flutter#22322)
- Fix for issue 34839 Service isolate hangs during shutdown if
- Fix bug in unboxed constant spilling
(flutter/flutter#23879)
- Reland Fine tune operator and phi handling which was reverted due to
the above bug.

matthew-carroll added a commit to flutter/engine that referenced this issue Dec 5, 2018

Merge latest from master => 21008 staging branch (#7012)
* TextField is only a live region when it has input focus (#6649)

* Roll src/third_party/skia dfca8f6adb6b..a2272ef92640 (4 commits) (#6659)


https://skia.googlesource.com/skia.git/+log/dfca8f6adb6b..a2272ef92640


Created with:
  gclient setdep -r src/third_party/skia@a2272ef92640

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Dart SDK roll for 2018-10-25

bf26f760b1 [infra] Ensure that core dump upload triggers on main builders
cdf6dde807 [gardening] bigint_test may still time out when interpreted (2nd try).
d3498a81be [vm] Cleanup int overflow checking
9e9746a83c [gardening] bigint_test may still time out when interpreted.
7de2510339 [VM interpreter] Do not interpret some Bigint intrinsics (fixes #34901).
816ab3208c Fix versions in spec titles to match the description below
c7c81af74e [vm/bytecode] Check for overflow of bytecode limits
655310ddf2 Add ArgumentError.checkNotNull utility
0170b8d529 Revert "[vm/compiler] Use loop framework for AOT inline heuristics"
9aff930924 Move test_methodCallTypeInference_mixinType into mixin_test.dart
3e750a7e79 [vm] Add test for certain cases of unreachable code
daae20d32e [vm/compiler] Use loop framework for AOT inline heuristics
28a8fa50f6 Upgrade package:http to 0.12.0.
b3055a1482 [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A01_t03 flaky
b8fd29e0bb Remove dartfix dependencies on analysis server
8a5405fc40 [build] Add //third_party/android_tools BUILD file needed by zlib
82c1f2aaa8 [vm] Eliminate dart_zlib_path from BUILD files
11ad25a1c3 Reland "[VM runtime] Support Smi instances in type test cache."
3dc911909b Generate analysis_server_client protocol_generated.dart and related protocol files
a902fc351f [gardening] Mark co19 LibTest/io/Stdin/readByteSync_A02_t01 flaky
cfecec5eec Fix yet another cloning bug
d8cb60d746 [infra] Improve clone command in analyze-flutter.sh script (#34739)
34d0801008 Generate analysis server protocol consts in analysis_server_client
2c83eb550e [vm] Integrate dart binary with Crashpad on Windows.
b9999b6c27 [gardening] Mark co19 LibTest/io/RawDatagramSocket/lastWhere_A01_t02 flaky
0b15595913 [gardening] Mark co19 LibTest/io/Link/rename_A02_t01 flaky
57f895c7a4 Bounds of a generic type alias ensure the body is regular-bounded
6efc58f069 [vm] Pass member name as a symbol in instantiateInvocation.
cf0a99a89b [fasta] Check type arguments in method invocations while doing inference
d693742648 Specify for all literals whether the object overrides `Object.==`.
5c9060283b Change parameter 'silent' => 'instrumented'
e4e82da85d Changed dartLangSpec errors to warnings
4695b5f138 Add "convert to int literal" to dartfix
0009ca7b1b In _matchInterfaceSubtypeOf, account for mixins having null superclass.
1d10e037ef [vm/bytecode] Remove unreachable bytecode
03eafc0b2e Add fromEntries on HashMap and LinkedHashMap
4f2a4e69a8 new convert-to-int-literal assist
58d73e08f4 [vm] Remove incorrect assert in Script::GetSnippet
6134ac8648 Revert "[VM runtime] Support Smi instances in type test cache."
4e49d19bd6 [gardening] Update status for #34901
6ba3e55ecc [VM runtime] Support Smi instances in type test cache.
e4566d3dbd LSP: Fix nulls and missing fromJson calls in unions
d91e0ad3d7 [VM] Make method extractors call a stub for creation of tear-off closure
4c9684f735 [vm] Ignore compilation errors in CorelibCompileAll
b73f7ed3d4 [infra] Add tools/bots/find_base_commit.dart
6443a8036d Remove flaky markers for standalone_2/io tests, MacOS upgrade seemed to have getten rid underlying OS issue
c04215d5f6 [fasta] Add a test case for issue #34899
03765ed6ec Update old mixin tests. Remove the --super-mixins flag from the tests.
a394e4f492 Fix handling of JSON with interfaces nested within Unions
2f90f8d0ef Issue 34896. Verify the superconstraint signature invoked by a mixin, not the mixin's one.
b82c1f979f Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down"
289d2b003a [vm] Don't re-enqueue functions after unoptimized compiles
33accb510b [VM] : Cleanup the file modified and service stream callbacks in        Dart_Cleanup so that the Flutter engine can restart the VM.
89c845eba2 [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down      the service isolate.
e648d63bed Revert "Compute unlinked API signatures without unlinked summaries."
74792f4b9c Revert "[vm] Revert service isolate setup in main.cc"
b4fbf1a065 [vm/bytecode] Wire up bytecode generation in kernel service
914065d80b [vm/compiler] Use loop framework for register allocator
7fd78ed5b6 [infra] Add analyzer branch alias for flutter-analyze builder (#34739)
9406b7b44e [vm/bytecode] Add versioning to bytecode format
a82e025739 Move dartfix to its own package
872e90106e Set to publish new analyzer_plugin.
2d14d9a313 Improve how dartfix finds the analysis server pkg root
a342cecffd Disable support for the old super mixins
cddc2d42e1 Handle generic types in LSP spec parsing
8b6f8969a6 Support post-inference serialization/deserialization
9c3834d41c Remove unused import that shows a warning
a1d61371d3 Exposes VM and Isolate Metrics in the API.
2c6eabd3c4 Compute substitution map on kernel objects instead of builders
704a43558d Move getSubstitutionMap to KernelClassBuilder
af8e29142b Respecify where type promotion happens.
393fe44f8f Resolve types from the class header earlier
1515d4fe34 [Gardening] Mark LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky
11adb81a77 Remove the last references to the analyzer package from kernel.
02651515eb Fix identifyWidgetExpression() for Flutter.
f5cd6ccfb7 More shared fasta/analyzer error codes
cecda9043b Update analyzer docs based on previous feedback
ab6eb9332f [VM] Fix flaky crash when unwinding the mutator stack during GC

* Update contributing.md for xcode_backend refactor notes (#6642)

* Update contributing.md for xcode_backend refactor notes

* Roll src/third_party/skia a2272ef92640..2cf29ce4dbbf (8 commits) (#6661)


https://skia.googlesource.com/skia.git/+log/a2272ef92640..2cf29ce4dbbf


Created with:
  gclient setdep -r src/third_party/skia@2cf29ce4dbbf

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 2cf29ce4dbbf..f5eaee917bb7 (4 commits) (#6664)


https://skia.googlesource.com/skia.git/+log/2cf29ce4dbbf..f5eaee917bb7


Created with:
  gclient setdep -r src/third_party/skia@f5eaee917bb7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia f5eaee917bb7..3f5b4ee4adfd (1 commits) (#6666)


https://skia.googlesource.com/skia.git/+log/f5eaee917bb7..3f5b4ee4adfd


Created with:
  gclient setdep -r src/third_party/skia@3f5b4ee4adfd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 3f5b4ee4adfd..603c5da17491 (1 commits) (#6667)


https://skia.googlesource.com/skia.git/+log/3f5b4ee4adfd..603c5da17491


Created with:
  gclient setdep -r src/third_party/skia@603c5da17491

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 603c5da17491..e2fd74b48f6f (1 commits) (#6668)


https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f


Created with:
  gclient setdep -r src/third_party/skia@e2fd74b48f6f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e2fd74b48f6f..a944142412cd (9 commits) (#6669)


https://skia.googlesource.com/skia.git/+log/e2fd74b48f6f..a944142412cd


Created with:
  gclient setdep -r src/third_party/skia@a944142412cd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Propagate pointer size from Android MotionEvent (#6662)

* Add missing includes (#6670)

* Roll src/third_party/skia a944142412cd..3b79aa3a5ad0 (15 commits) (#6671)


https://skia.googlesource.com/skia.git/+log/a944142412cd..3b79aa3a5ad0


Created with:
  gclient setdep -r src/third_party/skia@3b79aa3a5ad0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* iOS Embedding Refactor (#6447)

* Create FlutterEngine to manage a Shell to support maintaining execution state across instances of FlutterViewControllers
* Refactor PlatformViewIOS to support adding or removing a FlutterViewController dynamically
* Refactor FlutterDartHeadlessCodeRunner to implement FlutterEngine
* Refactor FlutterViewController to accept a FlutterEngine at initialization or to create one for backwards compatibility; any Shell related responsibilities are now passed through to the Engine instance
* Remove FlutterNavigationController (unused)
* Update all public Objective C doc comments to be consistent and formatable
* Add public documentation to all public headers

* Plumb the iOS PlatformViewsController into flow. (#6603)

For flow to manipulate the embedded UIViews during the paint traversal
it needs some hook in PaintContext.
This PR introduces a ViewEmbeder interface that is implemented by the
iOS PlatformViewsController and plumbs it into PaintContext.

The ViewEmbedder interface is mainly a place holder at this point, as
this PR is focused on just the plumbing.

* Attach and position embedded UIVIews (#6614)

* Update FlutterPlugin.h docs, suppress warning for older API (#6672)

* Update FlutterPlugin.h docs, suppress warning for older API

* Undefine ERROR in platform_view_layer.cc (#6675)

On Windows the ERROR macro is defined by some headers which breaks the
FML_LOG(ERROR).

* Roll buildroot to pick up updates to custom toolchains. (#6674)

* Handle Windows headers defining ERROR to 0 in log levels. (#6677)

* Roll buildroot to pick up Mac toolchain updates. (#6678)

* Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (#6679)


https://skia.googlesource.com/skia.git/+log/3b79aa3a5ad0..b53f1f46982d


Created with:
  gclient setdep -r src/third_party/skia@b53f1f46982d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Fix inconsistent include syntax (#6680)

* Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (#6681)


https://skia.googlesource.com/skia.git/+log/b53f1f46982d..38e4fd0c5654


Created with:
  gclient setdep -r src/third_party/skia@38e4fd0c5654

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (#6682)


https://skia.googlesource.com/skia.git/+log/38e4fd0c5654..79c96811863f


Created with:
  gclient setdep -r src/third_party/skia@79c96811863f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (#6683)


https://skia.googlesource.com/skia.git/+log/79c96811863f..797197a772b8


Created with:
  gclient setdep -r src/third_party/skia@797197a772b8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 797197a772b8..1de48d8040aa (2 commits) (#6684)


https://skia.googlesource.com/skia.git/+log/797197a772b8..1de48d8040aa


Created with:
  gclient setdep -r src/third_party/skia@1de48d8040aa

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 1de48d8040aa..68825776f4b4 (1 commits) (#6685)


https://skia.googlesource.com/skia.git/+log/1de48d8040aa..68825776f4b4


Created with:
  gclient setdep -r src/third_party/skia@68825776f4b4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Don't populate the external view embedder in PaintContext. (#6686)

The platform views embedding is still WIP, and until we dynamically
merge the gpu and platform threads based on the presence of an embedded
view in the scene fetching the view embedder is not thread safe.

This PR essentially disables iOS platform views embedding, we will
re-enable once dynamic thread merging is supported.

* Roll src/third_party/skia 68825776f4b4..ab18c8e6cc20 (11 commits) (#6688)


https://skia.googlesource.com/skia.git/+log/68825776f4b4..ab18c8e6cc20


Created with:
  gclient setdep -r src/third_party/skia@ab18c8e6cc20

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll buildroot to 11a934e99eaa4aa8e278cd2772aff4f51f1f3c41 (#6687)

This reverts a change in buildroot that caused regressions (see https://github.com/flutter/flutter/issues/23678).

* Flutter tester default locales (#6689)

* Roll src/third_party/skia ab18c8e6cc20..d48b7a881b24 (5 commits) (#6690)


https://skia.googlesource.com/skia.git/+log/ab18c8e6cc20..d48b7a881b24


Created with:
  gclient setdep -r src/third_party/skia@d48b7a881b24

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Add Locale.fromSubtags and support for scriptCode. (#6518)

* Add Locale.fromComponents.

* Change toString from underscores to dashes. Expand the unit tests.

* Rename 'fromComponents' to 'create'. Change variants from String to List<String>.

* Use default for language parameter. Use hashCode/hashList.

* Have toString() stick with old (underscore) behaviour.

* Demonstrate empty-list bug in assert code.

* Fix empty-list assert bug.

* Add ignores for lint issues. Unsure about 71340 though.

* Fix operator== via _listEquals.

* Remove length-checking asserts: we're anyway not checking characters in fields.

* Documentation update.

* Change reasoning for ignore:prefer_initializing_formals.

* Try 'fromSubtags' as new constructor name.

* Documentation improvements based on Pull Request review.

* Assert-fail for invalid-length subtags and drop bad subtags in production code.

* Revert "Assert-fail for invalid-length subtags and drop bad subtags in production code."

This reverts commit d6f06f5e7b3537d60000c47641580475ef16abbe.

* Re-fix Locale.toString() for variants=[].

* Tear out variants, in case we want to have one fewer pointer in the future.

* Make named parameters' names consistent with member names.

* Also remove _listEquals: no longer in use.

* Lint fix.

* Fix code review nits.

* Lint fix for assert, and a couple more not-zero-length-string asserts.

* Code Review: two of three nits addressed...

* Review fix: change 'should' to 'must' for subtag prescriptions.

* Assert-check that countryCode is never ''.

* Fix popSystemNavigator (#6691)

* Roll back _countryCode assert - breaking change (#6693)

* Roll back _countryCode assert - breaking change

* Add tests back in

* Roll src/third_party/skia d48b7a881b24..ca44d5d85895 (3 commits) (#6694)


https://skia.googlesource.com/skia.git/+log/d48b7a881b24..ca44d5d85895


Created with:
  gclient setdep -r src/third_party/skia@ca44d5d85895

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia ca44d5d85895..14768f64fba3 (1 commits) (#6695)


https://skia.googlesource.com/skia.git/+log/ca44d5d85895..14768f64fba3


Created with:
  gclient setdep -r src/third_party/skia@14768f64fba3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 14768f64fba3..dde307f14273 (3 commits) (#6697)


https://skia.googlesource.com/skia.git/+log/14768f64fba3..dde307f14273


Created with:
  gclient setdep -r src/third_party/skia@dde307f14273

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia dde307f14273..5785405afa1b (1 commits) (#6698)


https://skia.googlesource.com/skia.git/+log/dde307f14273..5785405afa1b


Created with:
  gclient setdep -r src/third_party/skia@5785405afa1b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 5785405afa1b..52a715455181 (5 commits) (#6699)


https://skia.googlesource.com/skia.git/+log/5785405afa1b..52a715455181


Created with:
  gclient setdep -r src/third_party/skia@52a715455181

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 52a715455181..78252fedaab9 (6 commits) (#6700)


https://skia.googlesource.com/skia.git/+log/52a715455181..78252fedaab9


Created with:
  gclient setdep -r src/third_party/skia@78252fedaab9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 78252fedaab9..4c169456061d (12 commits) (#6701)


https://skia.googlesource.com/skia.git/+log/78252fedaab9..4c169456061d


Created with:
  gclient setdep -r src/third_party/skia@4c169456061d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Ensure Simulator publishes mDNS records (#6696)

* Ensure Simulator publishes mDNS records on loopback interface.

* Roll src/third_party/skia 4c169456061d..1801b94e85b4 (2 commits) (#6703)


https://skia.googlesource.com/skia.git/+log/4c169456061d..1801b94e85b4


Created with:
  gclient setdep -r src/third_party/skia@1801b94e85b4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

*  Delay embedded UIViews touch events until the framework says so. (#6665)

This allows the framework to decide whether and when a touch event
sequence arrives to the embedded view. Which gives the framework the
ability to manage hit testing and gesture disambiguation for embedded
UIViews.

We achieve this by wrapping each embedded UIView with another UIView that has
a custom UIGestureRecognizer that delays touch events from being
delivered, and another UIGestureRecognizer that makes sure to let
Flutter know of events that are hit tested to the embedded view.

* Roll src/third_party/skia 1801b94e85b4..69a72945dcdd (1 commits) (#6704)


https://skia.googlesource.com/skia.git/+log/1801b94e85b4..69a72945dcdd


Created with:
  gclient setdep -r src/third_party/skia@69a72945dcdd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 69a72945dcdd..4d8f48db9ef5 (1 commits) (#6705)


https://skia.googlesource.com/skia.git/+log/69a72945dcdd..4d8f48db9ef5


Created with:
  gclient setdep -r src/third_party/skia@4d8f48db9ef5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 4d8f48db9ef5..83d923f38664 (2 commits) (#6706)


https://skia.googlesource.com/skia.git/+log/4d8f48db9ef5..83d923f38664


Created with:
  gclient setdep -r src/third_party/skia@83d923f38664

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 83d923f38664..9985a27c06ad (2 commits) (#6707)


https://skia.googlesource.com/skia.git/+log/83d923f38664..9985a27c06ad


Created with:
  gclient setdep -r src/third_party/skia@9985a27c06ad

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Check needs_painting in RasterCache::Prepare (#6708)

Otherwise, this may trigger `FML_DCHECK(needs_painting())`. We haven't
caused crashes for our users because it probably requires a locally
debug engine build to trigger the assert.

* Roll src/third_party/skia 9985a27c06ad..348a03729796 (15 commits) (#6710)


https://skia.googlesource.com/skia.git/+log/9985a27c06ad..348a03729796


Created with:
  gclient setdep -r src/third_party/skia@348a03729796

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Move FlutterPlatformViewsController into FlutterEngine. (#6709)

This PR breaks PlatformViewsController's construction dependency on FlutterView,
which allows making FlutterEngine its owner instead of
FlutterViewController.

Also renamed the FlutterScreenshotDelegate to FlutterViewEngineDelegate
which is FlutterView's delegate to the engine, and expanded it to
provide a view embedder.

* Apply changes to the embedded UIView tree when presenting a frame (#6712)

Also tracks the order of embedded views from frame to frame, and only
removes and reattaches subviews if there is a structural change to the
UIView hierarchy.

* Roll src/third_party/skia 348a03729796..d7a7586b0d2f (12 commits) (#6714)


https://skia.googlesource.com/skia.git/+log/348a03729796..d7a7586b0d2f


Created with:
  gclient setdep -r src/third_party/skia@d7a7586b0d2f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Decode UIView's creation parameters and pass them to the view factory. (#6715)

* Roll src/third_party/skia d7a7586b0d2f..628f0a57d102 (1 commits) (#6718)


https://skia.googlesource.com/skia.git/+log/d7a7586b0d2f..628f0a57d102


Created with:
  gclient setdep -r src/third_party/skia@628f0a57d102

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 628f0a57d102..1ae419b62b2b (2 commits) (#6720)


https://skia.googlesource.com/skia.git/+log/628f0a57d102..1ae419b62b2b


Created with:
  gclient setdep -r src/third_party/skia@1ae419b62b2b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 1ae419b62b2b..e008d6feb2d0 (1 commits) (#6721)


https://skia.googlesource.com/skia.git/+log/1ae419b62b2b..e008d6feb2d0


Created with:
  gclient setdep -r src/third_party/skia@e008d6feb2d0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e008d6feb2d0..763fc966993d (1 commits) (#6722)


https://skia.googlesource.com/skia.git/+log/e008d6feb2d0..763fc966993d


Created with:
  gclient setdep -r src/third_party/skia@763fc966993d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 763fc966993d..3bdaa46bff71 (2 commits) (#6723)


https://skia.googlesource.com/skia.git/+log/763fc966993d..3bdaa46bff71


Created with:
  gclient setdep -r src/third_party/skia@3bdaa46bff71

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 3bdaa46bff71..f1eda00bf6b0 (11 commits) (#6724)


https://skia.googlesource.com/skia.git/+log/3bdaa46bff71..f1eda00bf6b0


Created with:
  gclient setdep -r src/third_party/skia@f1eda00bf6b0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Report asset names in loading trace events. (#6713)

* Roll src/third_party/skia f1eda00bf6b0..e978ca297965 (10 commits) (#6725)


https://skia.googlesource.com/skia.git/+log/f1eda00bf6b0..e978ca297965


Created with:
  gclient setdep -r src/third_party/skia@e978ca297965

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Fixed typo (#6717)

In comments, replaced `...using using...` with just `...using...`

* Roll src/third_party/skia e978ca297965..94d7af7bcc96 (5 commits) (#6727)


https://skia.googlesource.com/skia.git/+log/e978ca297965..94d7af7bcc96


Created with:
  gclient setdep -r src/third_party/skia@94d7af7bcc96

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Add an overlay surface on top of embedded UIViews. (#6726)

The overlay surfaces are going to be the same IOSSurface implementation
with the platform views controller set to null (so these are surfaces
that don't support embedding platform views to them).

  * Adds a FlutterOverlayView which is a UIView that's showing an
    overlay surface.
  * Creates an overlay surface for each embedded UIView (done in
    FlutterPlatformViewsController).
  * Changes CompositeEmbeddedView to return a new canvas.
  * Makes the PlatformViewLayer replace the PaintContext's canvas with
    the canvas for the overlay view.
  * Changed canvas in PaintContext to be a pointer so it can be changed.

TBD in following PRs:
  * Copy the current canvas state when replacing a canvas in PaintContext.
  * Make FlutterOverlayView work with a GL backend (currently it only
    works with software rendering)

* Roll src/third_party/skia 94d7af7bcc96..26fcd7166c74 (5 commits) (#6729)


https://skia.googlesource.com/skia.git/+log/94d7af7bcc96..26fcd7166c74


Created with:
  gclient setdep -r src/third_party/skia@26fcd7166c74

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 26fcd7166c74..2dc1e34f9029 (2 commits) (#6730)


https://skia.googlesource.com/skia.git/+log/26fcd7166c74..2dc1e34f9029


Created with:
  gclient setdep -r src/third_party/skia@2dc1e34f9029

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 2dc1e34f9029..13853a120d5a (1 commits) (#6731)


https://skia.googlesource.com/skia.git/+log/2dc1e34f9029..13853a120d5a


Created with:
  gclient setdep -r src/third_party/skia@13853a120d5a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 13853a120d5a..30edaaac1da4 (1 commits) (#6732)


https://skia.googlesource.com/skia.git/+log/13853a120d5a..30edaaac1da4


Created with:
  gclient setdep -r src/third_party/skia@30edaaac1da4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 30edaaac1da4..3bfe9665aabc (5 commits) (#6735)


https://skia.googlesource.com/skia.git/+log/30edaaac1da4..3bfe9665aabc


Created with:
  gclient setdep -r src/third_party/skia@3bfe9665aabc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Propagate positions of secondary pointers in UP events on Android (#6716)

* Update scene_update_context to match recent PaintContext changes. (#6736)

This fixes a Fuchsia build breakage cause by #6726 and #6603.

* Roll src/third_party/skia 3bfe9665aabc..13245412d49e (15 commits) (#6737)


https://skia.googlesource.com/skia.git/+log/3bfe9665aabc..13245412d49e


Created with:
  gclient setdep -r src/third_party/skia@13245412d49e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 13245412d49e..1edff303fddb (6 commits) (#6739)


https://skia.googlesource.com/skia.git/+log/13245412d49e..1edff303fddb


Created with:
  gclient setdep -r src/third_party/skia@1edff303fddb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll freetype2 to a10b062df0c8958d69377aa04ea6554a9961a111 (#6738)

* Roll freetype2 to a10b062df0c8958d69377aa04ea6554a9961a111

Removes support for uncommon/outdated font formats. This reduces `libflutter.so` by ~131 KB uncompressed or 86 KB compressed.

Going forward, we intent to only support the following formats:

* TrueType fonts (TTF) and TrueType collections (TTC)
* CFF fonts
* OpenType fonts (OTF, both TrueType and CFF variants) and OpenType collections (OTC)
* SFNT-based bitmap fonts, including color Emoji

This change has been announced at https://groups.google.com/forum/#!topic/flutter-announce/N5aeq5aC1To.

* licenses

* Roll src/third_party/skia 1edff303fddb..5d5de8bc79aa (4 commits) (#6740)


https://skia.googlesource.com/skia.git/+log/1edff303fddb..5d5de8bc79aa


Created with:
  gclient setdep -r src/third_party/skia@5d5de8bc79aa

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 5d5de8bc79aa..f1ec3918534f (3 commits) (#6741)


https://skia.googlesource.com/skia.git/+log/5d5de8bc79aa..f1ec3918534f


Created with:
  gclient setdep -r src/third_party/skia@f1ec3918534f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia f1ec3918534f..e1b1d056fed9 (1 commits) (#6742)


https://skia.googlesource.com/skia.git/+log/f1ec3918534f..e1b1d056fed9


Created with:
  gclient setdep -r src/third_party/skia@e1b1d056fed9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e1b1d056fed9..b5ae3b5afc29 (3 commits) (#6743)


https://skia.googlesource.com/skia.git/+log/e1b1d056fed9..b5ae3b5afc29


Created with:
  gclient setdep -r src/third_party/skia@b5ae3b5afc29

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia b5ae3b5afc29..7e4081554d06 (1 commits) (#6744)


https://skia.googlesource.com/skia.git/+log/b5ae3b5afc29..7e4081554d06


Created with:
  gclient setdep -r src/third_party/skia@7e4081554d06

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 7e4081554d06..2b21e88ed6dd (1 commits) (#6745)


https://skia.googlesource.com/skia.git/+log/7e4081554d06..2b21e88ed6dd


Created with:
  gclient setdep -r src/third_party/skia@2b21e88ed6dd

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 2b21e88ed6dd..99485ace81ac (1 commits) (#6746)


https://skia.googlesource.com/skia.git/+log/2b21e88ed6dd..99485ace81ac


Created with:
  gclient setdep -r src/third_party/skia@99485ace81ac

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 99485ace81ac..16d91aaf44fa (1 commits) (#6747)


https://skia.googlesource.com/skia.git/+log/99485ace81ac..16d91aaf44fa


Created with:
  gclient setdep -r src/third_party/skia@16d91aaf44fa

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 16d91aaf44fa..0a8b4e1acbd6 (1 commits) (#6748)


https://skia.googlesource.com/skia.git/+log/16d91aaf44fa..0a8b4e1acbd6


Created with:
  gclient setdep -r src/third_party/skia@0a8b4e1acbd6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 0a8b4e1acbd6..51916083e752 (2 commits) (#6749)


https://skia.googlesource.com/skia.git/+log/0a8b4e1acbd6..51916083e752


Created with:
  gclient setdep -r src/third_party/skia@51916083e752

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 51916083e752..e71e9ef311ba (1 commits) (#6750)


https://skia.googlesource.com/skia.git/+log/51916083e752..e71e9ef311ba


Created with:
  gclient setdep -r src/third_party/skia@e71e9ef311ba

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e71e9ef311ba..8b35379ae1f1 (6 commits) (#6751)


https://skia.googlesource.com/skia.git/+log/e71e9ef311ba..8b35379ae1f1


Created with:
  gclient setdep -r src/third_party/skia@8b35379ae1f1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 8b35379ae1f1..32262da42bed (8 commits) (#6752)


https://skia.googlesource.com/skia.git/+log/8b35379ae1f1..32262da42bed


Created with:
  gclient setdep -r src/third_party/skia@32262da42bed

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Clear the on-screen surface every frame. (#6753)

We are currently clearing the offscreen surface before rasterizing, but
as we draw the image snapshot of the offscreen surface into the onscreen
surface transparent pixels are blended with the current contents of the onscreen surface instead of replacing them. This is
particularly noticeable when embedding platform views.

* Roll src/third_party/skia 32262da42bed..df8225e253a2 (10 commits) (#6755)


https://skia.googlesource.com/skia.git/+log/32262da42bed..df8225e253a2


Created with:
  gclient setdep -r src/third_party/skia@df8225e253a2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia df8225e253a2..5b2bda70e52f (5 commits) (#6761)


https://skia.googlesource.com/skia.git/+log/df8225e253a2..5b2bda70e52f


Created with:
  gclient setdep -r src/third_party/skia@5b2bda70e52f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Add an Info.plist flag to enable the embedded iOS views preview. (#6756)

When the flag is true, we currently use a single thread configuration,
and disabled the raster cache for opacity layers.

The flag's name is 'io.flutter_embedded_views_preview'.

* Roll src/third_party/skia 5b2bda70e52f..11407e56f277 (1 commits) (#6762)


https://skia.googlesource.com/skia.git/+log/5b2bda70e52f..11407e56f277


Created with:
  gclient setdep -r src/third_party/skia@11407e56f277

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Revert "Roll freetype2 to a10b062df0c8958d69377aa04ea6554a9961a111 (#6738)" (#6763)

This reverts commit 731045e832c5856e7ec902f2c6a485e6e047e9ea.

* Roll src/third_party/skia 11407e56f277..e6c85755832b (2 commits) (#6765)


https://skia.googlesource.com/skia.git/+log/11407e56f277..e6c85755832b


Created with:
  gclient setdep -r src/third_party/skia@e6c85755832b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e6c85755832b..e70c6b13dd55 (1 commits) (#6766)


https://skia.googlesource.com/skia.git/+log/e6c85755832b..e70c6b13dd55


Created with:
  gclient setdep -r src/third_party/skia@e70c6b13dd55

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia e70c6b13dd55..f2b35e4fb8cc (6 commits) (#6768)


https://skia.googlesource.com/skia.git/+log/e70c6b13dd55..f2b35e4fb8cc


Created with:
  gclient setdep -r src/third_party/skia@f2b35e4fb8cc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* fix type in embedded views preview flag name (#6767)

* Roll src/third_party/skia f2b35e4fb8cc..2aa9a22fe159 (7 commits) (#6770)


https://skia.googlesource.com/skia.git/+log/f2b35e4fb8cc..2aa9a22fe159


Created with:
  gclient setdep -r src/third_party/skia@2aa9a22fe159

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Add instructions to download the full license log diff. (#6771)

* Roll update to harfbuzz to 2.1.0 (#6760)

* Update the contributing guide (#6754)

Content has moved to the wiki.

* Roll src/third_party/skia 2aa9a22fe159..630e7d651a34 (5 commits) (#6773)


https://skia.googlesource.com/skia.git/+log/2aa9a22fe159..630e7d651a34


Created with:
  gclient setdep -r src/third_party/skia@630e7d651a34

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Pass scriptCode into Locale on initialization. (#6711)

* fix setInitialRoute (#6774)

* fix setInitialRoute

* Roll src/third_party/skia 630e7d651a34..3daed9b12db4 (6 commits) (#6775)


https://skia.googlesource.com/skia.git/+log/630e7d651a34..3daed9b12db4


Created with:
  gclient setdep -r src/third_party/skia@3daed9b12db4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 3daed9b12db4..2a13921745eb (1 commits) (#6776)


https://skia.googlesource.com/skia.git/+log/3daed9b12db4..2a13921745eb


Created with:
  gclient setdep -r src/third_party/skia@2a13921745eb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 2a13921745eb..67f5c0ceac22 (2 commits) (#6777)


https://skia.googlesource.com/skia.git/+log/2a13921745eb..67f5c0ceac22


Created with:
  gclient setdep -r src/third_party/skia@67f5c0ceac22

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 67f5c0ceac22..273fa2f3bd0b (1 commits) (#6779)


https://skia.googlesource.com/skia.git/+log/67f5c0ceac22..273fa2f3bd0b


Created with:
  gclient setdep -r src/third_party/skia@273fa2f3bd0b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 273fa2f3bd0b..62cc5f581747 (7 commits) (#6780)


https://skia.googlesource.com/skia.git/+log/273fa2f3bd0b..62cc5f581747


Created with:
  gclient setdep -r src/third_party/skia@62cc5f581747

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Fix String comparison as if Java were Dart. (#6781)

This also removes unused imports and sorts imports correctly

* Roll src/third_party/skia 62cc5f581747..b52c273d3f05 (13 commits) (#6783)


https://skia.googlesource.com/skia.git/+log/62cc5f581747..b52c273d3f05


Created with:
  gclient setdep -r src/third_party/skia@b52c273d3f05

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Unify copyright lines (#6757)

* Delete unused license goldens and add check (#6784)

* Roll src/third_party/skia b52c273d3f05..f49563bf9276 (7 commits) (#6785)


https://skia.googlesource.com/skia.git/+log/b52c273d3f05..f49563bf9276


Created with:
  gclient setdep -r src/third_party/skia@f49563bf9276

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Skia Cleanup (#6786)

* Roll Dart version to 9c07fb64c48adb3d6fde50bab6b8b641c5b67683 (#6788)

This hash corresponds to 2.10-dev.9.2

Changes in this roll include:
- Fix for https://github.com/flutter/flutter/issues/23879 (Revert
"[vm/compiler] Fine tune operator and phi handling.)
- Fix for Dart issue https://github.com/dart-lang/sdk/issues/35009
- Recover from default values in function types
- [vm, reload] On the path for no shape changes, defer freeing the old
- [vm] Fix misc printf format bugs.
- [VM] Added cleanup for Dart IO API

* Roll src/third_party/skia f49563bf9276..71bcc7d63f8c (3 commits) (#6790)


https://skia.googlesource.com/skia.git/+log/f49563bf9276..71bcc7d63f8c


Created with:
  gclient setdep -r src/third_party/skia@71bcc7d63f8c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* avoid overreleasing FlutterView (#6791)

* Roll src/third_party/skia 71bcc7d63f8c..2f8889b876d3 (1 commits) (#6792)


https://skia.googlesource.com/skia.git/+log/71bcc7d63f8c..2f8889b876d3


Created with:
  gclient setdep -r src/third_party/skia@2f8889b876d3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 2f8889b876d3..23d1f94faac1 (1 commits) (#6793)


https://skia.googlesource.com/skia.git/+log/2f8889b876d3..23d1f94faac1


Created with:
  gclient setdep -r src/third_party/skia@23d1f94faac1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia 23d1f94faac1..fa8898747551 (1 commits) (#6794)


https://skia.googlesource.com/skia.git/+log/23d1f94faac1..fa8898747551


Created with:
  gclient setdep -r src/third_party/skia@fa8898747551

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll src/third_party/skia fa8898747551..5d58d09ae77d (4 commits) (#6796)


https://skia.googlesource.com/skia.git/+log/fa8898747551..5d58d09ae77d


Created with:
  gclient setdep -r src/third_party/skia@5d58d09ae77d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Add an internal_nodes_canvas to PaintContext. (#6728)

When we visit a PlatformViewLayer during the paint traversal it replaces
the PaintContext's canvas with a new one that is painted ontop of the
embedded view.
We need to make sure that operations applied by parent layers are also
applied to the new canvas.

To achieve this we collect all the canvases in a SkNWayCanvas and use
this canvas by non leaf nodes. Leaf nodes still paint only to the "current"
canvas.

This PR moves the overlay canvas creation from the paint phase to the
preroll phase, collects them into a SkNWayCanvas and set it in
PaintContext.

To keep this PR focused, I only used the internal_nodes_canvas in the
tranform_layer.
Will followup with a PR that changes all internal layers to use the
internal_nodes_canvas.

* Discard embedded UIViews on hot restart. (#6772)

* Roll src/third_party/skia 5d58d09ae77d..06a477c3300d (5 commits) (#6797)


https://skia.googlesource.com/skia.git/+log/5d58d09ae77d..06a477c3300d


Created with:
  gclient setdep -r src/third_party/skia@06a477c3300d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* disable embedder_unittests (#6798)

* Fix mDNS publishing for iOS simulator (#6789)

* Don't block the platfrorm thread on simulator mDNS publishing

* Make the FlutterPlatformViewFactory create FlutterPlatformViews. (#6782)

Handing a UIView refererence directly to the engine makes it challenging
for plugin authors to retain a controller for that UIView (e.g the
controller that talks over the platform channel) for as long as the
embedded view is needed.

We instead make the factory return a FlutterPlatformView which is a
wrapper around the UIView that the engine retains as long as the
platform view instance is needed. This allows plugin authors to keep
their control logic in the FlutterPlatformView and know that the engine
is responsible for retaining the reference.

* Include vector in embedded_views.h (#6800)

* Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (#6801)


https://skia.googlesource.com/skia.git/+log/06a477c3300d..dd650c40d148


Created with:
  gclient setdep -r src/third_party/skia@dd650c40d148

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Update paint hinting for upcoming Skia API changes. (#6802)

* Revert "Roll src/third_party/skia 06a477c3300d..dd650c40d148 (11 commits) (#6801)" (#6809)

This reverts commit e011d544b4e3ff0c2af5babddacdbb1f677f7cca.

* Support platform view overlays with GL rendering (#6769)

Moved the frame buffer specific logic from IOSGLContext to IOSGLRenderTarget.

use recording canvases for overlays

Support platform view overlays with gl rendering.

This also changes the overlay canvases (for both software and gl
rendering) be recording canvases, and only rasterize them after
finishing the paint traversal.

* Reland "Roll freetype2 to a10b062df0c8958d69377aa04ea6554a9961a111 (#6738)" (#6787)

This reverts commit fb5b097e5c20d2af9d4178530f0f4acd9d173401.

* Fix wrong `flutter/platform_views` protocol implementation on iOS. (#6803)

The `id` parameter of onDispose is passed as the method argument and not as
part of a map.

* Move the embedded view preview flag check to a common function. (#6813)

* Update Vulkan headers to 1.1 (#6806)

* Synchronize Flutter's rendering with CA. (#6807)

Right now we do it whenever the platform views preview flag is on.
This is less efficient, filed
https://github.com/flutter/flutter/issues/24133 to only do this when
there's a platform view in the tree.

* Use the internal_nodes_canvas for all leaf node operations. (#6804)

This also renames the PaintContext's canvas to lead_nodes_canvas so that it
is more explicit on the call sites which canvas is being used.

* Roll src/third_party/skia 06a477c3300d..ef4709b7850d (31 commits) (#6811)

https://skia.googlesource.com/skia.git/+log/06a477c3300d..ef4709b7850d

Created with:
  gclient setdep -r src/third_party/skia@ef4709b7850d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

* Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc (#6812)

* Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc

This roll includes the following fixes:
- Fix obfuscation (issue
https://github.com/flutter/flutter/issues/22322)
- Fix for issue 34839 Service isolate hangs during shutdown if
- Fix bug in unboxed constant spilling
(https://github.com/flutter/flutter/issues/23879)
- Reland Fine tune operator and phi handling which was reverted due to
the above bug.

* Roll src/third_party/skia ef4709b785…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.