Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should be more consistent about Foo._(); vs factory Foo._() => null; #26095

Closed
Hixie opened this issue Jan 4, 2019 · 1 comment · Fixed by #81632
Closed

We should be more consistent about Foo._(); vs factory Foo._() => null; #26095

Hixie opened this issue Jan 4, 2019 · 1 comment · Fixed by #81632
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@Hixie
Copy link
Contributor

Hixie commented Jan 4, 2019

In the engine and framework we are inconsistent about how we handle classes that are all static methods.

Sometimes they're abstract, sometimes they're not; sometimes they have X._() constructors, sometimes they have factory X._() => null constructors.

I think we should standardize on non-abstract with factory X._() => null constructors, with the same comment as we currently have for PluginUtilities.
@Hixie Hixie added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. labels Jan 4, 2019
@Hixie Hixie added this to the Stretch Goals milestone Jan 4, 2019
@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@kf6gpe kf6gpe added the P3 Issues that are less important to the Flutter project label May 29, 2020
@Hixie Hixie removed this from the - milestone Aug 17, 2020
@Hixie Hixie mentioned this issue May 2, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this issue May 11, 2021
@Hixie
Be more consistent about how we mark classes that can't be extended.
c9d461f 
Fixes flutter#26095
@github-actions
Copy link

github-actions bot commented Aug 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be more consistent about how we mark classes that can't be extended. Hixie/flutter
3 participants
@Hixie @kf6gpe @pedromassangocode