New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more consistent about how we mark classes that can't be extended. #81632
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these ones different?
- TickerFuture
- PlatformViewsService
- RawKeyboard
- TextInput
- DoNothingIntent - this one looks like a special case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: update comment of modified constructors to have the same comment everywhere.
@Piinks Yeah, those are meant to be instantiated but only by code in their own file. I could have a separate comment for those if you like. @a14n There's three different cases: interfaces, classes that just contain statics, and classes instantiated locally. They have different comments. Did you find another kind of comment? |
Not really. I didn't really pay attention that they were 3 different cases. So it looks good. |
This pull request is not suitable for automatic merging in its current state.
|
Fixes #26095
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.