Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a Win32/UWP desktop shell #30726

Closed
stuartmorgan opened this issue Apr 8, 2019 · 5 comments
Closed

Implement a Win32/UWP desktop shell #30726

stuartmorgan opened this issue Apr 8, 2019 · 5 comments
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-windows Building on or for Windows specifically

Comments

@stuartmorgan
Copy link
Contributor

The current implementation on Windows is a temporary solution using GLFW; the goal is to implement a more flexible, view-based solution that could be used in an existing application, similar to what currently exists on macOS.

See previous discussion in google/flutter-desktop-embedding#6 and google/flutter-desktop-embedding#101.

@stuartmorgan
Copy link
Contributor Author

CC @clarkezone who is working on this.

@stuartmorgan stuartmorgan added the engine flutter/engine repository. See also e: labels. label Apr 8, 2019
@stuartmorgan
Copy link
Contributor Author

For cross-referencing, #14967 is general umbrella feature request for UWP. I'll leave this open separately since this is specifically tracking an initial shell implementation rather than the overall support.

@VOM7HC VOM7HC mentioned this issue May 25, 2019
@VOM7HC
Copy link

VOM7HC commented May 25, 2019

As UWP developer, I am waiting GG support UWP too much

@stuartmorgan stuartmorgan added this to To do in Windows Preview Jun 11, 2019
@stuartmorgan stuartmorgan added a: desktop Running on desktop and removed e: desktop labels Jul 26, 2019
@stuartmorgan stuartmorgan added this to the September 2019 milestone Aug 13, 2019
stuartmorgan pushed a commit to flutter/engine that referenced this issue Aug 14, 2019
Start work on flutter/flutter#30726 by adding an alternative win32 shell platform implementation for Windows that is not based on GLFW and that uses LIBANGLE for rendering and native win32 windowing and input. This change does not replace the GLFW implementation but rather runs side by side with it producing a secondary flutter_windows_win32.dll artifact. The following items must be added to attain parity with the GLFW implementation:
- Custom task scheduling
- Support for keyboard modifier keys
- Async texture uploads
- Correct high DPI handling on Windows versions < 1703
and will be added in subsequent changes.
@stuartmorgan
Copy link
Contributor Author

This actually should have been closed when the last PR above landed; we're now using a Win32 shell rather than the GLFW shell.

#14967 continues to track UWP specifically.

Windows Preview automation moved this from To do to Done Sep 18, 2019
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-windows Building on or for Windows specifically
Projects
No open projects
Development

No branches or pull requests

2 participants