Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generator is handling slashes improperly in directory names: #43382

Closed
DaveShuckerow opened this issue Oct 23, 2019 · 1 comment · Fixed by #43448
Closed

Code generator is handling slashes improperly in directory names: #43382

DaveShuckerow opened this issue Oct 23, 2019 · 1 comment · Fixed by #43448
Assignees
@harryterkelsen
Labels
customer: webeap package flutter/packages repository. See also p: labels. platform-web Web applications specifically waiting for PR to land (fixed) A fix is in flight
Milestone
October 2019

Comments

@DaveShuckerow
Copy link
Contributor

Generating a plugin for file package:devtools_app/src/debugger/plugin/flutter/debugger_html_plugin.dart is getting escaped slashes:

import 'package:devtools_app/src/debugger/plugin/flutter/debugger_html_plugin.dart'; from
devtools_app|lib/generated_plugin_registrant.dart at 6:1

@hterkelsen CC
@harryterkelsen harryterkelsen added plugin platform-web Web applications specifically labels Oct 23, 2019
@harryterkelsen harryterkelsen added this to the October 2019 milestone Oct 23, 2019
@harryterkelsen harryterkelsen self-assigned this Oct 23, 2019
harryterkelsen added a commit to harryterkelsen/flutter that referenced this issue Oct 24, 2019
@harryterkelsen
Don't html-escape in the plugin registrant templates.
aaabc3c 
Fixes flutter#43382
@harryterkelsen harryterkelsen mentioned this issue Oct 24, 2019
Merged
9 tasks
@DaveShuckerow DaveShuckerow mentioned this issue Oct 25, 2019
Merged
harryterkelsen pushed a commit that referenced this issue Oct 25, 2019
Don't html-escape in the plugin registrant templates. (#43448)
eba69ca 
* Don't html-escape in the plugin registrant templates.

Fixes #43382

* Add test
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this issue Nov 26, 2019
@Inconnu08
Don't html-escape in the plugin registrant templates. (flutter#43448)
5487070 
* Don't html-escape in the plugin registrant templates.

Fixes flutter#43382

* Add test
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@harryterkelsen harryterkelsen

Labels
customer: webeap package flutter/packages repository. See also p: labels. platform-web Web applications specifically waiting for PR to land (fixed) A fix is in flight
Projects
None yet
Milestone
October 2019
Development

Successfully merging a pull request may close this issue.

Don't html-escape in the plugin registrant templates. harryterkelsen/flutter
2 participants
@harryterkelsen @DaveShuckerow