Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't html-escape in the plugin registrant templates. #43448

Merged
merged 3 commits into from Oct 25, 2019
Merged

Don't html-escape in the plugin registrant templates. #43448

merged 3 commits into from Oct 25, 2019

Conversation

harryterkelsen
Copy link
Contributor

Description

Don't escape the strings in the plugin registrant templates. Escaping was causing us to generate invalid imports for the cases where the file path contained slashes, since they were being escaped.

Related Issues

Tests

I added the following tests:

  • A test to check that nested plugin files were properly rendered into the generated registrant in test/general.shard/plugins_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 24, 2019
jonahwilliams
jonahwilliams approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harryterkelsen harryterkelsen merged commit eba69ca into flutter:master Oct 25, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@Inconnu08
Don't html-escape in the plugin registrant templates. (flutter#43448)
5487070 
* Don't html-escape in the plugin registrant templates.

Fixes flutter#43382

* Add test
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code generator is handling slashes improperly in directory names:
4 participants
@harryterkelsen @jonahwilliams @googlebot @fluttergithubbot