Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter version gets confused on master with some configurations of Git history #50577

Closed
dnfield opened this issue Feb 11, 2020 · 7 comments
Closed
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@dnfield
Copy link
Contributor

dnfield commented Feb 11, 2020

Sometimes, a PR has to have its git history rewritten because the tool starts reporting some older version of Flutter with a very high .pre number. See for example #45035

The work around for this is to:

git fetch upstream
git reset --soft upstream/master
git commit -m 'rewrite history!'
git push -f

Or something like that. This gets the version output back to normal on CI.

Ideally, the tool would be able to handle this situation. I'm not as familiar with its version logic though - @jonahwilliams maybe?

/cc @Piinks

@dnfield dnfield added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 11, 2020
@Piinks
Copy link
Contributor

Piinks commented Feb 11, 2020

I've seen this on a couple of different PRs now that were from older branches. Here is another one: #42100 (comment)

@dnfield
Copy link
Contributor Author

dnfield commented Feb 11, 2020

We might not have to fix this globally if it's not possible, but we should at least see if we can fix it for the analysis script on the bots.

@jmagman
Copy link
Member

jmagman commented Feb 11, 2020

#42100 (comment)

 The current Flutter SDK version is 1.10.7-pre.130.

    | 

    | Because flutter_gallery depends on video_player_web >=0.1.1 which requires Flutter SDK version >=1.12.8 <2.0.0, version solving failed.

It should be saying the current flutter SDK version is 1.14.x-pre.something, not 1.10.7-pre.130.

@Piinks
Copy link
Contributor

Piinks commented Feb 12, 2020

Here is a more recent occurrence: https://cirrus-ci.com/task/5901078327721984 from #44888

@christopherfujino
Copy link
Member

this looks like #15529

@dnfield
Copy link
Contributor Author

dnfield commented Mar 5, 2020

Agreed - I'll close this as a dupe of that one since it has a better repro case.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

No branches or pull requests

4 participants