Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] ImageProvider NetworkImage Notifies listeners of chunk events broken test #56317

Closed
Piinks opened this issue May 4, 2020 · 5 comments
Closed

[Web] ImageProvider NetworkImage Notifies listeners of chunk events broken test #56317

Piinks opened this issue May 4, 2020 · 5 comments
Assignees
@ferhatb
Labels
a: images Loading, displaying, rendering images a: tests "flutter test", flutter_test, or one of our tests assigned for triage issue is assigned to a domain expert for further triage framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@Piinks
Copy link
Contributor

Piinks commented May 4, 2020

Following up on skipped test. This test crashes when run on web. I have not been able to find a reference or issue regarding this.

Test name: ImageProvider NetworkImage notifies listeners of chunk events

flutter/packages/flutter/test/painting/image_provider_test.dart

Line 398 in c32d138

}, skip: isBrowser); 

03:12 +336 ~6 -2: /tmp/flutter sdk/packages/flutter/test/painting/image_provider_test.dart: ImageProvider NetworkImage Notifies listeners of chunk events [E]                                          
  [object Event]
  package:dart-sdk/lib/async/future_impl.dart 24:43                                         completeError
  package:build_web_compilers/lib/_engine/engine/html_image_codec.dart 75:16                <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 326:14  _checkAndCall
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 331:39  dcall
  package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37108:58                              <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1196:13                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/zone.dart 987:7                                                runUnaryGuarded
  package:dart-sdk/lib/async/zone.dart 1024:26                                              <fn>
  ===== asynchronous gap ===========================
  package:dart-sdk/lib/async/zone.dart 1109:19                                              registerUnaryCallback
  package:dart-sdk/lib/async/zone.dart 1023:22                                              bindUnaryCallbackGuarded
  package:dart-sdk/lib/html/dart2js/html_dart2js.dart 40576:23                              _wrapZone
  package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37108:15                              new
  package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37009:16                              listen
  package:build_web_compilers/lib/_engine/engine/html_image_codec.dart 72:35                [_decodeUsingOnLoad]
  package:build_web_compilers/lib/_engine/engine/html_image_codec.dart 56:9                 <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1192:38                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/future_impl.dart 159:20                                        handleError
  package:dart-sdk/lib/async/future_impl.dart 698:46                                        handleError
  package:dart-sdk/lib/async/future_impl.dart 719:24                                        _propagateToListeners
  package:dart-sdk/lib/async/future_impl.dart 534:5                                         [_completeError]
  package:dart-sdk/lib/async/future_impl.dart 586:7                                         <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 979:7                                                runGuarded
  package:dart-sdk/lib/async/zone.dart 1019:23                                              callback
  package:dart-sdk/lib/async/schedule_microtask.dart 43:11                                  _microtaskLoop
  package:dart-sdk/lib/async/schedule_microtask.dart 52:5                                   _startMicrotaskLoop
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 168:15               <fn>
  ===== asynchronous gap ===========================
  package:dart-sdk/lib/async/zone.dart 1109:19                                              registerUnaryCallback
  package:dart-sdk/lib/async/future_impl.dart 813:16                                        _registerErrorHandler
  package:dart-sdk/lib/async/future_impl.dart 306:17                                        catchError
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:build_web_compilers/lib/_engine/engine/html_image_codec.dart 30:36                getNextFrame
  package:flutter/src/painting/image_stream.dart 716:33                                     _decodeNextFrameAndSchedule
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:flutter/src/painting/image_stream.dart 714:43                                     [_decodeNextFrameAndSchedule]
  package:flutter/src/painting/image_stream.dart 680:7                                      [_handleCodecReady]
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1192:38                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/future_impl.dart 141:18                                        handleValue
  package:dart-sdk/lib/async/future_impl.dart 686:44                                        handleValueCallback
  package:dart-sdk/lib/async/future_impl.dart 715:32                                        _propagateToListeners
  package:dart-sdk/lib/async/future_impl.dart 391:9                                         <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 979:7                                                runGuarded
  package:dart-sdk/lib/async/zone.dart 1019:23                                              callback
  package:dart-sdk/lib/async/schedule_microtask.dart 43:11                                  _microtaskLoop
  package:dart-sdk/lib/async/schedule_microtask.dart 52:5                                   _startMicrotaskLoop
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 168:15               <fn>
  ===== asynchronous gap ===========================
  package:dart-sdk/lib/async/zone.dart 1109:19                                              registerUnaryCallback
  package:dart-sdk/lib/async/future_impl.dart 278:22                                        then
  package:flutter/src/painting/image_stream.dart 636:10                                     new
  package:flutter/src/painting/_network_image_web.dart 51:12                                load
  package:flutter/src/painting/image_provider.dart 501:13                                   <fn>
  package:flutter/src/painting/image_cache.dart 359:22                                      putIfAbsent
  package:flutter/src/painting/image_provider.dart 499:80                                   resolveStreamForKey
  package:flutter/src/painting/image_provider.dart 330:9                                    <fn>
  package:flutter/src/painting/image_provider.dart 460:26                                   <fn>
  package:flutter/src/foundation/synchronous_future.dart 41:29                              then
  package:flutter/src/painting/image_provider.dart 457:10                                   <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 979:7                                                runGuarded
  package:flutter/src/painting/image_provider.dart 449:15                                   [_createErrorHandlerAndKey]
  package:flutter/src/painting/image_provider.dart 327:5                                    resolve
  image_provider_test.dart 379:49                                                           <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  image_provider_test.dart 346:50                                                           <fn>
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 47:50                onValue
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1192:38                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/future_impl.dart 141:18                                        handleValue
  package:dart-sdk/lib/async/future_impl.dart 686:44                                        handleValueCallback
  package:dart-sdk/lib/async/future_impl.dart 715:32                                        _propagateToListeners
  package:dart-sdk/lib/async/future_impl.dart 391:9                                         <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 979:7                                                runGuarded
  package:dart-sdk/lib/async/zone.dart 1019:23                                              callback
  package:dart-sdk/lib/async/schedule_microtask.dart 43:11                                  _microtaskLoop
  package:dart-sdk/lib/async/schedule_microtask.dart 52:5                                   _startMicrotaskLoop
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 168:15               <fn>
  ===== asynchronous gap ===========================
  package:dart-sdk/lib/async/zone.dart 1109:19                                              registerUnaryCallback
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 69:19                _async
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1618:67                                              _runZoned
  package:dart-sdk/lib/async/zone.dart 1539:10                                              runZoned
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1618:67                                              _runZoned
  package:dart-sdk/lib/async/zone.dart 1539:10                                              runZoned
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/future.dart 176:37                                             <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1180:38                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 979:7                                                runGuarded
  package:dart-sdk/lib/async/zone.dart 1019:23                                              <fn>
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1003:23                                              <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 50:19           internalCallback
  ===== asynchronous gap ===========================
  package:dart-sdk/lib/async/zone.dart 1101:19                                              registerCallback
  package:dart-sdk/lib/async/zone.dart 1018:22                                              bindCallbackGuarded
  package:dart-sdk/lib/async/timer.dart 54:45                                               new
  package:dart-sdk/lib/async/timer.dart 91:9                                                run
  package:dart-sdk/lib/async/future.dart 174:11                                             new
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54                runBody
  package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12               _async
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1618:67                                              _runZoned
  package:dart-sdk/lib/async/zone.dart 1539:10                                              runZoned
  package:stack_trace                                                                       <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1618:67                                              _runZoned
  package:dart-sdk/lib/async/zone.dart 1539:10                                              runZoned
  package:test_api                                                                          [_onRun]
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 326:14  _checkAndCall
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 390:10  callMethod
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 394:5   dsend
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/zone.dart 1184:13                                              _rootRun
  package:dart-sdk/lib/async/zone.dart 1077:19                                              run
  package:dart-sdk/lib/async/zone.dart 1618:67                                              _runZoned
  package:dart-sdk/lib/async/zone.dart 1539:10                                              runZoned
  package:test_api                                                                          <fn>
  package:dart-sdk/lib/async/zone.dart 1192:38                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/zone.dart 987:7                                                runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/zone.dart 1196:13                                              _rootRunUnary
  package:dart-sdk/lib/async/zone.dart 1085:19                                              runUnary
  package:dart-sdk/lib/async/zone.dart 987:7                                                runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/stream_controller.dart 873:13                                  add
  package:stream_channel                                                                    <fn>
  package:dart-sdk/lib/async/zone.dart 1374:10                                              runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/zone.dart 1374:10                                              runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/stream_controller.dart 873:13                                  add
  package:dart-sdk/lib/async/zone.dart 1374:10                                              runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/zone.dart 1374:10                                              runUnaryGuarded
  package:dart-sdk/lib/async/stream_impl.dart 339:11                                        [_sendData]
  package:dart-sdk/lib/async/stream_impl.dart 266:7                                         [_add]
  package:dart-sdk/lib/async/stream_controller.dart 779:19                                  [_sendData]
  package:dart-sdk/lib/async/stream_controller.dart 655:7                                   [_add]
  package:dart-sdk/lib/async/stream_controller.dart 597:5                                   add
  package:dart-sdk/lib/async/stream_controller.dart 873:13                                  add
  package:stream_channel                                                                    add
  image_provider_test.dart.browser_test.dart 52:17                                          <fn>
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 326:14  _checkAndCall
  package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 331:39  dcall
  package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37108:58                              <fn>
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically a: images Loading, displaying, rendering images labels May 4, 2020
@Piinks Piinks mentioned this issue May 4, 2020
Merged
9 tasks
@yjbanov yjbanov added the assigned for triage issue is assigned to a domain expert for further triage label May 7, 2020
@yjbanov
Copy link
Contributor

yjbanov commented May 7, 2020

@ferhatb Can you please triage this? I believe this is related to image loading progress functionality.

@ferhatb
Copy link
Contributor

ferhatb commented May 8, 2020

Note: The original issue was fixed in #52558. Test needs to be checked to make sure it accounts for web not showing precise stats.

@ferhatb ferhatb closed this as completed May 8, 2020
@ferhatb
Copy link
Contributor

ferhatb commented May 8, 2020

Closed since Kate unskipped after fix. It is passing now, no skips.

@Piinks
Copy link
Contributor Author

Piinks commented May 8, 2020

This test was not unskipped. It was relocated in a recent refactoring:

flutter/packages/flutter/test/painting/image_provider_network_image_test.dart

Line 134 in 2304838

test('Notifies listeners of chunk events', () async {

@Piinks Piinks reopened this May 8, 2020
@ferhatb ferhatb mentioned this issue May 14, 2020
Merged
13 tasks
@ferhatb ferhatb closed this as completed May 18, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ferhatb ferhatb

Labels
a: images Loading, displaying, rendering images a: tests "flutter test", flutter_test, or one of our tests assigned for triage issue is assigned to a domain expert for further triage framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yjbanov @ferhatb @Piinks