Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Update test skip description. #57240

Merged
merged 2 commits into from May 18, 2020
Merged

[web] Update test skip description. #57240

merged 2 commits into from May 18, 2020

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented May 14, 2020

Description

Web engine doesn't use Http to load and decode. It uses image element. Web itself doesn't report progress due to security implications (exposing size of remote files).

This PR updates the skip description.

Related Issues

Addresses: #56317

Tests

Test case updated.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@ferhatb ferhatb requested a review from Piinks May 14, 2020 19:05
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label May 14, 2020
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests platform-web Web applications specifically labels May 14, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! Can we close the issue then?

@ferhatb ferhatb merged commit a4ca9d7 into flutter:master May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants