Skip to content

[web] Add support for ChunkEvents during image loading#52558

Merged
ferhatb merged 3 commits intoflutter:masterfrom
ferhatb:loading_progress2
Mar 17, 2020
Merged

[web] Add support for ChunkEvents during image loading#52558
ferhatb merged 3 commits intoflutter:masterfrom
ferhatb:loading_progress2

Conversation

@ferhatb
Copy link
Copy Markdown
Contributor

@ferhatb ferhatb commented Mar 13, 2020

Description

Adds ChunkEvents support to network image loading by calling HtmlCodec with progress callback.
!!! This requires landing of engine PR : flutter/engine#17139

Related Issues

#50586

Tests

Covered by image_stream_test.
Using engine PR , ran flutter test --platform=chrome --local-engine=host_debug_unopt test/painting/image_stream_test.dart and it started passing.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 13, 2020
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ferhatb ferhatb merged commit d3a66e3 into flutter:master Mar 17, 2020
@lock
Copy link
Copy Markdown

lock Bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants