Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify assets that are for development only #5813

Open
eukreign opened this issue Sep 10, 2016 · 6 comments
Open

specify assets that are for development only #5813

eukreign opened this issue Sep 10, 2016 · 6 comments
Labels
a: assets Packaging, accessing, or using assets c: new feature Nothing broken; request for a new capability customer: castaway P3 Issues that are less important to the Flutter project team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team

Comments

@eukreign
Copy link
Contributor

It would be useful to specify some assets that should be loaded only during development and ignored when doing a release build.

I'm proposing adding a dev_assets option to flutter.yml to mimic the similar concept of dev_dependencies in the standard Dart pubspec.yaml.

This feature is in someway related #4014 in that you need a way to know in your code that dev_assets are available to use.

@Hixie Hixie modified the milestone: Flutter 1.0 Sep 12, 2016
@Hixie Hixie added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 12, 2016
@eseidelGoogle
Copy link
Contributor

Do Android or iOS OEM build systems have equivalents we should either use or match here?

Incidentally Google internal flutter users can do something like this because they use bazel, and the flutter_application bazel rule takes a list of assets (instead of getting them from flutter.yaml). We have a very simple build system built into the flutter tool on top of flutter.yaml, sounds like this is asking for something a bit more sophisticated.

@Hixie Hixie added c: new feature Nothing broken; request for a new capability a: assets Packaging, accessing, or using assets labels May 29, 2018
liyuqian added a commit to liyuqian/flutter that referenced this issue Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (flutter#5834)
29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (flutter#5833)
5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (flutter#5832)
380eb84 Remove unused function CreateSkiaInterface (flutter#5812)
33a4aef Fix build break caused by flutter/engine#5830 (flutter#5831)
244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (flutter#5830)
0bad812 Migrate to a standalone Tonic repository separated from Topaz (flutter#5817)
f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (flutter#5829)
768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (flutter#5828)
b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (flutter#5804)
b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (flutter#5824)
5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (flutter#5822)
926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (flutter#5821)
04633f3 Generate process global trace identifiers for pipeline flow traces. (flutter#5818)
fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (flutter#5820)
fadfff7 Mention that running git clone isn't necessary (flutter#5816)
81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (flutter#5819)
2a77a41 Make git diff range more robust in format.sh (flutter#5813)
e555ea5 Remove trailing white spaces (flutter#5734)
4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (flutter#5814)
liyuqian added a commit that referenced this issue Jul 24, 2018
95e91e3 Update tonic to pull in Android build fixes. (#5834)
29f475c Update tonic to pull in fixes to assertions and build failures on Windows. (#5833)
5474415 Roll src/third_party/skia e35055f31c7f..b8eeb808d84f (5 commits) (#5832)
380eb84 Remove unused function CreateSkiaInterface (#5812)
33a4aef Fix build break caused by flutter/engine#5830 (#5831)
244ebd6 Reapply "Fix Dart 2 reload when running from a snapshot instead of platform.dill." (#5830)
0bad812 Migrate to a standalone Tonic repository separated from Topaz (#5817)
f949f7d Roll src/third_party/skia 206dbe8a21b6..e35055f31c7f (1 commits) (#5829)
768daa4 Roll src/third_party/skia 5e6cd2affe41..206dbe8a21b6 (5 commits) (#5828)
b8cd25b libtxt: fix a bug that used incorrect buffer size depending on conditions (#5804)
b7b13b5 Roll src/third_party/skia df795638b9bd..5e6cd2affe41 (1 commits) (#5824)
5886949 Roll src/third_party/skia dfe1fe40796e..df795638b9bd (1 commits) (#5822)
926f546 Roll src/third_party/skia cc22d4d2fb02..dfe1fe40796e (1 commits) (#5821)
04633f3 Generate process global trace identifiers for pipeline flow traces. (#5818)
fb0bc05 Roll src/third_party/skia 6f6de6524c73..cc22d4d2fb02 (1 commits) (#5820)
fadfff7 Mention that running git clone isn't necessary (#5816)
81ec600 Roll src/third_party/skia d3509a42638a..6f6de6524c73 (5 commits) (#5819)
2a77a41 Make git diff range more robust in format.sh (#5813)
e555ea5 Remove trailing white spaces (#5734)
4c7618a Roll src/third_party/skia fa0720436319..d3509a42638a (7 commits) (#5814)
@photex
Copy link

photex commented Aug 10, 2018

Are there any plans to bring the internal bazel rules for flutter out into the open source bazel?

We are likely going to pass over flutter because we spent a lot of effort setting up that "one true build" with bazel.

@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@jmagman jmagman added this to Awaiting triage in Tools - assets review Jan 10, 2020
@jonahwilliams jonahwilliams moved this from Awaiting triage to Engineer reviewed in Tools - assets review Jan 15, 2020
@kf6gpe kf6gpe added the P3 Issues that are less important to the Flutter project label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Stretch Goals Jun 1, 2020
@Hixie Hixie removed this from the [DEPRECATED] Stretch Goals milestone Jun 16, 2020
@kf6gpe kf6gpe removed this from the [DEPRECATED] Stretch Goals milestone Jul 7, 2020
@kf6gpe kf6gpe modified the milestone: [DEPRECATED] Stretch Goals Jul 22, 2020
@Hixie Hixie removed this from the - milestone Aug 17, 2020
@Remigius2011
Copy link

@eximius313
Copy link

Imagine having local configuration file with credentials used only by devs.
In production this file is delivered by server environment, so the local file should not be included in the build.

@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
@tcannon-disney
Copy link

We have a use case where we are a published package but would like to denote that some of the assets are for testing usage only. I feel like a dev_assets: section would be ideal for this kind of usage.

@drown0315
Copy link
Contributor

We have a use case where we are a published package but would like to denote that some of the assets are for testing usage only. I feel like a dev_assets: section would be ideal for this kind of usage.我们有一个用例,其中我们是已发布的包,但想指出某些资产仅用于测试使用。我觉得 dev_assets: 部分非常适合这种用法。

I faced the same scenario: I wrote a general widget package and made a golden test on a widget that required some images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: assets Packaging, accessing, or using assets c: new feature Nothing broken; request for a new capability customer: castaway P3 Issues that are less important to the Flutter project team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - assets review
  
Engineer reviewed
Development

No branches or pull requests

10 participants