Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] Add new entrypoint that uses hybrid composition on Android #61133

Closed
blasten opened this issue Jul 8, 2020 · 25 comments · Fixed by flutter/plugins#2883 or flutter/plugins#3067
Assignees
Labels
a: platform-views Embedding Android/iOS views in Flutter apps c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. p: webview The WebView plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically waiting for PR to land (fixed) A fix is in flight

Comments

@blasten
Copy link

blasten commented Jul 8, 2020

This is a feature request to support hybrid composition. The plan is to add a new Dart entrypoint that doesn't change the public API of the webview plugin, but internally uses this new mode.

Once this is done, we will ask folks to try it out, and we will learn from their experiences.

Issues solved by this:

  1. CustomScrollView + SliverAppBar + WebView #31243
  2. Accessibility support for embedded Android views #19418
  3. [webview_flutter] Keyboard language can't change on Android #41089
  4. WebView's text selection dialog is not responding to touch events #24585
  5. [webview_flutter] works badly with TalkBack enabled. #50716
  6. WebView's text selection handles are not showing on Android #24584
  7. [webview_flutter] Keyboard persists after tapping outside text field #36478
  8. Webview animation is slow on Android #52211
  9. [webview_flutter] Keyboard suggestions can be lost #37989
  10. Web contents invisible when keyboard show in Android [flutter_webview] #51254
  11. PlatformViewsController Trying to use platform views with API 19, required API level is: 20.Can you lower the api level? #23728 (Support API level 19)
  12. [webview_flutter] works badly with TalkBack enabled. #50716
  13. [webview_flutter] The video which is playing that will be paused, After screen orientation was changed. #51915
  14. webview_flutter scroll feels sluggish on Android #61280
  15. [webview_flutter] does not show number keypad for number fields #55724
  16. [webview_flutter] Android Keyboard automatically closed in landscape mode #56513
  17. Flutter Webview_flutter - Search keypad does not show for input fields #56515
  18. [honor][huawei][xiaomi] Problem with keyboard in webview_flutter #61085
  19. [webview_flutter] on Android, soft keyboard always lowercased on textarea and contenteditable #62205
  20. [WebView]Android devices cannot show the popup menu as iOS does #62547
  21. the keyboard can't input when webview_flutter using <input type='password'>  #58943
  22. [webview]How to change webview defalut language? #56361
  23. [webview_flutter] not working choose color #42902
  24. Text input on Q platform views results in log spam #40716
  25. [webview_flutter] Cannot input to WebView's TextField on Sharp Aquos Ever SH-04G #39880
  26. [webview_flutter] Keyboard suggestions can be lost #37989
  27. [webview_flutter] not working choose file (input type file) #27924
@blasten blasten added p: webview The WebView plugin platform-android Android applications specifically labels Jul 8, 2020
@blasten blasten added this to the 1.21 - July 2020 milestone Jul 8, 2020
@blasten blasten added c: new feature Nothing broken; request for a new capability P2 labels Jul 8, 2020
@chinmaygarde chinmaygarde added the engine flutter/engine repository. See also e: labels. label Jul 13, 2020
@ishowfun
Copy link

good news!

@tft456
Copy link

tft456 commented Jul 14, 2020

I hope it works

@aaron-chu
Copy link

May I ask when this fix is going to release to the beta or stable channel? I rely on it for solving #41089. Thanks!

@blasten

This comment has been minimized.

@blasten
Copy link
Author

blasten commented Aug 5, 2020

@tvolkert this fixes pretty much all keyboard and a11y related issues.

@rahuldange09
Copy link

@chinmaygarde Thanks for the reply. Can you please confirm one thing? Will it work on my own webview integration created by platform view? Because we are using a payement gateway which has native sdks and they want native webview to be passed in native code, so cannot pass flutter_webview there. That's why i'm asking this.

Thank you

@shenlanchenwei
Copy link

shenlanchenwei commented Sep 18, 2020

这是支持混合合成的功能请求。计划是添加一个新的Dart入口点,该入口点不会更改webview插件的公共API,但会在内部使用此新模式。

完成此操作后,我们将要求人们尝试一下,我们将从他们的经验中学习。

解决的问题:

  1. #19418
  2. #41089
  3. #24585
  4. #50716
  5. #24584
  6. #36478
  7. #52211
  8. #37989
  9. #51254
  10. #23728(支持API级别19)
  11. #50716
  12. #51915
  13. #61280
  14. #55724
  15. #56513
  16. #56515
  17. #61085
  18. #62205
  19. #62547
  20. #58943
  21. #56361
  22. #42902
  23. #40716
  24. #39880
  25. #37989
  26. #27924

When the text box is empty, long press will not display the paste

@blasten blasten added the waiting for PR to land (fixed) A fix is in flight label Sep 21, 2020
@blasten
Copy link
Author

blasten commented Sep 21, 2020

@pcsosinski any news on the 1.22 release? The plugin PR is waiting on the branch cut, so it can be merged.
cc @chinmaygarde

@blasten
Copy link
Author

blasten commented Sep 21, 2020

ETA for 1.22 is 9/28.

@pcsosinski
Copy link

is the only that has to happen to close this is for 1.22 to be stable and the PR be merged?

@blasten
Copy link
Author

blasten commented Sep 21, 2020

is the only that has to happen to close this is for 1.22 to be stable and the PR be merged?

that's correct.

@bparrishMines
Copy link
Contributor

Reopening since the PR was reverted: flutter/plugins#3066

@bparrishMines bparrishMines reopened this Sep 21, 2020
@Sunbreak
Copy link
Contributor

Sunbreak commented Sep 27, 2020

Reopening since the PR was reverted: flutter/plugins#3066

Is there any blocker issue? e.g. #66764

@shenlanchenwei
Copy link

shenlanchenwei commented Sep 28, 2020

Is there any progress?

@tvolkert
Copy link
Contributor

Re-application in flutter/plugins#3067

@chinmaygarde
Copy link
Member

@bparrishMines Can you update the milestone for this issue? The re-land has not landed.

@bparrishMines
Copy link
Contributor

@blasten @chinmaygarde Is Sept. 30 not the correct milestone?

@blasten blasten added P1 High-priority issues at the top of the work list and removed P2 labels Sep 29, 2020
@blasten blasten moved this from In Progress to Done in Launch Platform Views in 1.22 Oct 1, 2020
@yexiaodong
Copy link

how to use choose file (input type file)?

@Sunbreak
Copy link
Contributor

how to use choose file (input type file)?

#27924

@yexiaodong
Copy link

how to use choose file (input type file)?

#27924
except #27924. how to uses hybrid composition?(#61133)

@Sunbreak
Copy link
Contributor

PLEASE Google before you ask
Screen Shot 2020-12-31 at 5 47 16 AM

@github-actions
Copy link

github-actions bot commented Aug 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: platform-views Embedding Android/iOS views in Flutter apps c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. p: webview The WebView plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically waiting for PR to land (fixed) A fix is in flight