Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url_launcher_web] Remove dependency in platform_detect package... #66385

Closed
ditman opened this issue Sep 22, 2020 · 1 comment · Fixed by flutter/plugins#3071
Closed

[url_launcher_web] Remove dependency in platform_detect package... #66385

ditman opened this issue Sep 22, 2020 · 1 comment · Fixed by flutter/plugins#3071
Assignees
@ditman
Labels
a: null-safety Support for the Dart's team new null safety feature p: url_launcher Plugin to launch external applications P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically
Projects
Flutter Web Plugins

Comments

@ditman
Copy link
Member

ditman commented Sep 22, 2020

In preparation for null safety, remove the dependency in platform_detect so the url_launcher_web plugin is more self contained.

(This dependency can be added again, once platform_detect and its dependencies migrate to be strict null-safe)
@ditman ditman added plugin platform-web Web applications specifically p: url_launcher Plugin to launch external applications a: null-safety Support for the Dart's team new null safety feature P2 Important issues not at the top of the work list labels Sep 22, 2020
@ditman ditman self-assigned this Sep 22, 2020
@ditman ditman added this to Not Started in Flutter Web Plugins via automation Sep 22, 2020
@blasten blasten mentioned this issue Sep 22, 2020
Closed
@ditman ditman mentioned this issue Sep 22, 2020
Merged
12 tasks
Flutter Web Plugins automation moved this from Not Started to Done Sep 23, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ditman ditman

Labels
a: null-safety Support for the Dart's team new null safety feature p: url_launcher Plugin to launch external applications P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically
Projects
Flutter Web Plugins
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[url_launcher_web] Remove package:platform_detect ditman/flutter-plugins
2 participants
@ditman @pedromassangocode