Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 22, 2020

Description

This change removes the dependency that url_launcher_web has in package:platform_detect to achieve a null-safe gallery app.

It also migrates the unit tests to run with flutter drive, instead of flutter test with --platform.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman requested review from blasten and cyanglaz September 22, 2020 23:05
@ditman ditman requested a review from mklim as a code owner September 22, 2020 23:05
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the dependency drop

@ditman ditman merged commit c59ea16 into flutter:master Sep 23, 2020
@ditman ditman deleted the remove-platform-detect branch September 23, 2020 20:47
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
This change removes the dependency that url_launcher_web has in package:platform_detect to achieve a null-safe gallery app.

It also migrates the unit tests to run with flutter drive, instead of flutter test with --platform.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
This change removes the dependency that url_launcher_web has in package:platform_detect to achieve a null-safe gallery app.

It also migrates the unit tests to run with flutter drive, instead of flutter test with --platform.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
This change removes the dependency that url_launcher_web has in package:platform_detect to achieve a null-safe gallery app.

It also migrates the unit tests to run with flutter drive, instead of flutter test with --platform.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[url_launcher_web] Remove dependency in platform_detect package...
3 participants