Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android SDK 24 can lead to crashes with devices and Macs, but flutter tool says 24 is OK #7588

Closed
sethladd opened this issue Jan 23, 2017 · 8 comments · Fixed by #8462
Closed

Android SDK 24 can lead to crashes with devices and Macs, but flutter tool says 24 is OK #7588

sethladd opened this issue Jan 23, 2017 · 8 comments · Fixed by #8462
Assignees
@johnmccutchan
Labels
t: flutter doctor Problem related to the "flutter doctor" tool
Milestone
1½: March 8

Comments

@sethladd
Copy link
Contributor

We diagnosed a problem with crashing from device+flutter+mac. After the user upgraded to Android SDK 25, the crashes stopped. See #7332 (comment)

We might want to change flutter tool to prompt the user to upgrade to Android 25. Right now, flutter tool says 24 is OK.
@sethladd sethladd added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 23, 2017
@sethladd sethladd mentioned this issue Jan 23, 2017
Closed
@sethladd
Copy link
Contributor Author

I confirmed with our user that once he upgraded to Android SDK 25, his crashes went away.

We recommend that flutter doctor suggest the user upgrade to 25.

Are we aware of a reason to continue to prefer 24?

@sethladd
Copy link
Contributor Author

cc @abarth or @jason-simmons might know some background here...

@sethladd sethladd added this to the 2: Make Early Adopters happy milestone Feb 8, 2017
@sethladd
Copy link
Contributor Author

sethladd commented Feb 8, 2017

Hi. This might help avoid issues for new users on macs. If this is easy, can we do this by/before March 8th ?

@abarth
Copy link
Contributor

abarth commented Feb 8, 2017

I'm not aware of any reason to prefer SDK 24.

@eseidelGoogle
Copy link
Contributor

Sounds like a simple fix to flutter doctor:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/android_workflow.dart#L15
Looks like we check a bunch of versions, but not sure we require one yet.

@eseidelGoogle eseidelGoogle added the t: flutter doctor Problem related to the "flutter doctor" tool label Feb 9, 2017
@Hixie Hixie modified the milestones: 1: Top Customer Requests, 1.5: March 8 Feb 17, 2017
@mit-mit
Copy link
Member

mit-mit commented Feb 28, 2017

@johnmccutchan are you looking at this one?

@mit-mit mit-mit removed the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 28, 2017
@johnmccutchan johnmccutchan mentioned this issue Feb 28, 2017
Merged
2 tasks
@johnmccutchan
Copy link
Contributor

#8462

@johnmccutchan johnmccutchan self-assigned this Feb 28, 2017
This was referenced Jan 30, 2019
Merged
Closed
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnmccutchan johnmccutchan

Labels
t: flutter doctor Problem related to the "flutter doctor" tool
Projects
None yet
Milestone
1½: March 8
Development

Successfully merging a pull request may close this issue.

Request the user upgrade if the Android SDK version is 24
6 participants
@sethladd @abarth @johnmccutchan @Hixie @eseidelGoogle @mit-mit