Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dependency on cppwinrt on Windows Web Engine shard #81992

Closed
2 tasks done
cbracken opened this issue May 6, 2021 · 3 comments
Closed
2 tasks done

Eliminate dependency on cppwinrt on Windows Web Engine shard #81992

cbracken opened this issue May 6, 2021 · 3 comments
Assignees
@cbracken
Labels
platform-windows Building on or for Windows specifically team-infra Owned by Infrastructure team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Comments

@cbracken
Copy link
Member

cbracken commented May 6, 2021 •
edited

cppwinrt.exe is used as a gclient hook on Windows. It's used to generate WinRT C++ header libraries used in the Windows embedders on the Windows host and UWP shards. I don't believe it's necessary on the Windows Web Engine shard.

To do:

  1. Verify whether cppwinrt is used by any part of the build on the Windows Web Engine shard
  2. If not, change the condition for the Generate winrt headers step from download_windows_deps to something more specific.
@cbracken cbracken added platform-windows Building on or for Windows specifically team-infra Owned by Infrastructure team labels May 6, 2021
@christopherfujino christopherfujino mentioned this issue May 6, 2021
Closed
10 tasks
cbracken added a commit to cbracken/flutter_recipes that referenced this issue May 9, 2021
@cbracken
Enable long paths on Windows web engine bots
1c7f362 
By default, our Windows bots don't have long path support enabled and
thus, are limited to paths with a maximum of 260 characters. This breaks
some tooling that relies on files with longer paths; for example, some
parts of the Windows SDK -- in particular .winmd files under the SDK's
References directory, which we make use of while generating WinRT header
files with the cppwinrt tool.

See also: flutter/flutter#81992

Bug: flutter/flutter#82058
Change-Id: Ib9ee632e957a603b871779dc10554b1092184c0e
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/13301
Commit-Queue: Godofredo Contreras <godofredoc@google.com>
Commit-Queue: Chris Bracken <cbracken@google.com>
Reviewed-by: Godofredo Contreras <godofredoc@google.com>
@godofredoc
Copy link
Contributor

@cbracken is this complete?

@godofredoc godofredoc added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 2, 2023
@cbracken cbracken self-assigned this Mar 3, 2023
@cbracken
Copy link
Member Author

cbracken commented Mar 3, 2023

Oh wow - thanks for the reminder! It is, indeed complete and has been for about a year!

WinRT usage was eliminated in the following patches:

@cbracken cbracken closed this as completed Mar 3, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cbracken cbracken

Labels
platform-windows Building on or for Windows specifically team-infra Owned by Infrastructure team waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbracken @godofredoc