Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Flutter on larger aspect ratios for new Android flagship devices #9234

Closed
sethladd opened this issue Apr 5, 2017 · 9 comments
Closed
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically

Comments

@sethladd
Copy link
Contributor

sethladd commented Apr 5, 2017

Tracking issue.

From https://android-developers.googleblog.com/2017/03/update-your-app-to-take-advantage-of.html

"To deliver more engaging viewing experiences to their users, many Android OEMs are experimenting with new, super widescreen smartphones. Samsung has just announced a new flagship device, the Samsung Galaxy S8, featuring a new display format with an aspect ratio of 18.5:9. At the Mobile World Congress earlier this year, LG also launched their new flagship device, the LG G6, with an expanded screen aspect ratio of 18:9."

and

"We recommend that you design your app to support aspect ratios of 2.1 or higher. "

Should we test Flutter's default layout systems and Material Scaffold and widgets performs as expected for aspect rations of 2.1 or higher?

@sethladd sethladd added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. platform-android Android applications specifically labels Apr 5, 2017
@eseidelGoogle
Copy link
Contributor

I'm not sure there is a ton to do here. @jason-simmons planned to test our O compatibility, so this could fall under that if there is an option to get this resolution from an Android Emulator today, or an existing device we could test on.

Otherwise @Hixie would know if we expect problems here from the framework side.

@eseidelGoogle
Copy link
Contributor

From the linked announcement looks like yes, there are two devices shipping with a 2:1 screen ratio. So it should be possible to pull them up in an Android Emulator. I don't anticipate any problems for Flutter with either.

@eseidelGoogle
Copy link
Contributor

I don't think there is anything really for us to do here. Unless someone is aware of Android-specific affordances which we consider implementing in our Framework for these devices? (i.e. how drawers are always open on tablets in landscape, etc.)

@eseidelGoogle eseidelGoogle added this to the 5: Make Hixie proud milestone Apr 12, 2017
@sethladd
Copy link
Contributor Author

If there's no built-in assumptions in our framework that would prohibit Flutter's default assumptions re: material and layouts from "just working" in a 2:1 screen, then we can close this.

I remember we had some assumptions/defaults that don't work great on a tablet, so I wanted to see how we're doing with 2:1.

I think the minimum is to open an emulator, set to 2:1, and load up the gallery and click around (and set to landscape :)

@txthinking
Copy link

txthinking commented Nov 12, 2017

I use Material Scaffold in my Android app, it works well on many devices. But on Samsung Galaxy S8 and Samsung Galaxy S8+, it shows only a blank page.

@aletorrado
Copy link

I don't know if its related to Material Scaffold or something about the Flutter engine, but in my Galaxy S8 it's showing only a 9:16 viewport, centered in the device 9:18.5 screen. This is obviously a deal breaker right now with almost every android phone being shipped with ultrawide displays.

Is this fixable at the moment in any way?

@eseidelGoogle
Copy link
Contributor

Perhaps there are specific AndroidManifest.xml settings to make to tell the app to use the full screen? @jason-simmons might know.

@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@cbracken
Copy link
Member

We've had several issues on the S8, in particular Chinese market versions of the S8, but it's unclear to me that there's anything actionable from a framework or device support point of view that we're specifically missing for widescreen devices.

I encourage anyone experiencing device-specific bugs with the S8 (or any other phone) to file a new bug though. Closing this in the absence of specific action items.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically
Projects
None yet
Development

No branches or pull requests

6 participants