[flutter_tool] Adds --enable-impeller flag to the run command #100835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
zanderso
force-pushed
the
enable-impeller-flag
branch
from
626ac1e
to
6677b03
Compare
| @@ -140,7 +140,15 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment | |||
| 'startup. By default this is main(List<String> args). Specify ' | |||
| 'this option multiple times each with one argument to pass ' | |||
| 'multiple arguments to the Dart entrypoint. Currently this is ' | |||
| 'only supported on desktop platforms.' | |||
| 'only supported on desktop platforms.', | |||
There was a problem hiding this comment.
This is probably worth adding as a helper method so it can be added to flutter drive and possibly flutter build ios
There was a problem hiding this comment.
Done. DriveCommand already extends RunCommandBase, so no need to call the helper there.
zanderso
force-pushed
the
enable-impeller-flag
branch
from
6677b03
to
d8dbbc5
Compare
zanderso
force-pushed
the
enable-impeller-flag
branch
from
d8dbbc5
to
ad1a625
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbs it through from the
runcommand line toDebuggingOptionsinto theIOSDevice'sstartAppcall.