Enable use_super_parameters lint
#101074
Merged
Enable use_super_parameters lint
#101074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
documentation
team
16 tasks
goderbauer
force-pushed
the
enable_super_params_lint
branch
3 times, most recently
from
c6d51d5
to
05ff107
Compare
|
test-exempt: is a test |
goderbauer
force-pushed
the
enable_super_params_lint
branch
from
05ff107
to
d8c74b8
Compare
goderbauer
force-pushed
the
enable_super_params_lint
branch
2 times, most recently
from
6f12fc3
to
369990a
Compare
Piinks
reviewed
Apr 7, 2022
| @@ -20,6 +20,8 @@ import 'mixins.dart'; | |||
| /// A DAP Debug Adapter for running and debugging Flutter tests. | |||
| class FlutterTestDebugAdapter extends DartDebugAdapter<FlutterLaunchRequestArguments, FlutterAttachRequestArguments> | |||
| with PidTracker, TestAdapter { | |||
| // TODO(goderbauer): Figure out why super parameters in this class break internal google tests. | |||
There was a problem hiding this comment.
Is there an open issue for this that it can reference?
There was a problem hiding this comment.
There is! Let me find and add it.
goderbauer
force-pushed
the
enable_super_params_lint
branch
from
365f44f
to
39a5f46
Compare
goderbauer
force-pushed
the
enable_super_params_lint
branch
from
39a5f46
to
57d9ef9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#100575
To be submitted after:
use_super_parameters#100905