New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reland] Migrate ListTile
TextTheme TextStyle references to Material 3
#102167
[reland] Migrate ListTile
TextTheme TextStyle references to Material 3
#102167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable. I am curious where the M3 values were coming from. I don't see them anywhere in the spec on https://m3.material.io/. Or is this just migrating from the old M2 textTheme
names to the equivalent M3 names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does indeed look like you were just updating the TextTheme style names that are being used. LGTM. Thx.
0696642
to
1f24d1b
Compare
relands #101900 with
useMaterial3
conditionfixes #102075
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.