Deprecate `toggleableActiveColor` #97972

TahaTesser · 2022-02-07T18:40:34Z

Related #90317 and #91772
Fixes #93709

This PR replacestoggleableActiveColor as it is soon to be deprecated.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

HansMuller

The comments about retaining the stateless widget version of the code should apply to #97973 and #97970 as well.

packages/flutter/lib/src/material/radio_list_tile.dart

HansMuller

This looks like a good start at enabling apps to replace toggleableActiveColor however we're going to need a plan about how to take the next step, i.e. how to migrate existing code. The alternative is to leave toggleableActiveColor intact (as you've done here) rather than deprecating it. Unfortunately, that's unlikely to diminish its use.

packages/flutter/lib/src/material/radio_list_tile.dart

TahaTesser · 2022-03-29T14:54:28Z

@HansMuller @Piinks
toggleableActiveColor is used by widgets like #97970 and #97973

but I went ahead added dart fixes for the first case from #97972 (comment) suggestion.
Couldn't add for the last case, updating radioTheme while checking toggleableActiveColor looks more difficult.

If other widgets that use toggleableActiveColor also get dart fixes then it will add three themes when running dart fix or we can opt for migration guide without dart fix, please let me know what direction seems best to land this.

Thank you

Piinks

@TahaTesser thanks for your patience. :)

If other widgets that use toggleableActiveColor also get dart fixes then it will add three themes when running dart fix or we can opt for migration guide without dart fix, please let me know what direction seems best to land this.

There is actually an optional feature for dart fix. This would allow folks to see optional migrations in the IDE and choose one. The command line fix tool does not apply these, since using the dart fix command is a bulk operation.

In the case of multiple options for migration, you can just add bulkApply: false to the fix rule. That way folks still have guidance, they just have to choose individually.

Here is one that already exists:

flutter/packages/flutter/lib/fix_data.yaml

Line 503 in 35b18ba

# Changes made in https://github.com/flutter/flutter/pull/86198

TahaTesser · 2022-04-06T14:37:47Z

Hey @Piinks
Thank you so much for your comment!

In the case of multiple options for migration, you can just add bulkApply: false to the fix rule. That way folks still have guidance, they just have to choose individually.

I have added other widgets that use toggleableActiveColor in the PR and dart fixes for them with bulkApply: false. (this will make it easier to review changes or revert if needed since deprecation changes are in this PR too)

There are slight golden changes due to CheckBox, Switch, Radio now using ColorScheme.secondary, it is a slightly less blue default color.

Please let me know if I can make any more changes

flutter-dashboard · 2022-04-06T14:59:44Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #97972 at sha 7b0cd71c8ec58bb2c86add492c49e35ac94cfec2

Piinks

The golden file changes look ok to me, can you update to pass the tests here? I'll run it through google testing after that to check if customers are affected. Thank you!

dev/integration_tests/flutter_gallery/lib/gallery/themes.dart

packages/flutter/test_fixes/material.dart.expect

Piinks · 2022-08-02T14:21:56Z

It looks like the only difference between Expected/Actual in CI is white space. I thought dart fix was supposed to ignore whitespace.. let me inquire with the dart team.

TahaTesser · 2022-08-02T14:27:15Z

QQ - did you merge or rebase?

Resolved conflicts and rebased.

Piinks · 2022-08-02T14:32:44Z

Ok so it looks like the Actual is not formatted properly because there are extra commas being inserted:

// Changes made in https://github.com/flutter/flutter/pull/97972
...
 ),, radioTheme: RadioThemeData(
...
 ),, switchTheme: SwitchThemeData(
...
 ),, radioTheme: RadioThemeData(
...
 ),, switchTheme: SwitchThemeData(
...
 ),, radioTheme: RadioThemeData(
...
 ),, switchTheme: SwitchThemeData(
...
 ),, radioTheme: RadioThemeData(
...
 ),, switchTheme: SwitchThemeData(
 ...
 ),, radioTheme: RadioThemeData(
...
 ),, switchTheme: SwitchThemeData(
 ...
 ),, radioTheme: RadioThemeData(
 ...
 ),, switchTheme: SwitchThemeData(
...

It looks like dart-lang/sdk#49065 was fixed and rolled in since your last update, so that may be the cause. I am checking the places where the commas are in your fix rule, they should not be necessary anymore. I do not know why it would pass locally though. This PR is pretty old so you may have something cached locally that is out of sync with CI.

TahaTesser · 2022-08-02T14:37:42Z

This PR is pretty old so you may have something cached locally that is out of sync with CI.

Let me try a different machine, where I recently Installed Flutter on it.

Piinks

I will commit these and check CI

packages/flutter/lib/fix_data.yaml

Piinks

Oh, I do not have permission on this PR to modify it. Can you give permission or commit these changes below? I'd like to get this landed quickly. Customer code is constantly changing internally and it could be blocked again.

TahaTesser · 2022-08-02T14:53:08Z

I can confirm it's the cache issue. The test fails on a different machine locally.

Can you give permission or commit these changes below?

I will make the changes.

Piinks · 2022-08-02T14:59:14Z

Fab! Thank you for being so attentive to this. We will both celebrate this landing for sure!

Piinks

Hold for final checks, I am running this through internal tests one. last. time. 🍾

Piinks · 2022-08-02T16:39:00Z

Is it passing locally for you again? It is still failing here, although differently. Checking the diff now.

packages/flutter/test_fixes/material.dart.expect

TahaTesser · 2022-08-02T17:53:02Z

@Piinks
Finally green! :)

Piinks · 2022-08-02T17:59:02Z

Hooray! Internal tests are running right now one last time, and then we can merge

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (#108744) * Fix lerp to eccentric circle. (#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (#108751) * Sync with flutter/.github#13 (#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (#108755) * clean-up analysis_options.yaml (#108747) * Fix ExpansionTile shows children background when expanded (#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (#108757) * Enable conditional_uri_does_not_exist (#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (#108466) (#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (#108825) * Loupe Android + iOS (#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (#108820) * Deprecate `toggleableActiveColor` (#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (#108833) * fix noop toString() diagnostics (#108836) * [flutter_tools] Migrate more tool tests to null-safety (#108639) * Revert "Fix ExpansionTile shows children background when expanded" (#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (#104088) * Update documentation to match implementation (#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." #108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862)" (#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (#108899) * [flutter_test] Add flag to send device pointer events to the framework (#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (#108903) * fix flutter not finding custom device (#108884) * Force a11y services to off for complex_layout_semantics_perf test (#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (#108507) * [macOS] Use editing intents from engine (#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (#108776) * Roll pub packages (#108919) * [flutter_test] perf: find.ancestor (#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (#108923) * Remove some outdated ignores from framework (#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (#108925) * Clean up ScrollbarPainter (#107179) * Remove outdated ignores (#108924) * Add more logs to diagnose Gold flake (#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Tomasz Gucio <72562119+tgucio@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Ian Hickson <ian@hixie.ch> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com> Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: xubaolin <xubaolin@oppo.com> Co-authored-by: Anthony Oleinik <48811365+antholeole@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Danny Tuppeny <danny@tuppeny.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: parkershepherd <me@parkershepherd.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Jia Hao <jiahaog@users.noreply.github.com> Co-authored-by: Hannes Winkler <hanneswinkler2000@web.de> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Pascal Welsch <pascal@welsch.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (flutter#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (flutter#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (flutter#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (flutter#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (flutter#108744) * Fix lerp to eccentric circle. (flutter#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (flutter#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (flutter#108751) * Sync with flutter/.github#13 (flutter#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (flutter#108755) * clean-up analysis_options.yaml (flutter#108747) * Fix ExpansionTile shows children background when expanded (flutter#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (flutter#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (flutter#108757) * Enable conditional_uri_does_not_exist (flutter#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (flutter#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (flutter#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (flutter#108466) (flutter#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (flutter#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (flutter#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (flutter#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (flutter#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (flutter#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (flutter#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (flutter#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (flutter#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (flutter#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (flutter#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (flutter#108825) * Loupe Android + iOS (flutter#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (flutter#108820) * Deprecate `toggleableActiveColor` (flutter#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (flutter#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (flutter#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (flutter#108833) * fix noop toString() diagnostics (flutter#108836) * [flutter_tools] Migrate more tool tests to null-safety (flutter#108639) * Revert "Fix ExpansionTile shows children background when expanded" (flutter#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (flutter#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (flutter#104088) * Update documentation to match implementation (flutter#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." flutter#108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (flutter#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (flutter#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (flutter#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (flutter#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (flutter#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (flutter#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862)" (flutter#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (flutter#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (flutter#108899) * [flutter_test] Add flag to send device pointer events to the framework (flutter#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (flutter#108903) * fix flutter not finding custom device (flutter#108884) * Force a11y services to off for complex_layout_semantics_perf test (flutter#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (flutter#108507) * [macOS] Use editing intents from engine (flutter#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (flutter#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (flutter#108776) * Roll pub packages (flutter#108919) * [flutter_test] perf: find.ancestor (flutter#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (flutter#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (flutter#108923) * Remove some outdated ignores from framework (flutter#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (flutter#108925) * Clean up ScrollbarPainter (flutter#107179) * Remove outdated ignores (flutter#108924) * Add more logs to diagnose Gold flake (flutter#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Tomasz Gucio <72562119+tgucio@users.noreply.github.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: Ian Hickson <ian@hixie.ch> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com> Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: xubaolin <xubaolin@oppo.com> Co-authored-by: Anthony Oleinik <48811365+antholeole@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Danny Tuppeny <danny@tuppeny.com> Co-authored-by: Phil Quitslund <pq@users.noreply.github.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: parkershepherd <me@parkershepherd.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: Jia Hao <jiahaog@users.noreply.github.com> Co-authored-by: Hannes Winkler <hanneswinkler2000@web.de> Co-authored-by: Matej Knopp <matej.knopp@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: Pascal Welsch <pascal@welsch.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This PR is to remove deprecated ThemeData.toggleableActiveColor. These parameters are made obsolete in #97972. Part of #111080

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 7, 2022

guidezpl requested a review from HansMuller February 8, 2022 08:00

HansMuller reviewed Feb 8, 2022

View reviewed changes

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

TahaTesser commented Feb 8, 2022

View reviewed changes

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

TahaTesser force-pushed the radiolisttile_active_color_theme branch from 5ab1f77 to 4e60068 Compare February 8, 2022 21:53

TahaTesser requested a review from HansMuller February 8, 2022 21:59

This comment was marked as resolved.

Sign in to view

HansMuller reviewed Feb 24, 2022

View reviewed changes

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

TahaTesser force-pushed the radiolisttile_active_color_theme branch from ba05da3 to 96203f3 Compare February 25, 2022 11:35

TahaTesser requested a review from HansMuller February 25, 2022 21:12

HansMuller reviewed Feb 26, 2022

View reviewed changes

packages/flutter/lib/src/material/radio_list_tile.dart Outdated Show resolved Hide resolved

TahaTesser requested a review from HansMuller March 9, 2022 19:12

TahaTesser force-pushed the radiolisttile_active_color_theme branch from 1172d01 to 4ab6406 Compare March 29, 2022 13:31

TahaTesser requested a review from Piinks March 29, 2022 14:54

Piinks reviewed Apr 5, 2022

View reviewed changes

TahaTesser force-pushed the radiolisttile_active_color_theme branch from f0179e5 to 4a97867 Compare April 6, 2022 11:51

TahaTesser requested a review from Piinks April 6, 2022 14:37

TahaTesser changed the title ~~RadioListTile: Replace toggleableActiveColor with RadioTheme color property~~ Deprecate toggleableActiveColor Apr 6, 2022

flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. c: tech-debt Technical debt, code quality, testing, etc. labels Apr 6, 2022

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 6, 2022

Piinks reviewed Apr 7, 2022

View reviewed changes

dev/integration_tests/flutter_gallery/lib/gallery/themes.dart Show resolved Hide resolved

packages/flutter/test_fixes/material.dart.expect Outdated Show resolved Hide resolved

This was referenced Apr 9, 2022

CheckboxListTile: Replace toggleableActiveColor with CheckboxTheme color property #97970

Closed

SwitchListTile: Replace toggleableActiveColor with SwitchTheme color property #97973

Closed

Piinks reviewed Aug 2, 2022

View reviewed changes

Update commas

9c45292

Piinks approved these changes Aug 2, 2022

View reviewed changes

Piinks reviewed Aug 2, 2022

View reviewed changes

packages/flutter/test_fixes/material.dart.expect Outdated Show resolved Hide resolved

fix commas

018bc17

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022

auto-submit bot merged commit 5282952 into flutter:master Aug 2, 2022

keyonghan mentioned this pull request Aug 2, 2022

"Skia Gold received an unapproved image in post-submit" failures incorrectly reported as flaky #105915

Open

TahaTesser deleted the radiolisttile_active_color_theme branch August 3, 2022 06:59

engine-flutter-autoroll mentioned this pull request Aug 3, 2022

Roll Flutter from 708d2121cbcf to 183d3e410102 (24 revisions) flutter/packages#2407

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2022

52829523d Deprecate toggleableActiveColor (flutter/flutter#97972)

10851c3

engine-flutter-autoroll mentioned this pull request Aug 3, 2022

Roll Flutter from ac1aa511ca94 to 183d3e410102 (46 revisions) flutter/plugins#6177

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 3, 2022

5282952 Deprecate toggleableActiveColor (flutter/flutter#97972)

fd84f46

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Deprecate toggleableActiveColor (flutter#97972)

8f2385e

Piinks mentioned this pull request Sep 15, 2022

Add missing deprecation notice for toggleableActiveColor #111707

Merged

8 tasks

TahaTesser mentioned this pull request Sep 23, 2022

Migrate RadioListTile, SwitchListTile and CheckboxListTile to use component theme #97965

Closed

QuncCccccc mentioned this pull request Feb 26, 2024

Remove toggleableActiveColor from ThemeData #144178

Merged

9 tasks

auto-submit bot pushed a commit that referenced this pull request Feb 29, 2024

Remove toggleableActiveColor from ThemeData (#144178)

1349c59

This PR is to remove deprecated ThemeData.toggleableActiveColor. These parameters are made obsolete in #97972. Part of #111080

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate `toggleableActiveColor` #97972

Deprecate `toggleableActiveColor` #97972

TahaTesser commented Feb 7, 2022 •

edited

HansMuller left a comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

HansMuller left a comment

TahaTesser commented Mar 29, 2022

Piinks left a comment

TahaTesser commented Apr 6, 2022

flutter-dashboard bot commented Apr 6, 2022

Piinks left a comment

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022

Piinks left a comment

Piinks left a comment

TahaTesser commented Aug 2, 2022

Piinks commented Aug 2, 2022

Piinks left a comment

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022 •

edited

Piinks commented Aug 2, 2022

Deprecate toggleableActiveColor #97972

Deprecate toggleableActiveColor #97972

Conversation

TahaTesser commented Feb 7, 2022 • edited

Pre-launch Checklist

HansMuller left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

HansMuller left a comment

Choose a reason for hiding this comment

TahaTesser commented Mar 29, 2022

Piinks left a comment

Choose a reason for hiding this comment

TahaTesser commented Apr 6, 2022

flutter-dashboard bot commented Apr 6, 2022

Piinks left a comment

Choose a reason for hiding this comment

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022

Piinks left a comment

Choose a reason for hiding this comment

Piinks left a comment

Choose a reason for hiding this comment

TahaTesser commented Aug 2, 2022

Piinks commented Aug 2, 2022

Piinks left a comment

Choose a reason for hiding this comment

Piinks commented Aug 2, 2022

TahaTesser commented Aug 2, 2022 • edited

Piinks commented Aug 2, 2022

Deprecate `toggleableActiveColor` #97972

Deprecate `toggleableActiveColor` #97972

TahaTesser commented Feb 7, 2022 •

edited

TahaTesser commented Aug 2, 2022 •

edited