New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift and Kotlin templates #10259
Add Swift and Kotlin templates #10259
Conversation
Fixes #7312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but could we maybe keep all the files that are identical (icons, etc.) in a common directory?
So you'd have:
ios.tmpl/
-- files shared between Obj-C and Swift templates
ios-objc.tmpl/
-- Obj-C-specific files
ios-swift.tmpl/
-- Swift-specific files
And similar for Android. I think that should work with the current code, and we'd avoid having several copies of especially the binary files.
I wonder if we could abbreviate to just: |
@jakobr-google Yes, good point. @mit-mit There are some minor wrinkles with the simpler
All minor objections of course (on the other hand, people need to write |
We might also consider abbreviated forms of the long-hand options, e.g. |
Yes, that sounds like a great compromise! |
Oh, no. We are not allowed to have two-letter abbreviations. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks so much!
Go modern with
Default languages are
objc
andjava
.