Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swift in ios template project #7312

Closed
mikemimik opened this issue Dec 26, 2016 · 9 comments
Closed

Support Swift in ios template project #7312

mikemimik opened this issue Dec 26, 2016 · 9 comments
Assignees
@mravn-google
Labels
p: tooling Affects the flutter_plugin_tools package package flutter/packages repository. See also p: labels.
Milestone
3: Current Milestone

Comments

@mikemimik
Copy link
Contributor

As Swift is the future of development with any Apple product, I'd like to know if the ios template that is generated from flutter create could be a swift template rather than an obj-c template.

The code readability of swift in substantially higher that obj-c and seeing as how one of flutters goals is to make development across platforms simple, readability is an easy way to help with simplicity.
@sethladd
Copy link
Contributor

I like this idea. I personally find myself able to read and understand Swift, but not ObjC.

@mit-mit
Copy link
Member

mit-mit commented Dec 29, 2016 •
edited

I like it too; Swift is a lot easier to read.

But for plugins / native interop purposes we likely will need to support both. AFAIK that should be possible, as iOS supports projects with both using "mix and match":
https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html

@sethladd
Copy link
Contributor

sethladd commented Jan 3, 2017

@mit-mit if we change the output of flutter create to use Swift, how would that impact plugins?

(agreed that our plugins should support user code written in both objc and swift)

@sethladd sethladd added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 3, 2017
@mit-mit
Copy link
Member

mit-mit commented Jan 4, 2017

We think it will be fine, but we need to do more work to confirm it.

@mit-mit mit-mit added plugin: framework p: tooling Affects the flutter_plugin_tools package and removed tool Affects the "flutter" command-line tool. See also t: labels. plugin labels Feb 2, 2017
@mit-mit mit-mit added this to the 2: Make Early Adopters happy milestone Feb 2, 2017
@eseidelGoogle eseidelGoogle mentioned this issue Feb 21, 2017
Closed
@eseidelGoogle eseidelGoogle added this to Backlog in M2 Mar 21, 2017
@eseidelGoogle eseidelGoogle removed this from Backlog in M2 Mar 21, 2017
@sethladd sethladd modified the milestones: 3: Make conferences happy, 2: Make Early Adopters happy Mar 21, 2017
@mit-mit
Copy link
Member

mit-mit commented Mar 27, 2017

Changing this to supporting Swift as an option, in addition to OjbC. This could be something like flutter create -swift myapp

@mit-mit mit-mit changed the title Request: convert ios template project from obj-c to swift Support Swift in ios template project Mar 27, 2017
@rxlabz
Copy link
Contributor

rxlabz commented Apr 18, 2017 •
edited

I suppose it's planned, but an option for swift plugin template like flutter create --plugin -swift myplugin would also be handy.

@eseidelGoogle
Copy link
Contributor

@rxlabz wrote one btw: https://github.com/rxlabz/FlutterSwiftPlugin-template

@eseidelGoogle eseidelGoogle mentioned this issue May 17, 2017
Closed
This was referenced May 17, 2017
Closed
Merged
@mravn-google mravn-google self-assigned this May 22, 2017
@mravn-google mravn-google mentioned this issue May 22, 2017
Merged
@Hixie Hixie added the plugin label May 23, 2017
@mravn-google
Copy link
Contributor

Closed per #10259

amirh pushed a commit to amirh/flutter that referenced this issue Dec 28, 2018
Roll engine to f0a1d6f
7845274 
```
f0a1d6f Roll src/third_party/skia 487132b82826..acc763e8795c (1 commits) (flutter#7318)
f0dd643 Recreate the overlay rendering surfaces if the GrContext was changed. (flutter#7317)
245317a  Reland "Only reject gestures to embedded UIViews when the framework sa (flutter#7315)
be69b07 Roll src/third_party/skia d2fa2eb59f2d..487132b82826 (1 commits) (flutter#7314)
732ea76 Allow dynamic patches without a patch number. (flutter#7309)
20ee4e3 Revert "Only reject gestures to embedded UIViews when the framework says so. (flutter#7307)" (flutter#7313)
28e152f Roll src/third_party/skia cae020ae5f5f..d2fa2eb59f2d (3 commits) (flutter#7312)
7c65290 Roll src/third_party/skia 31c1bf89657f..cae020ae5f5f (1 commits) (flutter#7311)
180d8a7 Roll src/third_party/skia f6e963ef91c2..31c1bf89657f (1 commits) (flutter#7310)
cc9c670 Only reject gestures to embedded UIViews when the framework says so. (flutter#7307)
2fb2b27 Roll src/third_party/skia 3605fde88b2a..f6e963ef91c2 (1 commits) (flutter#7306)
```
amirh added a commit that referenced this issue Dec 28, 2018
@amirh
Roll engine to f0a1d6f (#25849)
63b2daf 
```
f0a1d6f Roll src/third_party/skia 487132b82826..acc763e8795c (1 commits) (#7318)
f0dd643 Recreate the overlay rendering surfaces if the GrContext was changed. (#7317)
245317a  Reland "Only reject gestures to embedded UIViews when the framework sa (#7315)
be69b07 Roll src/third_party/skia d2fa2eb59f2d..487132b82826 (1 commits) (#7314)
732ea76 Allow dynamic patches without a patch number. (#7309)
20ee4e3 Revert "Only reject gestures to embedded UIViews when the framework says so. (#7307)" (#7313)
28e152f Roll src/third_party/skia cae020ae5f5f..d2fa2eb59f2d (3 commits) (#7312)
7c65290 Roll src/third_party/skia 31c1bf89657f..cae020ae5f5f (1 commits) (#7311)
180d8a7 Roll src/third_party/skia f6e963ef91c2..31c1bf89657f (1 commits) (#7310)
cc9c670 Only reject gestures to embedded UIViews when the framework says so. (#7307)
2fb2b27 Roll src/third_party/skia 3605fde88b2a..f6e963ef91c2 (1 commits) (#7306)
```
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this issue Feb 12, 2019
@amirh @kangwang1988
Roll engine to f0a1d6f (flutter#25849)
d329a9c 
```
f0a1d6f Roll src/third_party/skia 487132b82826..acc763e8795c (1 commits) (flutter#7318)
f0dd643 Recreate the overlay rendering surfaces if the GrContext was changed. (flutter#7317)
245317a  Reland "Only reject gestures to embedded UIViews when the framework sa (flutter#7315)
be69b07 Roll src/third_party/skia d2fa2eb59f2d..487132b82826 (1 commits) (flutter#7314)
732ea76 Allow dynamic patches without a patch number. (flutter#7309)
20ee4e3 Revert "Only reject gestures to embedded UIViews when the framework says so. (flutter#7307)" (flutter#7313)
28e152f Roll src/third_party/skia cae020ae5f5f..d2fa2eb59f2d (3 commits) (flutter#7312)
7c65290 Roll src/third_party/skia 31c1bf89657f..cae020ae5f5f (1 commits) (flutter#7311)
180d8a7 Roll src/third_party/skia f6e963ef91c2..31c1bf89657f (1 commits) (flutter#7310)
cc9c670 Only reject gestures to embedded UIViews when the framework says so. (flutter#7307)
2fb2b27 Roll src/third_party/skia 3605fde88b2a..f6e963ef91c2 (1 commits) (flutter#7306)
```
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mravn-google mravn-google

Labels
p: tooling Affects the flutter_plugin_tools package package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
3: Current Milestone
Development

No branches or pull requests
8 participants
@sethladd @Hixie @rxlabz @mikemimik @eseidelGoogle @mit-mit @jakobr-google @mravn-google