Refactor listen in terms of start. #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter#1034, at least for start and listen.
This was referenced Dec 29, 2015
|
lgtm |
Hixie
added a commit
that referenced
this pull request
Dec 29, 2015
Refactor listen in terms of start.
TahaTesser
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Aug 13, 2020
This patch works by calculating the device's physical orientation from accelerometer data. This is a tricky approach and I'd rather avoid it, but it looks like a necessary evil based on a few reasons. 1. The specific callback we're registering doesn't give us any EXIF data or data on the photo's orientation. https://developer.apple.com/documentation/avfoundation/avcapturephotocapturedelegate/1778647-captureoutput?language=objc 2. There is a better callback to use that does give us this data, but it's only supported on ios 11.0+ and the camera plugin supports 10.0+. https://developer.apple.com/documentation/avfoundation/avcapturephotocapturedelegate/2873949-captureoutput?language=objc 3. There's a straightforward iOS API that's supposed to give the physical device orientation that would normally be perfect for this, but it doesn't work when the UI is locked to portrait mode. https://developer.apple.com/documentation/uikit/uidevice/1620053-orientation?language=objc We've had Android issues in the past based on the Android API we used having this same limitation. fixes flutter#16587
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1034, at least for start and listen.