Use AppBar.systemOverlayStyle to style system navigation bar #104827

bleroux · 2022-05-27T12:22:13Z

Description

AppBar.systemOverlayStyle exposes properties to set system navigation bar style.
Those properties are not applied because the AnnotatedRegion created by an AppBar is on the top of the screen and RenderView does not use the annotated region on the top to style the system navigation bar.

To set the system navigation bar style, Flutter developers should create a second AnnotatedRegion on the bottom of the screen. This is not intuitive as system navigation properties are available when setting AppBar.systemOverlayStyle and this is not convenient, as explained in this comment.

This PR updates how RenderView creates a system overlay style.
Before, it looked up for a top annotated region to style the status bar and a bottom annotated region to style the system navigation bar.
After, if only one of the top or the bottom annotated region is found, it will be used to style the status bar and the system navigation bar. If both are found, it will work as before.

Related Issue

Fixes #104410

Tests

Adds 1 test in material/app_bar_test.dart
Adds 3 tests in rendering/view_chrome_style_test.dart

rydmike · 2022-07-06T23:19:58Z

Would be nice if this could merged.
ping @darrenaustin 😄 💙

rydmike · 2022-09-14T01:11:33Z

Would still be nice to get this reviewed and merged, ping @darrenaustin @HansMuller 😄

packages/flutter/lib/src/rendering/view.dart

a-wallen · 2022-09-21T15:51:15Z

@bleroux I just want to let you know that I'm still looking at this. There seem to be a lot of issues regarding the system navigation bar. I'm wondering if I could get your help gathering all of those issues into one place so that we can see what issues people are having and whether or not these changes are the best solution for a majority of cases. Feel free to message me on Discord (a-wallen)

bleroux · 2022-09-23T13:44:56Z

@a-wallen
Many thanks for your feedback. It’s a complex area so collecting issues related to the system navigation bar is a great way to make progress. For the moment, we can start to list those related issues here (by editing this comment and the list below) and see where it leads us.

My first take is that several issues are related to different Android SDK versions and also Android SystemUIMode (immersive, edgeToEdge,...). And to get further complication some of those issues are device specific.

My second take is that Flutter gives two options to configure the system navigation bar:

An imperative way using SystemChrome
A declarative way (which relies on AnnotatedRegion and calling the imperative API on every frame). It was Introduced by the following PR: Initial implementation of AnnotatedRegion for system chrome #17672 (design described here We should derive the system chrome ui overlay style from a layer #4630 (comment)).

My PR targets the declarative way and it could be considered as a developer experience improvement. Rydmike described this in a very thorough comment: #100027 (comment).

As a starting point, I classified several issues I found using this two categories (imperative vs declarative):

Imperative

[SystemChrome] setting systemNavigationBarColor and statusBarColor to white turns dark #108855
[Android] Edge to Edge should only be offered at a higher API #89774 (great summary of edgeToEdge limitations depending on Android version).
[Android] Streamline Edge-to-Edge and Navigation Bar behavior across Android versions #90098 (lot of good information. Closed because it was splitted in two separate actionable issues: Set Edge-to-Edge to be the default for Android on API 29+ #105714 and [Android] Avoid hidden navigation bar icons #105716
[Android]Switching between immersive and edgeToEdge system UI modes shows black status bar #95403 (edgeToEdge and device specific)
[SystemChrome] setting systemNavigationBarColor and statusBarColor to white turns dark #108855 (device specific)
SystemChrome setSystemUIOverlayStyle failed #59130 (which seems to be a misunderstanding related to an imperative call overridden by the implicit addition of AnnotatedRegion when there is an AppBar).

Declarative

Using systemNavigationBarDividerColor changes statusBarIconBrightness and systemNavigationBarIconBrightness on Android11 #100027 (with many insights from rydmike about what could be done to improve the documentation, partially fixed by Add missing window flags for styling system bars engine#32167)
Flutter SystemUiOverlayStyle does not work with some configurations on Android #76384 (fixed by Add missing window flags for styling system bars engine#32167)
AnnotatedRegion not working on iOS (to set status bar icon color) #54029 (iOS)
systemNavigationBarColor not honoured on Android #104410 (where I commented systemNavigationBarColor not honoured on Android #104410 (comment) after analyzing various issues and leads me to this PR)
systemNavigationBarIconBrightness: Brightness.dark resets to light onResume. #21265 (onResume issue where the proposed solution was to switch to the declarative way, but people seems to be confused by AppBar overridden their values, see systemNavigationBarIconBrightness: Brightness.dark resets to light onResume. #21265 (comment))
Samsung Galaxy S10 System Navigation Bar Icon Brightness Issue #39132 (seems to be the same confusion)

a-wallen · 2022-09-23T20:05:36Z

@bleroux I'm going to follow up on your comment, but before I do I think that we should make an issue called SystemNavigationBar APIs are confusing. If this gets merged, the Github bot will lock this thread. I'd rather have an issue where there can be a conversation around this issue. If enough people give a 👍 on that issue, the team will focus more of their attention to making the API easier to use.

a-wallen

I'm up to speed now, but still not sure that we want this change. For the most part things seem to be working as intended, but are poorly documented.

a-wallen · 2022-09-23T20:46:27Z

packages/flutter/lib/src/rendering/view.dart

+    }
+
+    // If both are not null, the upper provides the status bar properties and the lower provides
+    // the system navigation bar properties.


Readability: Could you provide a brief explanation for why we do this?

Readability: Could you provide a brief explanation for why we do this?

Sorry, do you mean by updating this comment in view.dart or by commenting here on Github?

I think here in view.dart, although the comments explaining top and bottom above are helpful. Maybe just providing an example of why there would be more than one, an upper and a lower?

a-wallen · 2022-09-23T20:48:34Z

packages/flutter/lib/src/services/system_chrome.dart

@@ -558,7 +558,8 @@ class SystemChrome {
  /// it can be hit-tested by the framework. On every frame, the framework will
  /// hit-test and select the annotated region it finds under the status and
  /// navigation bar and synthesize them into a single style. This can be used
-  /// to configure the system styles when an app bar is not used.
+  /// to configure the system styles when an app bar is not used. When an app
+  /// bar is used an annotated region is automatically created.


Explain the combinations behind this. What happens when I set the system style and there's an AppBar.

bleroux · 2022-09-28T14:08:04Z

I'm up to speed now, but still not sure that we want this change. For the most part things seem to be working as intended, but are poorly documented.

IMHO, while improving the documentation will help, it won't make the API less "frustrating" as describe in this comment.

The same comment from @rydmike also explains why it could make sense to argue against this change (but also why this change would be preferable 😄 ) :
"One could argue that this makes sense, since we are defining things for an AppBar that does not really have anything to do with the system navigation bar. On the other hand the properties are there, if they have no impact, they should not exists at all in the used AppBar "systemOverlayStyle" config class. Or at the least it is should be very clearly documented that they have no impact and that you have to set them via an AnnotatedRegion. But why not let them work also via the AppBar?"

I fully agree that "updating the code" vs "updating the documentation" is a valid concern. So before pursuing work on this PR, a decision should be taken.

a-wallen · 2022-09-28T14:26:44Z

it won't make the API less "frustrating" as describe in this comment.

Yes, the api is frustrating!

If it were me, I would want this change, but my opinion doesn't scale to the MANY users that we have 😅.

I asked for a second review by @Piinks during our triage meeting yesterday, she might have better insight. Hopefully we can move things forward that way. And, I agree that you should not put in effort until we've made a decision about this change.

Piinks · 2022-10-07T18:39:23Z

packages/flutter/lib/src/rendering/view.dart

@@ -112,6 +112,11 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
  /// and the hit-test result from the bottom of the screen provides the system
  /// nav bar settings.
  ///
+  /// If there is no AnnotatedRegionLayer on the bottom, the hit-test result


Nit: breadcrumb

Suggested change

/// If there is no AnnotatedRegionLayer on the bottom, the hit-test result

/// If there is no [AnnotatedRegionLayer] on the bottom, the hit-test result

Piinks · 2022-10-07T18:42:23Z

packages/flutter/lib/src/material/app_bar.dart

-    return style.copyWith(statusBarColor: backgroundColor);
+    // For backward compatibility, create an overlay style without system navigation bar settings.
+    return SystemUiOverlayStyle(
+      statusBarColor: style.statusBarColor,


Would we not want to honor backgroundColor anymore?

Good catch! If we pursue work on this PR, I will also try to find why this bug does not break any tests.

I fixed this bug and I added a test as there was no existing test covering this (it is somewhat new because the 'backgroundColor' parameter is non-null only when using Material 3).
Thanks a lot for spotting this!

Piinks

As far as I know, the AppBar intentionally only applies to the status bar (and not the navigation bar) because the AppBar renders into the status bar area. I think the intention is that since the user can set the AppBar to be any color, it will set the status bar overlay style to avoid the status bar time, date etc from being obscured.

Assuming the same style should be applied to the navigation bar gives me pause. There may not be a navigation bar, or the user may be using edge to edge. This could result in the navigation buttons not being visible to the user.

bleroux · 2022-10-10T08:48:21Z

Hey @Piinks!

Assuming the same style should be applied to the navigation bar gives me pause. There may not be a navigation bar, or the user may be using edge to edge. This could result in the navigation buttons not being visible to the user.

Maybe I misread your comment, but this PR only aims to apply AppBar.systemOverlayStyle.systemNavigationBarColor property (and similar navigation bar properties) when the user sets them (from your comment, I understand that you fear that this PR is applying some AppBar.systemOverlayStyle status bar related properties to the navigation bar or tried to compute default values, really sorry if I misread).

For the moment, we get issues filed by users who tried code similar to :

      appBar: AppBar(
        systemOverlayStyle: SystemUiOverlayStyle.light.copyWith(
          systemNavigationBarColor: Colors.green, // ignored
        ),
      ),

As those properties are ignored it leads to frustration (users assume it should work because those properties are documented in SystemUiOverlayStyle and exposed when using completion). And the solution is not obvious, see #104410 (comment) (which is the discussion that leads me to this PR).

If AppBar.systemOverlayStyle is a bad place to set them, ideally, those properties should not be exposed (but this will probably be a breaking change as it might mean changing AppBar.systemOverlayStyle type).

This PR aims to apply those properties without introducing a breaking change and without overriding the values set in a bottom AnnotatedRegion (when there is one).

I wrote this PR some months ago, maybe there are bugs in it (you already find one 😄) or maybe the code is not aligned with the goal I had in mind, but before pursuing work, we (@a-wallen and I) reached the conclusion that a decision should be made on agreeing or not that the goal of this PR is a valid concern.

Piinks · 2022-10-20T21:41:55Z

Hey @bleroux thank you for the additional context! I think this change is ok to make (modulo that one bug 😉 ), we should double check that it is not breaking though. If you would, can you fix the background color, then I'll run this through some extra testing internally to see if anything breaks. 👍

bleroux · 2022-10-21T11:52:40Z

@Piinks Great!
I have updated the PR (and I added one test, see my comment above).

I'll run this through some extra testing internally to see if anything breaks

🤞 🤞 😄

Piinks · 2022-10-21T20:26:30Z

Tests are running, will circle back with results.

Piinks · 2022-10-24T16:30:21Z

Tests passed!

…ce versa)

Piinks

…lutter/flutter#104827)

* 5280135 ecd3c4857 Roll Fuchsia Mac SDK from sNXsQVxntMX8f42LE... to 9Jb1-3tRPQ2ZhpTQC... (flutter/engine#37363) (flutter/flutter#114772) * a6da104 Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (flutter/flutter#114560) * 19c5fc5 0cbdf464c Add Matrix::LookAt (flutter/engine#37361) (flutter/flutter#114786) * c551fe3 4e45cfb4a Roll Fuchsia Mac SDK from 9Jb1-3tRPQ2ZhpTQC... to 5XOj9l5e2wkSpMKT1... (flutter/engine#37369) (flutter/flutter#114789) * a54a46d 6b57fddd1 Bump github/codeql-action from 2.1.29 to 2.1.31 (flutter/engine#37374) (flutter/flutter#114798) * 3c9288c Increase minimum supported macOS version from 10.13 to 10.14 (flutter/flutter#114713) * a1289a4 891d4a357 Roll Skia from c3c31be8729b to 513f0fd34590 (2 revisions) (flutter/engine#37377) (flutter/flutter#114802) * 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813) * 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816) * d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819) * 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821) * 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733) * 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335) * 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497) * 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828) * 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099) * e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833) * 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698) * e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745) * fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836) * 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499) * f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827) * e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757) * 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842) * 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847) * 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826) * 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854) * 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855) * 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450) * a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)

* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813) * 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816) * d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819) * 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821) * 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733) * 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335) * 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497) * 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828) * 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099) * e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833) * 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698) * e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745) * fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836) * 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499) * f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827) * e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757) * 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842) * 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847) * 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826) * 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854) * 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855) * 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450) * a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)

* 5280135 ecd3c4857 Roll Fuchsia Mac SDK from sNXsQVxntMX8f42LE... to 9Jb1-3tRPQ2ZhpTQC... (flutter/engine#37363) (flutter/flutter#114772) * a6da104 Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (flutter/flutter#114560) * 19c5fc5 0cbdf464c Add Matrix::LookAt (flutter/engine#37361) (flutter/flutter#114786) * c551fe3 4e45cfb4a Roll Fuchsia Mac SDK from 9Jb1-3tRPQ2ZhpTQC... to 5XOj9l5e2wkSpMKT1... (flutter/engine#37369) (flutter/flutter#114789) * a54a46d 6b57fddd1 Bump github/codeql-action from 2.1.29 to 2.1.31 (flutter/engine#37374) (flutter/flutter#114798) * 3c9288c Increase minimum supported macOS version from 10.13 to 10.14 (flutter/flutter#114713) * a1289a4 891d4a357 Roll Skia from c3c31be8729b to 513f0fd34590 (2 revisions) (flutter/engine#37377) (flutter/flutter#114802) * 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813) * 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816) * d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819) * 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821) * 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733) * 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335) * 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497) * 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828) * 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099) * e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833) * 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698) * e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745) * fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836) * 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499) * f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827) * e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757) * 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842) * 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847) * 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826) * 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854) * 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855) * 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450) * a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)

* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813) * 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816) * d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819) * 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821) * 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733) * 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335) * 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497) * 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828) * 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099) * e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833) * 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698) * e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745) * fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836) * 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499) * f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827) * e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757) * 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842) * 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847) * 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826) * 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854) * 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855) * 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450) * a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)

…#104827) * Use upper AnnotatedRegion properties when no bottom one found (and vice versa) * Update comments Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>

* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813) * 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816) * d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819) * 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821) * 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733) * 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335) * 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497) * 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828) * 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099) * e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833) * 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698) * e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745) * fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836) * 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499) * f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827) * e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757) * 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842) * 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847) * 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826) * 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854) * 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855) * 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450) * a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 27, 2022

bleroux mentioned this pull request May 27, 2022

systemNavigationBarColor not honoured on Android #104410

Closed

HansMuller requested a review from darrenaustin May 27, 2022 22:00

a-wallen reviewed Sep 14, 2022

View reviewed changes

packages/flutter/lib/src/rendering/view.dart Outdated Show resolved Hide resolved

a-wallen reviewed Sep 14, 2022

View reviewed changes

packages/flutter/lib/src/rendering/view.dart Outdated Show resolved Hide resolved

bleroux force-pushed the fix_set_all_system_ui_overlay_properties_from_app_bar branch from 336fe1a to 3e80fc9 Compare September 14, 2022 12:52

bleroux requested a review from a-wallen September 14, 2022 13:45

a-wallen self-assigned this Sep 20, 2022

darrenaustin removed their request for review September 21, 2022 17:19

a-wallen mentioned this pull request Sep 23, 2022

System Navigation Bar APIs are Confusing #112301

Open

a-wallen reviewed Sep 23, 2022

View reviewed changes

goderbauer requested a review from Piinks September 27, 2022 22:26

Piinks reviewed Oct 7, 2022

View reviewed changes

bleroux force-pushed the fix_set_all_system_ui_overlay_properties_from_app_bar branch from 3e80fc9 to 26b153c Compare October 21, 2022 10:17

bleroux requested a review from Piinks October 21, 2022 11:52

bleroux force-pushed the fix_set_all_system_ui_overlay_properties_from_app_bar branch from 26b153c to f3fb10f Compare November 3, 2022 10:24

bleroux added 2 commits November 3, 2022 21:57

Use upper AnnotatedRegion properties when no bottom one found (and vi…

f408b56

…ce versa)

Update comments

73e8cb2

bleroux force-pushed the fix_set_all_system_ui_overlay_properties_from_app_bar branch from f3fb10f to 73e8cb2 Compare November 3, 2022 20:57

Piinks approved these changes Nov 7, 2022

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2022

auto-submit bot merged commit f1cdfa2 into flutter:master Nov 7, 2022

bleroux deleted the fix_set_all_system_ui_overlay_properties_from_app_bar branch November 8, 2022 07:43

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter from 5ea5a5330169 to a1432a9c5da2 (30 revisions) flutter/packages#2788

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2022

f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (f…

69ad05d

…lutter/flutter#104827)

engine-flutter-autoroll mentioned this pull request Nov 8, 2022

Roll Flutter from a1289a41358d to a1432a9c5da2 (23 revisions) flutter/plugins#6681

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 8, 2022

f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (f…

671d28c

…lutter/flutter#104827)

bleroux mentioned this pull request Dec 12, 2022

Having an AppBar in Scaffold prevents NavigationBar and StatusBar style from changing #61149

Closed

This was referenced Jan 27, 2023

systemNavigationBarIconBrightness: Brightness.dark resets to light onResume. #21265

Closed

Fix CupertinoNavigationBar should create a backward compatible Annota… #119515

Merged

masewo mentioned this pull request Jan 30, 2023

[SystemUiMode.edgeToEdge] systemNavigationBarColor can't be made transparent without breaking older Android versions #119465

Open

This was referenced Jan 31, 2023

systemNavigationBarColor Error After Upgrading from Flutter 3.3 to 3.7 #119131

Closed

Flutter 3.7.0: System navigation bar cannot be displayed translucent in CupertinoPageScaffold #119270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use AppBar.systemOverlayStyle to style system navigation bar #104827

Use AppBar.systemOverlayStyle to style system navigation bar #104827

bleroux commented May 27, 2022 •

edited

Loading

rydmike commented Jul 6, 2022

rydmike commented Sep 14, 2022

a-wallen commented Sep 21, 2022

bleroux commented Sep 23, 2022

a-wallen commented Sep 23, 2022 •

edited

Loading

a-wallen left a comment

a-wallen Sep 23, 2022

bleroux Sep 28, 2022

Piinks Oct 24, 2022

a-wallen Sep 23, 2022

Piinks Oct 24, 2022

bleroux commented Sep 28, 2022

a-wallen commented Sep 28, 2022 •

edited

Loading

Piinks Oct 7, 2022

bleroux Oct 21, 2022

Piinks Oct 7, 2022

bleroux Oct 10, 2022

bleroux Oct 21, 2022

Piinks left a comment

bleroux commented Oct 10, 2022 •

edited

Loading

Piinks commented Oct 20, 2022

bleroux commented Oct 21, 2022 •

edited

Loading

Piinks commented Oct 21, 2022

Piinks commented Oct 24, 2022

Piinks left a comment

	/// If there is no AnnotatedRegionLayer on the bottom, the hit-test result
	/// If there is no [AnnotatedRegionLayer] on the bottom, the hit-test result

Use AppBar.systemOverlayStyle to style system navigation bar #104827

Use AppBar.systemOverlayStyle to style system navigation bar #104827

Conversation

bleroux commented May 27, 2022 • edited Loading

Description

Related Issue

Tests

rydmike commented Jul 6, 2022

rydmike commented Sep 14, 2022

a-wallen commented Sep 21, 2022

bleroux commented Sep 23, 2022

Imperative

Declarative

a-wallen commented Sep 23, 2022 • edited Loading

a-wallen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bleroux commented Sep 28, 2022

a-wallen commented Sep 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Piinks left a comment

Choose a reason for hiding this comment

bleroux commented Oct 10, 2022 • edited Loading

Piinks commented Oct 20, 2022

bleroux commented Oct 21, 2022 • edited Loading

Piinks commented Oct 21, 2022

Piinks commented Oct 24, 2022

Piinks left a comment

Choose a reason for hiding this comment

bleroux commented May 27, 2022 •

edited

Loading

a-wallen commented Sep 23, 2022 •

edited

Loading

a-wallen commented Sep 28, 2022 •

edited

Loading

bleroux commented Oct 10, 2022 •

edited

Loading

bleroux commented Oct 21, 2022 •

edited

Loading