[flutter_tools] re-use findProjectRoot on flutter command #104850

Jasguerrero · 2022-05-27T18:03:08Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino · 2022-05-31T18:18:10Z

packages/flutter_tools/test/commands.shard/hermetic/pub_get_test.dart

@@ -123,3 +150,30 @@ class FakePub extends Fake implements Pub {
      ..writeAsStringSync('{"configVersion":2,"packages":[]}');
  }
 }
+
+class FakePubTargetDirectory extends Fake implements Pub {


What about adding an optional parameter to the FakePub constructor for dartToolDir that defaults to fileSystem.currentDirectory.childDirectory('.dart_tool'), rather than creating a whole new class?

Oh wait, actually, doesn't this already get piped through as the directory parameter to .get()?

Oh wait, actually, doesn't this already get piped through as the directory parameter to .get()?

I do not follow. Do you mean that fileSystem.currentDirectory... is not needed? This syncs are needed for the currentDirectory to be a "valid flutter project"

Ohh I see what you mean yes I can just use the directory instead which is already in the function. Good call

christopherfujino · 2022-06-02T21:14:56Z

packages/flutter_tools/test/commands.shard/hermetic/pub_get_test.dart

+
+    await commandRunner.run(<String>['get', targetDirectory.path]);
+
+    expect(await command.usageValues, const CustomDimensions(


Should we check that .dart_tool/package_config.json got written?

I think you can delete this expectation actually, as its redundant with the previous test

christopherfujino

LGTM!

…utter/flutter#104850)

…lutter/flutter#104850)

…4850)

…lutter/flutter#104850)

…utter/flutter#104850)

re-use findProjectRoot on flutter command

eb7cbcb

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 27, 2022

test for flutter pub get <target_directory>

010642d

Jasguerrero marked this pull request as ready for review May 27, 2022 20:33

Jasguerrero requested a review from christopherfujino May 27, 2022 20:34

Jasguerrero changed the title ~~re-use findProjectRoot on flutter command~~ [flutter_tools] re-use findProjectRoot on flutter command May 27, 2022

christopherfujino reviewed May 31, 2022

View reviewed changes

Use piped directory from get command test

db1f1fa

christopherfujino reviewed Jun 2, 2022

View reviewed changes

expect package.json on target folder

d9fcf6d

christopherfujino approved these changes Jun 3, 2022

View reviewed changes

Jasguerrero added the waiting for tree to go green label Jun 3, 2022

fluttergithubbot merged commit 3da9eee into flutter:master Jun 3, 2022

Jasguerrero deleted the fix_flutter_pub_get_target branch June 3, 2022 22:29

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 889a15eb9df6 to 2e1ebd83b3f6 (6 revisions) flutter/plugins#5910

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 4, 2022

3da9eee [flutter_tools] re-use findProjectRoot on flutter command (fl…

eb83817

…utter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 2e1ebd83b3f6 (173 revisions) flutter/packages#2202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

80738a6

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 7996527b7db8 (174 revisions) flutter/packages#2203

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

4bb2c20

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 81f89aaf6c56 (175 revisions) flutter/packages#2204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

478f320

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

1d81e1e

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

62f4899

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 8294d9e91e39 (183 revisions) flutter/packages#2207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

b241e21

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 1b2ee411aa13 (190 revisions) flutter/packages#2208

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

855b017

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to c181e450c8df (191 revisions) flutter/packages#2209

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

f026001

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 712752d2fb18 (192 revisions) flutter/packages#2211

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

9ff8e1b

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 67a18250b17e (193 revisions) flutter/packages#2212

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

5f42381

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to d5c62438e3e0 (194 revisions) flutter/packages#2213

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

58ae432

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 7, 2022

Roll Flutter from 36fe51524f72 to be0c1bd0f0ce (213 revisions) flutter/packages#2214

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

0ae0a28

…lutter/flutter#104850)

engine-flutter-autoroll mentioned this pull request Jun 7, 2022

Roll Flutter from 36fe51524f72 to 78a0111c2093 (214 revisions) flutter/packages#2215

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

051fc65

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

bb4fcdb

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

98c20a6

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

2e0d476

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

06fecdb

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

cbb4ab8

…lutter/flutter#104850)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

[flutter_tools] re-use findProjectRoot on flutter command (flutter#10…

13ca403

…4850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

3da9eee2f [flutter_tools] re-use findProjectRoot on flutter command (f…

7f558f1

…lutter/flutter#104850)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

3da9eee [flutter_tools] re-use findProjectRoot on flutter command (fl…

621a808

…utter/flutter#104850)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] re-use findProjectRoot on flutter command #104850

[flutter_tools] re-use findProjectRoot on flutter command #104850

Jasguerrero commented May 27, 2022 •

edited

Loading

christopherfujino May 31, 2022 •

edited

Loading

christopherfujino May 31, 2022

Jasguerrero May 31, 2022

Jasguerrero May 31, 2022

christopherfujino Jun 2, 2022

christopherfujino Jun 2, 2022

christopherfujino left a comment


		await commandRunner.run(<String>['get', targetDirectory.path]);

		expect(await command.usageValues, const CustomDimensions(

[flutter_tools] re-use findProjectRoot on flutter command #104850

[flutter_tools] re-use findProjectRoot on flutter command #104850

Conversation

Jasguerrero commented May 27, 2022 • edited Loading

Pre-launch Checklist

christopherfujino May 31, 2022 • edited Loading

Choose a reason for hiding this comment

christopherfujino May 31, 2022

Choose a reason for hiding this comment

Jasguerrero May 31, 2022

Choose a reason for hiding this comment

Jasguerrero May 31, 2022

Choose a reason for hiding this comment

christopherfujino Jun 2, 2022

Choose a reason for hiding this comment

christopherfujino Jun 2, 2022

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

Jasguerrero commented May 27, 2022 •

edited

Loading

christopherfujino May 31, 2022 •

edited

Loading