-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versions to all the dependencies so they are pinned #104867
Add versions to all the dependencies so they are pinned #104867
Conversation
Fyi some of the checks are failing on ambiguous tags. You'll need to use a unique tag |
@CaseyHillers Thanks. I was working on this late and was unable to create a tag. Keyong gave me a version to try though. |
{"dependency": "apple_signing"} | ||
{"dependency": "xcode", "version": "13a233"}, | ||
{"dependency": "gems", "version": "v3.3.14"}, | ||
{"dependency": "apple_signing", "version": "none"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would this be none?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah so I spoke with Drew and there is no version associated with this. And in the recipe there is no check on the version for this dependency so rather than leave it blank I just gave it None. I can replace it with something else if it makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be a well built tool to not need versions :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Updated file to include version for dependencies. * Updated clang version to use github revision.
Description of The Issue Being Addressed
The builder config is fragile when dependencies are not pinned to specific versions. Any upstream changes may cause breakage. We should create a test to validate all .ci.yaml dependencies are pinned. This also requires that we pin specific versions for all dependencies.
Issues Addressed
#101712
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.