Add versions to all the dependencies so they are pinned #104867

ricardoamador · 2022-05-27T22:47:08Z

Description of The Issue Being Addressed

The builder config is fragile when dependencies are not pinned to specific versions. Any upstream changes may cause breakage. We should create a test to validate all .ci.yaml dependencies are pinned. This also requires that we pin specific versions for all dependencies.

Issues Addressed

#101712

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ps_pinned

CaseyHillers · 2022-05-31T14:44:52Z

Fyi some of the checks are failing on ambiguous tags. You'll need to use a unique tag

ricardoamador · 2022-05-31T16:35:39Z

@CaseyHillers Thanks. I was working on this late and was unable to create a tag. Keyong gave me a version to try though.

CaseyHillers · 2022-06-02T13:55:34Z

.ci.yaml

-          {"dependency": "apple_signing"}
+          {"dependency": "xcode", "version": "13a233"},
+          {"dependency": "gems", "version": "v3.3.14"},
+          {"dependency": "apple_signing", "version": "none"}


Why would this be none?

Yeah so I spoke with Drew and there is no version associated with this. And in the recipe there is no check on the version for this dependency so rather than leave it blank I just gave it None. I can replace it with something else if it makes more sense.

Must be a well built tool to not need versions :-)

keyonghan

LGTM

…utter/flutter#104867)

…ter/flutter#104867)

…utter/flutter#104867)

* Updated file to include version for dependencies. * Updated clang version to use github revision.

…utter/flutter#104867)

…ter/flutter#104867)

ricardoamador added 2 commits May 26, 2022 10:54

Updated file to include version for dependencies.

4db2acf

Merge remote-tracking branch 'upstream/main' into validate_ci_yaml_de…

e240387

…ps_pinned

ricardoamador requested a review from CaseyHillers May 27, 2022 22:47

ricardoamador requested a review from keyonghan as a code owner May 27, 2022 22:47

goderbauer added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels May 31, 2022

Updated clang version to use github revision.

2fc746d

CaseyHillers reviewed Jun 2, 2022

View reviewed changes

keyonghan approved these changes Jun 2, 2022

View reviewed changes

CaseyHillers approved these changes Jun 2, 2022

View reviewed changes

ricardoamador changed the title ~~Validate ci yaml deps pinned~~ Add versions to all the dependencies so they are pinned Jun 2, 2022

ricardoamador merged commit ff110fb into flutter:master Jun 2, 2022

ricardoamador deleted the validate_ci_yaml_deps_pinned branch June 2, 2022 20:11

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to d4a963165143 (164 revisions) flutter/packages#2196

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

8866851

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 975e04ba6d48 (165 revisions) flutter/packages#2197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

6f3d7fb

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 889a15eb9df6 (167 revisions) flutter/packages#2198

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

4c5f2d8

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from e8995736bf55 to 889a15eb9df6 (176 revisions) flutter/plugins#5905

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022

ff110fb Add versions to all the dependencies so they are pinned (flut…

a6695cc

…ter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 2e1ebd83b3f6 (173 revisions) flutter/packages#2202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

d5d07eb

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 7996527b7db8 (174 revisions) flutter/packages#2203

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

702d6af

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 81f89aaf6c56 (175 revisions) flutter/packages#2204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

0fcd0cc

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

7694341

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

49e7f25

…utter/flutter#104867)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 8294d9e91e39 (183 revisions) flutter/packages#2207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

4640ad9

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

0e8287e

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

3251271

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

f116e64

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

531002a

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

68602f2

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

691fd75

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

c944d2d

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

78ad73c

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

7afc2fa

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

3e87eb3

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

94cd926

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

61b8be3

…utter/flutter#104867)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Add versions to all the dependencies so they are pinned (flutter#104867)

852b5eb

* Updated file to include version for dependencies. * Updated clang version to use github revision.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

ff110fb95 Add versions to all the dependencies so they are pinned (fl…

ae5442a

…utter/flutter#104867)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

ff110fb Add versions to all the dependencies so they are pinned (flut…

e54df67

…ter/flutter#104867)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add versions to all the dependencies so they are pinned #104867

Add versions to all the dependencies so they are pinned #104867

ricardoamador commented May 27, 2022 •

edited

Loading

CaseyHillers commented May 31, 2022

ricardoamador commented May 31, 2022 •

edited

Loading

CaseyHillers Jun 2, 2022

ricardoamador Jun 2, 2022

CaseyHillers Jun 2, 2022

keyonghan left a comment

Add versions to all the dependencies so they are pinned #104867

Add versions to all the dependencies so they are pinned #104867

Conversation

ricardoamador commented May 27, 2022 • edited Loading

Description of The Issue Being Addressed

Issues Addressed

Pre-launch Checklist

CaseyHillers commented May 31, 2022

ricardoamador commented May 31, 2022 • edited Loading

CaseyHillers Jun 2, 2022

Choose a reason for hiding this comment

ricardoamador Jun 2, 2022

Choose a reason for hiding this comment

CaseyHillers Jun 2, 2022

Choose a reason for hiding this comment

keyonghan left a comment

Choose a reason for hiding this comment

ricardoamador commented May 27, 2022 •

edited

Loading

ricardoamador commented May 31, 2022 •

edited

Loading