Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using FallThroughError. #105600

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Stop using FallThroughError. #105600

merged 3 commits into from
Jun 9, 2022

Conversation

lrhn
Copy link
Contributor

@lrhn lrhn commented Jun 8, 2022

Stop using FallThroughError as a general error representing an "unknown case".

The FallThroughError class was used in Dart 1 to report a switch case reaching its end (because Dart does not support case fall-through like, e.g., C). It was not intended for any other use.
With Dart 2, the class stopped being used because flow analysis made it a compile-time error to be able to reach the end of a switch case.
The class is planned to be removed in Dart 3.0. It's about to be deprecated. That deprecation makes test fail in this repository.

There are uses of FallThroughError in flutter_tools where it represents an "unsupported case".
The recommended error to use for that is UnsupportedError, and this PR changes to using that.

(No open issue, but in-progress CL https://dart-review.googlesource.com/c/sdk/+/247384 will be blocked on occurrences of FallThroughError here.)

lrhn added 3 commits June 8, 2022 17:06
@lrhn
Stop using FallthroughError as a general error.
6232c10 
The `FallthroughError` existed to be thrown in Dart 1 when a `switch` case reached its end without breaking (because Dart does not have fall-through between cases like, e.g., C).
It became unused in Dart 2.0 because control flow analysis made it a compile-time error to be able to reach the end of a `switch` case.
The plan is to remove the class in Dart 3.0. The class is about to be deprecated, which causes Flutter tests to fail.

There are some uses of `FallthroughError` in Flutter tools code to report unexpectedly not matching one of a number of cases.
That situation is usually reported using `UnsupportedError` or similar general `Error` classes, and this PR changes the `FallthroughtError` uses to such.
@lrhn
Update custom_device_config.dart
004c427
@lrhn
Update custom_devices_test.dart
9b7d628
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 8, 2022
jonahwilliams
jonahwilliams approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

werainkhatri
werainkhatri approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit c951d2d into flutter:master Jun 9, 2022
This was referenced Jun 9, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d Stop using FallThroughError. (flutter/flutter#105600)
6944720
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
36c5175
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
5eb390a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
e845112
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d Stop using FallThroughError. (flutter/flutter#105600)
007b5e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
6605bc1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
b5840e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
598c9d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
fef97c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
0fe64a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
21d6625
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
e27307f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
4a4a7b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
ddf08db
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
9fc3333
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
4ce61a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
dd383d4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
2315820
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
a829b12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
b333a8c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
03b303e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
15bad44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
4d855be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
0f7636e
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@lrhn @camsim99
Stop using FallThroughError. (flutter#105600)
0f19624
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c951d2d7a Stop using FallThroughError. (flutter/flutter#105600)
965a844
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
c951d2d Stop using FallThroughError. (flutter/flutter#105600)
3de0129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lrhn @fluttergithubbot @jonahwilliams @werainkhatri